From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: kirkwood: Fix SATA pinmux-ing for TS419
Date: Mon, 20 Feb 2017 13:59:55 +0100 [thread overview]
Message-ID: <20170220135955.63fbcaa3@free-electrons.com> (raw)
In-Reply-To: <20170218003251.GC4152@decadent.org.uk>
Hello,
Adding in Cc all the maintainers of the Kirkwood platforms.
On Sat, 18 Feb 2017 00:32:51 +0000, Ben Hutchings wrote:
> +&pmx_sata0 {
> + marvell,pins = "mpp15";
> +};
> +
> +&pmx_sata1 {
> + marvell,pins = "mpp16";
> +};
This is not only muxing mpp15 as sata0 and mpp16 as sata1, but also
removes the muxing of sata0/sata1 pins described in kirkwood-6282.dtsi:
pmx_sata0: pmx-sata0 {
marvell,pins = "mpp5", "mpp21", "mpp23";
marvell,function = "sata0";
};
pmx_sata1: pmx-sata1 {
marvell,pins = "mpp4", "mpp20", "mpp22";
marvell,function = "sata1";
};
So it means that MPP 4, 5, 20, 21, 22 and 23 will no longer be muxed as
sata0/sata1. Is this really what you want?
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-02-20 12:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-18 0:32 [PATCH] ARM: dts: kirkwood: Fix SATA pinmux-ing for TS419 Ben Hutchings
2017-02-20 12:59 ` Thomas Petazzoni [this message]
2017-02-20 16:40 ` Ben Hutchings
2017-02-20 16:50 ` Thomas Petazzoni
2017-02-20 17:22 ` Ben Hutchings
2017-02-20 20:31 ` Thomas Petazzoni
2017-03-07 17:16 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170220135955.63fbcaa3@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox