linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: cdall@linaro.org (Christoffer Dall)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 2/2] KVM: arm64: Increase number of user memslots to 508
Date: Thu, 23 Feb 2017 11:14:07 +0100	[thread overview]
Message-ID: <20170223101407.GB1409@cbox> (raw)
In-Reply-To: <1486538141-30627-3-git-send-email-linucherian@gmail.com>

On Wed, Feb 08, 2017 at 12:45:41PM +0530, linucherian at gmail.com wrote:
> From: Linu Cherian <linu.cherian@cavium.com>
> 
> Having only 32 memslots is a real constraint for the maximum
> number of PCI devices that can be assigned to a single guest.
> Assuming each PCI device/virtual function having two memory BAR
> regions, we could assign only 15 devices/virtual functions to a
> guest.
> 
> Hence increase KVM_USER_MEM_SLOTS to 508, so that KVM_MEM_SLOTS_NUM is
> 512 as done in other archs like x86 and powerpc.

Actually on powerpc they just define KVM_USER_MEM_SLOTS as 512 directly.

On x86 they define them as 509 and have 3 private mem slots.

I don't understand the difference and as far as I can tell we don't have
any private memslots on arm/arm64, so this is just weird to me.

Thanks,
-Christoffer

> 
> Signed-off-by: Linu Cherian <linu.cherian@cavium.com>
> ---
>  arch/arm64/include/asm/kvm_host.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/include/asm/kvm_host.h b/arch/arm64/include/asm/kvm_host.h
> index e505038..88f017d 100644
> --- a/arch/arm64/include/asm/kvm_host.h
> +++ b/arch/arm64/include/asm/kvm_host.h
> @@ -30,7 +30,7 @@
>  
>  #define __KVM_HAVE_ARCH_INTC_INITIALIZED
>  
> -#define KVM_USER_MEM_SLOTS 32
> +#define KVM_USER_MEM_SLOTS 508
>  #define KVM_PRIVATE_MEM_SLOTS 4
>  #define KVM_COALESCED_MMIO_PAGE_OFFSET 1
>  #define KVM_HALT_POLL_NS_DEFAULT 500000
> -- 
> 1.9.1
> 

  reply	other threads:[~2017-02-23 10:14 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-08  7:15 [PATCH V2 0/2] KVM: arm64: Increase number of user memslots linucherian at gmail.com
2017-02-08  7:15 ` [PATCH V2 1/2] KVM: arm/arm64: Enable KVM_CAP_NR_MEMSLOTS on arm/arm64 linucherian at gmail.com
2017-02-23 10:10   ` Christoffer Dall
2017-02-26  4:30     ` Linu Cherian
2017-02-08  7:15 ` [PATCH V2 2/2] KVM: arm64: Increase number of user memslots to 508 linucherian at gmail.com
2017-02-23 10:14   ` Christoffer Dall [this message]
2017-02-26  7:06     ` Linu Cherian
2017-03-02 12:29       ` Christoffer Dall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170223101407.GB1409@cbox \
    --to=cdall@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).