From mboxrd@z Thu Jan 1 00:00:00 1970 From: dan.carpenter@oracle.com (Dan Carpenter) Date: Sat, 25 Feb 2017 07:11:11 +0300 Subject: [PATCH] staging: bcm2835: Fix a memory leak in error handling path In-Reply-To: <398315856.259038.1487972318815@email.1und1.de> References: <20170219103412.10092-1-christophe.jaillet@wanadoo.fr> <6585ca42-71f4-1517-c6fc-b9ed2f23c687@i2se.com> <20170224195731.GB4480@mwanda> <398315856.259038.1487972318815@email.1und1.de> Message-ID: <20170225041111.GB4429@mwanda> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Feb 24, 2017 at 10:38:38PM +0100, Stefan Wahren wrote: > > > Dan Carpenter hat am 24. Februar 2017 um 20:57 geschrieben: > > > > > > On Fri, Feb 24, 2017 at 01:37:30PM +0100, Stefan Wahren wrote: > > > Hi Christophe, > > > > > > Am 19.02.2017 um 11:34 schrieb Christophe JAILLET: > > > >If 'kzalloc()' fails, we should release resources allocated so far, just as > > > >done in all other cases in this function. > > > > > > > >Signed-off-by: Christophe JAILLET > > > >--- > > > >Not sure that the error handling path is correct. > > > >Is 'gdev[0]' freed? Should it be? > > > > > > > Yes, but I already sent a patch to fix this and your leak as well and > > Greg merged it. > > My leak? I'm confused. The one you're fixing I mean.