* [PATCH] ARM: dts: am57xx-idk: tpic2810 is on I2C bus, not SPI
@ 2017-02-15 15:12 Sekhar Nori
2017-02-15 15:42 ` Andrew F. Davis
0 siblings, 1 reply; 3+ messages in thread
From: Sekhar Nori @ 2017-02-15 15:12 UTC (permalink / raw)
To: linux-arm-kernel
commit 50e95b6b854c ("ARM: dts: am57xx-idk: Add Industrial
output support") added the TPIC2810 device-tree node under
SPI bus instead of I2C1.
Fix it. Tested on AM572x IDK by driving on-board LEDs
connected to TPIC2810
Fixes: 50e95b6b854c ("ARM: dts: am57xx-idk: Add Industrial output support")
Signed-off-by: Sekhar Nori <nsekhar@ti.com>
---
arch/arm/boot/dts/am57xx-idk-common.dtsi | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/arch/arm/boot/dts/am57xx-idk-common.dtsi b/arch/arm/boot/dts/am57xx-idk-common.dtsi
index 814a720d5c3d..d0a55b845690 100644
--- a/arch/arm/boot/dts/am57xx-idk-common.dtsi
+++ b/arch/arm/boot/dts/am57xx-idk-common.dtsi
@@ -311,6 +311,13 @@
/* ID & VBUS GPIOs provided in board dts */
};
};
+
+ tpic2810: tpic2810 at 60 {
+ compatible = "ti,tpic2810";
+ reg = <0x60>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ };
};
&mcspi3 {
@@ -326,13 +333,6 @@
spi-max-frequency = <1000000>;
spi-cpol;
};
-
- tpic2810: tpic2810 at 60 {
- compatible = "ti,tpic2810";
- reg = <0x60>;
- gpio-controller;
- #gpio-cells = <2>;
- };
};
&uart3 {
--
2.9.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH] ARM: dts: am57xx-idk: tpic2810 is on I2C bus, not SPI
2017-02-15 15:12 [PATCH] ARM: dts: am57xx-idk: tpic2810 is on I2C bus, not SPI Sekhar Nori
@ 2017-02-15 15:42 ` Andrew F. Davis
2017-02-28 16:37 ` Tony Lindgren
0 siblings, 1 reply; 3+ messages in thread
From: Andrew F. Davis @ 2017-02-15 15:42 UTC (permalink / raw)
To: linux-arm-kernel
On 02/15/2017 09:12 AM, Sekhar Nori wrote:
> commit 50e95b6b854c ("ARM: dts: am57xx-idk: Add Industrial
> output support") added the TPIC2810 device-tree node under
> SPI bus instead of I2C1.
>
Well that's odd, looks like git could get confused by the lack of
context around the node during rebases. Anyway,
Acked-by: Andrew F. Davis <afd@ti.com>
> Fix it. Tested on AM572x IDK by driving on-board LEDs
> connected to TPIC2810
>
> Fixes: 50e95b6b854c ("ARM: dts: am57xx-idk: Add Industrial output support")
> Signed-off-by: Sekhar Nori <nsekhar@ti.com>
> ---
> arch/arm/boot/dts/am57xx-idk-common.dtsi | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/arch/arm/boot/dts/am57xx-idk-common.dtsi b/arch/arm/boot/dts/am57xx-idk-common.dtsi
> index 814a720d5c3d..d0a55b845690 100644
> --- a/arch/arm/boot/dts/am57xx-idk-common.dtsi
> +++ b/arch/arm/boot/dts/am57xx-idk-common.dtsi
> @@ -311,6 +311,13 @@
> /* ID & VBUS GPIOs provided in board dts */
> };
> };
> +
> + tpic2810: tpic2810 at 60 {
> + compatible = "ti,tpic2810";
> + reg = <0x60>;
> + gpio-controller;
> + #gpio-cells = <2>;
> + };
> };
>
> &mcspi3 {
> @@ -326,13 +333,6 @@
> spi-max-frequency = <1000000>;
> spi-cpol;
> };
> -
> - tpic2810: tpic2810 at 60 {
> - compatible = "ti,tpic2810";
> - reg = <0x60>;
> - gpio-controller;
> - #gpio-cells = <2>;
> - };
> };
>
> &uart3 {
>
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH] ARM: dts: am57xx-idk: tpic2810 is on I2C bus, not SPI
2017-02-15 15:42 ` Andrew F. Davis
@ 2017-02-28 16:37 ` Tony Lindgren
0 siblings, 0 replies; 3+ messages in thread
From: Tony Lindgren @ 2017-02-28 16:37 UTC (permalink / raw)
To: linux-arm-kernel
* Andrew F. Davis <afd@ti.com> [170215 07:43]:
> On 02/15/2017 09:12 AM, Sekhar Nori wrote:
> > commit 50e95b6b854c ("ARM: dts: am57xx-idk: Add Industrial
> > output support") added the TPIC2810 device-tree node under
> > SPI bus instead of I2C1.
> >
>
> Well that's odd, looks like git could get confused by the lack of
> context around the node during rebases. Anyway,
>
> Acked-by: Andrew F. Davis <afd@ti.com>
Applying into omap-for-v4.11/fixes thanks.
Tony
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-02-28 16:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-15 15:12 [PATCH] ARM: dts: am57xx-idk: tpic2810 is on I2C bus, not SPI Sekhar Nori
2017-02-15 15:42 ` Andrew F. Davis
2017-02-28 16:37 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).