Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: viresh.kumar@linaro.org (Viresh Kumar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] cpufreq: mt8173: Add support for MT8176 and MT817x compatibles
Date: Thu, 2 Mar 2017 16:09:57 +0530	[thread overview]
Message-ID: <20170302103957.GB13760@vireshk-i7> (raw)
In-Reply-To: <20170302103626.69195-1-djkurtz@chromium.org>

On 02-03-17, 18:36, Daniel Kurtz wrote:
> The Mediatek MT8173 is just on of several SOCs from the same MT817x family,

s/on/one

> including the 6-core (4-little/2-big) MT8176.
> 
> The mt8173-cpufreq driver supports all of these SOCs, however, machines
> using them may use a different machine compatible.
> 
> Since this driver checks explicitly for the machine compatible string, add
> support for the whole family.
> 
> Signed-off-by: Daniel Kurtz <djkurtz@chromium.org>
> ---
> This patch is based on the compatibles added by the MT8176 series:
> 
>  https://patchwork.kernel.org/patch/9573209/
>  https://patchwork.kernel.org/patch/9573213/
> 
>  drivers/cpufreq/mt8173-cpufreq.c | 25 +++++++++++++++++++++++--
>  1 file changed, 23 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/cpufreq/mt8173-cpufreq.c b/drivers/cpufreq/mt8173-cpufreq.c
> index ab25b1235a5e..07f7aac56f31 100644
> --- a/drivers/cpufreq/mt8173-cpufreq.c
> +++ b/drivers/cpufreq/mt8173-cpufreq.c
> @@ -573,13 +573,34 @@ static struct platform_driver mt8173_cpufreq_platdrv = {
>  	.probe		= mt8173_cpufreq_probe,
>  };
>  
> +/* List of machine compatible strings supported by this driver */
> +static const char *mt8173_cpufreq_machines[] = {
> +	"mediatek,mt817x",
> +	"mediatek,mt8173",
> +	"mediatek,mt8176",
> +};
> +
> +static int mt8173_cpufreq_is_compatible(void)
> +{
> +	int i;
> +
> +	for (i = 0; i < ARRAY_SIZE(mt8173_cpufreq_machines); i++)
> +		if (of_machine_is_compatible(mt8173_cpufreq_machines[i]))
> +			return 0;
> +
> +	return -ENODEV;
> +}
> +
>  static int mt8173_cpufreq_driver_init(void)
>  {
>  	struct platform_device *pdev;
>  	int err;
>  
> -	if (!of_machine_is_compatible("mediatek,mt8173"))
> -		return -ENODEV;
> +	err = mt8173_cpufreq_is_compatible();

Use of_match_node() instead (hint: cpufreq-dt-platdev.c)

> +	if (err) {
> +		pr_err("Machine is not compatible with 'mediatek,mt8173'\n");
> +		return err;
> +	}
>  
>  	err = platform_driver_register(&mt8173_cpufreq_platdrv);
>  	if (err)

-- 
viresh

      reply	other threads:[~2017-03-02 10:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-02 10:36 [PATCH] cpufreq: mt8173: Add support for MT8176 and MT817x compatibles Daniel Kurtz
2017-03-02 10:39 ` Viresh Kumar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170302103957.GB13760@vireshk-i7 \
    --to=viresh.kumar@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox