public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2 01/14] treewide: Move set_memory_* functions away from cacheflush.h
Date: Thu, 2 Mar 2017 14:11:50 +0000	[thread overview]
Message-ID: <20170302141150.GL19632@leverpostej> (raw)
In-Reply-To: <1488413706-9739-2-git-send-email-labbott@redhat.com>

On Wed, Mar 01, 2017 at 04:14:53PM -0800, Laura Abbott wrote:
> diff --git a/arch/arm64/include/asm/Kbuild b/arch/arm64/include/asm/Kbuild
> index a12f1af..e419965 100644
> --- a/arch/arm64/include/asm/Kbuild
> +++ b/arch/arm64/include/asm/Kbuild
> @@ -27,6 +27,7 @@ generic-y += preempt.h
>  generic-y += resource.h
>  generic-y += rwsem.h
>  generic-y += segment.h
> +generic-y += set_memory.h
>  generic-y += sembuf.h
>  generic-y += serial.h

Nit: alphabetical order, please.

>  generic-y += shmbuf.h
> diff --git a/arch/arm64/include/asm/cacheflush.h b/arch/arm64/include/asm/cacheflush.h
> index 5a2a6ee..7db6962 100644
> --- a/arch/arm64/include/asm/cacheflush.h
> +++ b/arch/arm64/include/asm/cacheflush.h
> @@ -20,6 +20,7 @@
>  #define __ASM_CACHEFLUSH_H
>  
>  #include <linux/mm.h>
> +#include <asm/set_memory.h>
>  
>  /*
>   * This flag is used to indicate that the page pointed to by a pte is clean
> @@ -150,9 +151,4 @@ static inline void flush_cache_vunmap(unsigned long start, unsigned long end)
>  {
>  }
>  
> -int set_memory_ro(unsigned long addr, int numpages);
> -int set_memory_rw(unsigned long addr, int numpages);
> -int set_memory_x(unsigned long addr, int numpages);
> -int set_memory_nx(unsigned long addr, int numpages);
> -
>  #endif

> diff --git a/include/asm-generic/set_memory.h b/include/asm-generic/set_memory.h
> new file mode 100644
> index 0000000..83e81f8
> --- /dev/null
> +++ b/include/asm-generic/set_memory.h
> @@ -0,0 +1,12 @@
> +#ifndef __ASM_SET_MEMORY_H
> +#define __ASM_SET_MEMORY_H
> +
> +/*
> + * Functions to change memory attributes.
> + */
> +int set_memory_ro(unsigned long addr, int numpages);
> +int set_memory_rw(unsigned long addr, int numpages);
> +int set_memory_x(unsigned long addr, int numpages);
> +int set_memory_nx(unsigned long addr, int numpages);
> +
> +#endif

Otherwise, this looks fine to me. FWIW:

Acked-by: Mark Rutland <mark.rutland@arm.com>

Thanks,
Mark.

  parent reply	other threads:[~2017-03-02 14:11 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-02  0:14 [PATCHv2 00/14] set_memory_* functions header refactor Laura Abbott
2017-03-02  0:14 ` [PATCHv2 01/14] treewide: Move set_memory_* functions away from cacheflush.h Laura Abbott
2017-03-02 12:07   ` Russell King - ARM Linux
2017-03-02 14:11   ` Mark Rutland [this message]
2017-03-02  0:14 ` [PATCHv2 02/14] arm: Use set_memory.h header Laura Abbott
2017-03-02 12:01   ` Russell King - ARM Linux
2017-03-02  0:14 ` [PATCHv2 03/14] arm64: " Laura Abbott
2017-03-02 14:07   ` Mark Rutland
2017-03-02 15:06   ` Catalin Marinas
2017-03-02  0:14 ` [PATCHv2 04/14] s390: " Laura Abbott
2017-03-02  0:14 ` [PATCHv2 05/14] x86: " Laura Abbott
2017-03-02  8:01   ` Ingo Molnar
2017-03-02  0:14 ` [PATCHv2 06/14] agp: " Laura Abbott
2017-03-02  0:14 ` [PATCHv2 07/14] drm: " Laura Abbott
2017-03-05  1:08   ` kbuild test robot
2017-03-02  0:15 ` [PATCHv2 08/14] intel_th: " Laura Abbott
2017-03-02 11:06   ` Alexander Shishkin
2017-03-02  0:15 ` [PATCHv2 09/14] watchdog: hpwdt: " Laura Abbott
2017-03-02 14:48   ` Guenter Roeck
2017-03-02  0:15 ` [PATCHv2 10/14] bpf: " Laura Abbott
2017-03-02 20:26   ` Daniel Borkmann
2017-03-05  3:01   ` kbuild test robot
2017-03-02  0:15 ` [PATCHv2 11/14] module: " Laura Abbott
2017-03-02 17:09   ` Jessica Yu
2017-03-02  0:15 ` [PATCHv2 12/14] PM / hibernate: " Laura Abbott
2017-03-02  0:15 ` [PATCHv2 13/14] ALSA: hda: " Laura Abbott
2017-03-02  0:15 ` [PATCHv2 14/14] treewide: Decouple cacheflush.h and set_memory.h Laura Abbott
2017-03-02 12:06   ` Russell King - ARM Linux
2017-03-02 14:12   ` Mark Rutland
2017-03-02 15:05   ` Catalin Marinas
2017-03-04 22:57   ` kbuild test robot
2017-03-05  0:03   ` kbuild test robot
2017-03-02  7:34 ` [PATCHv2 00/14] set_memory_* functions header refactor Heiko Carstens

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170302141150.GL19632@leverpostej \
    --to=mark.rutland@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox