From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH DO NOT MERGE 5/6] ARM: dts: omap4: add some sample clkctrl data
Date: Thu, 2 Mar 2017 09:45:03 -0800 [thread overview]
Message-ID: <20170302174503.GP20572@atomide.com> (raw)
In-Reply-To: <1486992157-10673-6-git-send-email-t-kristo@ti.com>
Hi,
* Tero Kristo <t-kristo@ti.com> [170213 05:24]:
> Adds clkctrl nodes for cm_l4per and cm_abe as example. Peripherals using
> clocks from these nodes are modified also.
Finally got around testing these. Looks like applying this patch
breaks things for devices not using the new clocks entry?
For example, SPI now breaks causing "imprecise external abort" during boot
at least on droid 4.
> --- a/arch/arm/boot/dts/omap4.dtsi
> +++ b/arch/arm/boot/dts/omap4.dtsi
> + cm_l4per: cm_l4per at 0 {
Above should be cm_l4per: cm_l4per at 1400, right?
> + compatible = "ti,omap4-cm";
> + reg = <0x1400 0x200>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges = <0 0x1400 0x200>;
> +
> + cm_l4per_clkctrl: cm_l4per_clkctrl at 20 {
> + compatible = "ti,omap4-clkctrl";
> + reg = <0x20 0x1b0>;
> + #clock-cells = <2>;
> + };
> + };
You should update the binding doc accordingly if the "cm_l4per at 0" node
there is not needed. I also noticed the binding doc still has
"#clock-cells = <4>" while it should be 2.
Regards,
Tony
next prev parent reply other threads:[~2017-03-02 17:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-13 13:22 clk: ti: clkctrl clock support Tero Kristo
2017-02-13 13:22 ` [PATCH 1/6] clk: ti: add support for clkctrl clocks Tero Kristo
2017-02-13 13:22 ` [PATCH 2/6] dt-bindings: clk: add omap4 clkctrl definitions Tero Kristo
2017-02-13 13:27 ` Tero Kristo
2017-02-13 13:22 ` [PATCH 3/6] clk: ti: omap4: add clkctrl clock data Tero Kristo
2017-02-13 13:22 ` [PATCH 4/6] ARM: OMAP2+: hwmod: assign hwmod-ck as main clock from DT if available Tero Kristo
2017-02-13 13:22 ` [PATCH DO NOT MERGE 5/6] ARM: dts: omap4: add some sample clkctrl data Tero Kristo
2017-03-02 17:45 ` Tony Lindgren [this message]
2017-03-02 18:43 ` Tero Kristo
2017-03-02 18:56 ` Tony Lindgren
2017-03-06 22:45 ` Tony Lindgren
2017-03-07 9:04 ` Tero Kristo
2017-03-07 14:45 ` Stephen Boyd
2017-03-07 22:09 ` Tero Kristo
2017-02-13 13:22 ` [PATCH DO NOT MERGE 6/6] ARM: OMAP4: hwmod_data: drop a few clkctrl setups replaced with clocks Tero Kristo
2017-02-13 16:55 ` clk: ti: clkctrl clock support Tony Lindgren
2017-03-02 18:57 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170302174503.GP20572@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).