From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: i.MX7 pinctrl driver writing to non existent registers
Date: Wed, 8 Mar 2017 14:57:53 +0100 [thread overview]
Message-ID: <20170308135751.GB19934@x250> (raw)
In-Reply-To: <20170208090817.omm2dydhqukdzgqy@pengutronix.de>
On Wed, Feb 08, 2017 at 10:08:17AM +0100, Sascha Hauer wrote:
> Hi All,
>
> The i.MX7 has two pinmux controllers, the LPSR and the regular one. We
> instantiate a driver for each one. Now the driver assumes that the pins
> are completely configured with one iomux controller, but for the LPSR
> pins this is not true: The MUX_CTL and PAD_CTL registers are indeed
> in the LPSR controller, but the SELECT_INPUT registers for the same
> pin are found in the regular controller.
>
> The result is that with this pin for example:
>
> #define MX7D_PAD_GPIO1_IO06__UART5_DCE_RX 0x0018 0x0048 0x0714 0x3 0x4
>
> The LPSR controller writes to LPSR_BASE + 0x714 where it should really
> be IOMUX_BASE + 0x714.
Isn't property fsl,input-sel being there for addressing that?
Shawn
next prev parent reply other threads:[~2017-03-08 13:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-08 9:08 i.MX7 pinctrl driver writing to non existent registers Sascha Hauer
2017-02-08 15:28 ` Jean-Christophe PLAGNIOL-VILLARD
2017-03-08 13:57 ` Shawn Guo [this message]
2017-03-09 7:21 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170308135751.GB19934@x250 \
--to=shawnguo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox