linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: imx53-qsb: Constrain the TVE DAC voltage
@ 2017-02-08 12:33 Fabio Estevam
  2017-03-08 14:01 ` Shawn Guo
  0 siblings, 1 reply; 2+ messages in thread
From: Fabio Estevam @ 2017-02-08 12:33 UTC (permalink / raw)
  To: linux-arm-kernel

Quoting Philipp Zabel:
"Since this regulator is used as the TVDAC analog power supply, this
range should at least be limited to the analog power supply range of the
TVDAC, listed in Table 74-9. of the i.MX53 reference manual (2.5-2.75V).

But since the nominal voltage is 2.75V, which was used to determine the
analog gain that is supposed to result in the necessary 0.7V
peak-to-peak amplitude on the VGA output, I'd say we should just fix the
voltage to 2750000 here."

, so limit the TVDAC analog power supply as suggested.

Suggested-by: Lucas Stach <l.stach@pengutronix.de>
Suggested-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
 arch/arm/boot/dts/imx53-qsb.dts  | 4 ++--
 arch/arm/boot/dts/imx53-qsrb.dts | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm/boot/dts/imx53-qsb.dts b/arch/arm/boot/dts/imx53-qsb.dts
index f4c158c..d3d662e 100644
--- a/arch/arm/boot/dts/imx53-qsb.dts
+++ b/arch/arm/boot/dts/imx53-qsb.dts
@@ -88,8 +88,8 @@
 			};
 
 			ldo7_reg: ldo7 {
-				regulator-min-microvolt = <1200000>;
-				regulator-max-microvolt = <3600000>;
+				regulator-min-microvolt = <2750000>;
+				regulator-max-microvolt = <2750000>;
 			};
 
 			ldo8_reg: ldo8 {
diff --git a/arch/arm/boot/dts/imx53-qsrb.dts b/arch/arm/boot/dts/imx53-qsrb.dts
index 479ca4c..de22158 100644
--- a/arch/arm/boot/dts/imx53-qsrb.dts
+++ b/arch/arm/boot/dts/imx53-qsrb.dts
@@ -128,8 +128,8 @@
 
 			vdac_reg: vdac {
 				regulator-name = "VDAC";
-				regulator-min-microvolt = <2500000>;
-				regulator-max-microvolt = <2775000>;
+				regulator-min-microvolt = <2750000>;
+				regulator-max-microvolt = <2750000>;
 			};
 
 			vgen1_reg: vgen1 {
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH] ARM: dts: imx53-qsb: Constrain the TVE DAC voltage
  2017-02-08 12:33 [PATCH] ARM: dts: imx53-qsb: Constrain the TVE DAC voltage Fabio Estevam
@ 2017-03-08 14:01 ` Shawn Guo
  0 siblings, 0 replies; 2+ messages in thread
From: Shawn Guo @ 2017-03-08 14:01 UTC (permalink / raw)
  To: linux-arm-kernel

On Wed, Feb 08, 2017 at 10:33:51AM -0200, Fabio Estevam wrote:
> Quoting Philipp Zabel:
> "Since this regulator is used as the TVDAC analog power supply, this
> range should at least be limited to the analog power supply range of the
> TVDAC, listed in Table 74-9. of the i.MX53 reference manual (2.5-2.75V).
> 
> But since the nominal voltage is 2.75V, which was used to determine the
> analog gain that is supposed to result in the necessary 0.7V
> peak-to-peak amplitude on the VGA output, I'd say we should just fix the
> voltage to 2750000 here."
> 
> , so limit the TVDAC analog power supply as suggested.
> 
> Suggested-by: Lucas Stach <l.stach@pengutronix.de>
> Suggested-by: Philipp Zabel <p.zabel@pengutronix.de>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>

Applied, thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-03-08 14:01 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-08 12:33 [PATCH] ARM: dts: imx53-qsb: Constrain the TVE DAC voltage Fabio Estevam
2017-03-08 14:01 ` Shawn Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).