* [PATCH 1/3] mmc: sdhci-pxav3: remove unnecessary platform_set_drvdata() call
2017-03-10 3:17 [PATCH 0/3] mmc: sdhci: remove unnecessary platform_set_drvdata() call Jisheng Zhang
@ 2017-03-10 3:17 ` Jisheng Zhang
2017-03-10 3:17 ` [PATCH 2/3] mmc: sdhci-pxav2: " Jisheng Zhang
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Jisheng Zhang @ 2017-03-10 3:17 UTC (permalink / raw)
To: linux-arm-kernel
sdhci_pltfm_init() has already set the platform drvdata for us, remove
the unnecessary platform_set_drvdata() call.
Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
---
drivers/mmc/host/sdhci-pxav3.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/mmc/host/sdhci-pxav3.c b/drivers/mmc/host/sdhci-pxav3.c
index d0f5c05fbc19..132670a612a0 100644
--- a/drivers/mmc/host/sdhci-pxav3.c
+++ b/drivers/mmc/host/sdhci-pxav3.c
@@ -480,8 +480,6 @@ static int sdhci_pxav3_probe(struct platform_device *pdev)
goto err_add_host;
}
- platform_set_drvdata(pdev, host);
-
if (host->mmc->pm_caps & MMC_PM_WAKE_SDIO_IRQ)
device_init_wakeup(&pdev->dev, 1);
--
2.11.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/3] mmc: sdhci-pxav2: remove unnecessary platform_set_drvdata() call
2017-03-10 3:17 [PATCH 0/3] mmc: sdhci: remove unnecessary platform_set_drvdata() call Jisheng Zhang
2017-03-10 3:17 ` [PATCH 1/3] mmc: sdhci-pxav3: " Jisheng Zhang
@ 2017-03-10 3:17 ` Jisheng Zhang
2017-03-10 3:17 ` [PATCH 3/3] mmc: sdhci-st: " Jisheng Zhang
2017-03-16 14:46 ` [PATCH 0/3] mmc: sdhci: " Ulf Hansson
3 siblings, 0 replies; 6+ messages in thread
From: Jisheng Zhang @ 2017-03-10 3:17 UTC (permalink / raw)
To: linux-arm-kernel
sdhci_pltfm_init() has already set the platform drvdata for us, remove
the unnecessary platform_set_drvdata() call.
Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
---
drivers/mmc/host/sdhci-pxav2.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/mmc/host/sdhci-pxav2.c b/drivers/mmc/host/sdhci-pxav2.c
index 347eae2d7b6a..74e21ad699e0 100644
--- a/drivers/mmc/host/sdhci-pxav2.c
+++ b/drivers/mmc/host/sdhci-pxav2.c
@@ -222,8 +222,6 @@ static int sdhci_pxav2_probe(struct platform_device *pdev)
goto err_add_host;
}
- platform_set_drvdata(pdev, host);
-
return 0;
err_add_host:
--
2.11.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 3/3] mmc: sdhci-st: remove unnecessary platform_set_drvdata() call
2017-03-10 3:17 [PATCH 0/3] mmc: sdhci: remove unnecessary platform_set_drvdata() call Jisheng Zhang
2017-03-10 3:17 ` [PATCH 1/3] mmc: sdhci-pxav3: " Jisheng Zhang
2017-03-10 3:17 ` [PATCH 2/3] mmc: sdhci-pxav2: " Jisheng Zhang
@ 2017-03-10 3:17 ` Jisheng Zhang
2017-03-10 8:40 ` Patrice CHOTARD
2017-03-16 14:46 ` [PATCH 0/3] mmc: sdhci: " Ulf Hansson
3 siblings, 1 reply; 6+ messages in thread
From: Jisheng Zhang @ 2017-03-10 3:17 UTC (permalink / raw)
To: linux-arm-kernel
sdhci_pltfm_init() has already set the platform drvdata for us, remove
the unnecessary platform_set_drvdata() call.
Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
---
drivers/mmc/host/sdhci-st.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/mmc/host/sdhci-st.c b/drivers/mmc/host/sdhci-st.c
index ed92ce729dde..7fff6490855c 100644
--- a/drivers/mmc/host/sdhci-st.c
+++ b/drivers/mmc/host/sdhci-st.c
@@ -418,8 +418,6 @@ static int sdhci_st_probe(struct platform_device *pdev)
goto err_out;
}
- platform_set_drvdata(pdev, host);
-
host_version = readw_relaxed((host->ioaddr + SDHCI_HOST_VERSION));
dev_info(&pdev->dev, "SDHCI ST Initialised: Host Version: 0x%x Vendor Version 0x%x\n",
--
2.11.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 3/3] mmc: sdhci-st: remove unnecessary platform_set_drvdata() call
2017-03-10 3:17 ` [PATCH 3/3] mmc: sdhci-st: " Jisheng Zhang
@ 2017-03-10 8:40 ` Patrice CHOTARD
0 siblings, 0 replies; 6+ messages in thread
From: Patrice CHOTARD @ 2017-03-10 8:40 UTC (permalink / raw)
To: linux-arm-kernel
Hi Jisheng
On 03/10/2017 04:17 AM, Jisheng Zhang wrote:
> sdhci_pltfm_init() has already set the platform drvdata for us, remove
> the unnecessary platform_set_drvdata() call.
>
> Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
> ---
> drivers/mmc/host/sdhci-st.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-st.c b/drivers/mmc/host/sdhci-st.c
> index ed92ce729dde..7fff6490855c 100644
> --- a/drivers/mmc/host/sdhci-st.c
> +++ b/drivers/mmc/host/sdhci-st.c
> @@ -418,8 +418,6 @@ static int sdhci_st_probe(struct platform_device *pdev)
> goto err_out;
> }
>
> - platform_set_drvdata(pdev, host);
> -
> host_version = readw_relaxed((host->ioaddr + SDHCI_HOST_VERSION));
>
> dev_info(&pdev->dev, "SDHCI ST Initialised: Host Version: 0x%x Vendor Version 0x%x\n",
>
Acked-by: Patrice Chotard <patrice.chotard@st.com>
Thanks
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 0/3] mmc: sdhci: remove unnecessary platform_set_drvdata() call
2017-03-10 3:17 [PATCH 0/3] mmc: sdhci: remove unnecessary platform_set_drvdata() call Jisheng Zhang
` (2 preceding siblings ...)
2017-03-10 3:17 ` [PATCH 3/3] mmc: sdhci-st: " Jisheng Zhang
@ 2017-03-16 14:46 ` Ulf Hansson
3 siblings, 0 replies; 6+ messages in thread
From: Ulf Hansson @ 2017-03-16 14:46 UTC (permalink / raw)
To: linux-arm-kernel
On 10 March 2017 at 04:17, Jisheng Zhang <jszhang@marvell.com> wrote:
> sdhci_pltfm_init() has already set the platform drvdata for us, so its
> users doesn't need to set the drvdata again. These patches clean up all
> unnecessary platform_set_drvdata() call.
>
> Jisheng Zhang (3):
> mmc: sdhci-pxav3: remove unnecessary platform_set_drvdata() call
> mmc: sdhci-pxav2: remove unnecessary platform_set_drvdata() call
> mmc: sdhci-st: remove unnecessary platform_set_drvdata() call
>
> drivers/mmc/host/sdhci-pxav2.c | 2 --
> drivers/mmc/host/sdhci-pxav3.c | 2 --
> drivers/mmc/host/sdhci-st.c | 2 --
> 3 files changed, 6 deletions(-)
>
> --
> 2.11.0
>
Thanks, applied for next!
Kind regards
Uffe
^ permalink raw reply [flat|nested] 6+ messages in thread