[PATCH v2 1/6] ARM: dts: r8a73a4: Add INTC-SYS clock to device tree

[PATCH v2 1/6] ARM: dts: r8a73a4: Add INTC-SYS clock to device tree

[Sergei Shtylyov]

Hello!

On 3/6/2017 7:58 PM, Geert Uytterhoeven wrote:

> Link the ARM GIC to the INTC-SYS module clock and the C4 power domain,
> so it can be power managed using that clock in the future.
>
> Note that currently the GIC-400 driver doesn't support module clocks nor
> Runtime PM, so this must be handled as a critical clock.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> v2:
>   - Add missing "power-domains" property,
>   - Add clock-names property,
>   - Drop RFC status,
>   - Change one-line summary prefix to match current arm-soc practices,
>   - s/GIC driver/GIC-400 driver/,
>   - Document critical clock dependency.
> ---
>  arch/arm/boot/dts/r8a73a4.dtsi            | 13 +++++++++----
>  include/dt-bindings/clock/r8a73a4-clock.h |  1 +
>  2 files changed, 10 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/r8a73a4.dtsi b/arch/arm/boot/dts/r8a73a4.dtsi
> index 6fb7eaba91262edf..1f5c9f6dddba9366 100644
> --- a/arch/arm/boot/dts/r8a73a4.dtsi
> +++ b/arch/arm/boot/dts/r8a73a4.dtsi
> @@ -467,6 +467,9 @@
>  			<0 0xf1004000 0 0x2000>,
>  			<0 0xf1006000 0 0x2000>;
>  		interrupts = <GIC_PPI 9 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>;
> +		clocks = <&mstp4_clks R8A73A4_CLK_INTC_SYS>;
> +		clock-names = "clk";

    Do we really need such "clock-names"?

[...]

MBR, Sergei

[PATCH v2 1/6] ARM: dts: r8a73a4: Add INTC-SYS clock to device tree

[Geert Uytterhoeven]

Hi Sergei,

On Tue, Mar 7, 2017 at 10:27 AM, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> On 3/6/2017 7:58 PM, Geert Uytterhoeven wrote:
>> Link the ARM GIC to the INTC-SYS module clock and the C4 power domain,
>> so it can be power managed using that clock in the future.
>>
>> Note that currently the GIC-400 driver doesn't support module clocks nor
>> Runtime PM, so this must be handled as a critical clock.
>>
>> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>> ---
>> v2:
>>   - Add missing "power-domains" property,
>>   - Add clock-names property,
>>   - Drop RFC status,
>>   - Change one-line summary prefix to match current arm-soc practices,
>>   - s/GIC driver/GIC-400 driver/,
>>   - Document critical clock dependency.
>> ---
>>  arch/arm/boot/dts/r8a73a4.dtsi            | 13 +++++++++----
>>  include/dt-bindings/clock/r8a73a4-clock.h |  1 +
>>  2 files changed, 10 insertions(+), 4 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/r8a73a4.dtsi
>> b/arch/arm/boot/dts/r8a73a4.dtsi
>> index 6fb7eaba91262edf..1f5c9f6dddba9366 100644
>> --- a/arch/arm/boot/dts/r8a73a4.dtsi
>> +++ b/arch/arm/boot/dts/r8a73a4.dtsi
>> @@ -467,6 +467,9 @@
>>                         <0 0xf1004000 0 0x2000>,
>>                         <0 0xf1006000 0 0x2000>;
>>                 interrupts = <GIC_PPI 9 (GIC_CPU_MASK_SIMPLE(4) |
>> IRQ_TYPE_LEVEL_HIGH)>;
>> +               clocks = <&mstp4_clks R8A73A4_CLK_INTC_SYS>;
>> +               clock-names = "clk";
>
>    Do we really need such "clock-names"?

Yes. The ARM/GIC maintainers objected against not using clock-names, as
some GIC variants have multiple clocks.
Hence commit afbbd23381767aec ("irqchip/gic: Document optional Clock and
Power Domain properties") was born...

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

[PATCH v2 0/6] ARM: dts: renesas: Add INTC-SYS clock to device tree

[Simon Horman]

On Mon, Mar 06, 2017 at 05:58:05PM +0100, Geert Uytterhoeven wrote:
> 	Hi Simon, Magnus,
> 
> This patch series improves the topology description in DT of the ARM GIC
> on Renesas SoCs using the legacy CPG/MSTP bindings (R-Mobile APE6 and
> R-Car Gen2).  It describes the INTC-SYS clock, links the GIC to its
> module clock, and adds the GIC to the SYSC "always on" PM Domain.
> 
> Note that currently the GIC-400 driver doesn't support module clocks nor
> Runtime PM, so this must be handled as a critical clock.  Hence this
> series depends on commit e34084fb9a023d1d ("clk: renesas: mstp: Make
> INTC-SYS a critical clock"), which is in v4.11-rc1.
> 
> This series is the counterpart of "[PATCH 0/4] ARM/arm64: dts: renesas:
> Link ARM GIC to clock and clock domain" for SoCs not yet migrated to the
> new CPG/MSSR driver.  The latter is already part of v4.11-rc1 as it had
> less dependencies.
> 
> Changes compared to v1:
>   - Add missing "power-domains" property,
>   - Add clock-names property,
>   - Rebased on top of CPG Clock Domain and R-Car SYSC PM Domain support,
>   - Add r8a7792 patch,
>   - Please refer to the individual patch changelogs for more details
>     (v1 dates back to 2014).
> 
> Thanks for applying!

Thanks, done.

[PATCH v2 0/6] ARM: dts: renesas: Add INTC-SYS clock to device tree

[Geert Uytterhoeven]

Hi Simon,

On Fri, Mar 10, 2017 at 10:21 AM, Simon Horman <horms@verge.net.au> wrote:
> On Mon, Mar 06, 2017 at 05:58:05PM +0100, Geert Uytterhoeven wrote:
>> This patch series improves the topology description in DT of the ARM GIC
>> on Renesas SoCs using the legacy CPG/MSTP bindings (R-Mobile APE6 and
>> R-Car Gen2).  It describes the INTC-SYS clock, links the GIC to its
>> module clock, and adds the GIC to the SYSC "always on" PM Domain.
>>
>> Note that currently the GIC-400 driver doesn't support module clocks nor
>> Runtime PM, so this must be handled as a critical clock.  Hence this
>> series depends on commit e34084fb9a023d1d ("clk: renesas: mstp: Make
>> INTC-SYS a critical clock"), which is in v4.11-rc1.
>>
>> This series is the counterpart of "[PATCH 0/4] ARM/arm64: dts: renesas:
>> Link ARM GIC to clock and clock domain" for SoCs not yet migrated to the
>> new CPG/MSSR driver.  The latter is already part of v4.11-rc1 as it had
>> less dependencies.
>>
>> Changes compared to v1:
>>   - Add missing "power-domains" property,
>>   - Add clock-names property,
>>   - Rebased on top of CPG Clock Domain and R-Car SYSC PM Domain support,
>>   - Add r8a7792 patch,
>>   - Please refer to the individual patch changelogs for more details
>>     (v1 dates back to 2014).
>>
>> Thanks for applying!
>
> Thanks, done.

Thanks, but it seems you forgot "ARM: dts: r8a7793: Add INTC-SYS clock to
device tree"?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

[PATCH v2 0/6] ARM: dts: renesas: Add INTC-SYS clock to device tree

[Simon Horman]

On Fri, Mar 10, 2017 at 12:19:07PM +0100, Geert Uytterhoeven wrote:
> Hi Simon,
> 
> On Fri, Mar 10, 2017 at 10:21 AM, Simon Horman <horms@verge.net.au> wrote:
> > On Mon, Mar 06, 2017 at 05:58:05PM +0100, Geert Uytterhoeven wrote:
> >> This patch series improves the topology description in DT of the ARM GIC
> >> on Renesas SoCs using the legacy CPG/MSTP bindings (R-Mobile APE6 and
> >> R-Car Gen2).  It describes the INTC-SYS clock, links the GIC to its
> >> module clock, and adds the GIC to the SYSC "always on" PM Domain.
> >>
> >> Note that currently the GIC-400 driver doesn't support module clocks nor
> >> Runtime PM, so this must be handled as a critical clock.  Hence this
> >> series depends on commit e34084fb9a023d1d ("clk: renesas: mstp: Make
> >> INTC-SYS a critical clock"), which is in v4.11-rc1.
> >>
> >> This series is the counterpart of "[PATCH 0/4] ARM/arm64: dts: renesas:
> >> Link ARM GIC to clock and clock domain" for SoCs not yet migrated to the
> >> new CPG/MSSR driver.  The latter is already part of v4.11-rc1 as it had
> >> less dependencies.
> >>
> >> Changes compared to v1:
> >>   - Add missing "power-domains" property,
> >>   - Add clock-names property,
> >>   - Rebased on top of CPG Clock Domain and R-Car SYSC PM Domain support,
> >>   - Add r8a7792 patch,
> >>   - Please refer to the individual patch changelogs for more details
> >>     (v1 dates back to 2014).
> >>
> >> Thanks for applying!
> >
> > Thanks, done.
> 
> Thanks, but it seems you forgot "ARM: dts: r8a7793: Add INTC-SYS clock to
> device tree"?

Sorry about that, I have it queued up now.