[PATCH v2] generic syscalls: Wire up statx syscall

[PATCH v2] generic syscalls: Wire up statx syscall

[Stafford Horne]

The new syscall statx is implemented as generic code, so enable it
for architectures like openrisc which use the generic syscall table.

Fixes: a528d35e8bfcc ("statx: Add a system call to make enhanced file info available")
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: David Howells <dhowells@redhat.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <will.deacon@arm.com>
Cc: linux-arm-kernel at lists.infradead.org
Signed-off-by: Stafford Horne <shorne@gmail.com>
---
Change in v2:
 - Add a few more Cc's to get attention of the right people
 - Add a fixes tag for better audit

 include/uapi/asm-generic/unistd.h | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/include/uapi/asm-generic/unistd.h b/include/uapi/asm-generic/unistd.h
index 9b1462e..a076cf1 100644
--- a/include/uapi/asm-generic/unistd.h
+++ b/include/uapi/asm-generic/unistd.h
@@ -730,9 +730,11 @@ __SYSCALL(__NR_pkey_mprotect, sys_pkey_mprotect)
 __SYSCALL(__NR_pkey_alloc,    sys_pkey_alloc)
 #define __NR_pkey_free 290
 __SYSCALL(__NR_pkey_free,     sys_pkey_free)
+#define __NR_statx 291
+__SYSCALL(__NR_statx,     sys_statx)
 
 #undef __NR_syscalls
-#define __NR_syscalls 291
+#define __NR_syscalls 292
 
 /*
  * All syscalls below here should go away really,
-- 
2.9.3

[PATCH v2] generic syscalls: Wire up statx syscall

[James Hogan]

On 13 March 2017 at 14:45, Stafford Horne <shorne@gmail.com> wrote:
> The new syscall statx is implemented as generic code, so enable it
> for architectures like openrisc which use the generic syscall table.
>
> Fixes: a528d35e8bfcc ("statx: Add a system call to make enhanced file info available")
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Al Viro <viro@zeniv.linux.org.uk>
> Cc: David Howells <dhowells@redhat.com>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Will Deacon <will.deacon@arm.com>
> Cc: linux-arm-kernel at lists.infradead.org
> Signed-off-by: Stafford Horne <shorne@gmail.com>
> ---
> Change in v2:
>  - Add a few more Cc's to get attention of the right people
>  - Add a fixes tag for better audit
>
>  include/uapi/asm-generic/unistd.h | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/include/uapi/asm-generic/unistd.h b/include/uapi/asm-generic/unistd.h
> index 9b1462e..a076cf1 100644
> --- a/include/uapi/asm-generic/unistd.h
> +++ b/include/uapi/asm-generic/unistd.h
> @@ -730,9 +730,11 @@ __SYSCALL(__NR_pkey_mprotect, sys_pkey_mprotect)
>  __SYSCALL(__NR_pkey_alloc,    sys_pkey_alloc)
>  #define __NR_pkey_free 290
>  __SYSCALL(__NR_pkey_free,     sys_pkey_free)
> +#define __NR_statx 291
> +__SYSCALL(__NR_statx,     sys_statx)
>
>  #undef __NR_syscalls
> -#define __NR_syscalls 291
> +#define __NR_syscalls 292

Out of interest, anybody know OTOH which other stat syscalls statx
supersedes (such that they could at some point be disabled by default
in asm-generic for new arches, and implemented in userspace)?

Cheers
-- 
James Hogan

[PATCH v2] generic syscalls: Wire up statx syscall

[Arnd Bergmann]

On Wed, Mar 15, 2017 at 11:26 PM, James Hogan <james.hogan@imgtec.com> wrote:
> On 13 March 2017 at 14:45, Stafford Horne <shorne@gmail.com> wrote:

>>  #undef __NR_syscalls
>> -#define __NR_syscalls 291
>> +#define __NR_syscalls 292
>
> Out of interest, anybody know OTOH which other stat syscalls statx
> supersedes (such that they could at some point be disabled by default
> in asm-generic for new arches, and implemented in userspace)?

It should replace the entire stat family {old,new,}{f,}stat{at,}{64,}, but not
the {f,}statfs{64,} family, which will eventually get another replacement.

      Arnd

[PATCH v2] generic syscalls: Wire up statx syscall

[Will Deacon]

On Mon, Mar 13, 2017 at 11:45:21PM +0900, Stafford Horne wrote:
> The new syscall statx is implemented as generic code, so enable it
> for architectures like openrisc which use the generic syscall table.
> 
> Fixes: a528d35e8bfcc ("statx: Add a system call to make enhanced file info available")
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Al Viro <viro@zeniv.linux.org.uk>
> Cc: David Howells <dhowells@redhat.com>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Will Deacon <will.deacon@arm.com>
> Cc: linux-arm-kernel at lists.infradead.org
> Signed-off-by: Stafford Horne <shorne@gmail.com>
> ---
> Change in v2:
>  - Add a few more Cc's to get attention of the right people
>  - Add a fixes tag for better audit
> 
>  include/uapi/asm-generic/unistd.h | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

As suggested by Arnd, I'll pick this up via arm64 for 4.11. I was on holiday
last week, so sorry for the delay.

Thanks,

Will

[PATCH v2] generic syscalls: Wire up statx syscall

[Stafford Horne]

On Mon, Mar 20, 2017 at 12:33:20PM +0000, Will Deacon wrote:
> On Mon, Mar 13, 2017 at 11:45:21PM +0900, Stafford Horne wrote:
> > The new syscall statx is implemented as generic code, so enable it
> > for architectures like openrisc which use the generic syscall table.
> > 
> > Fixes: a528d35e8bfcc ("statx: Add a system call to make enhanced file info available")
> > Cc: Thomas Gleixner <tglx@linutronix.de>
> > Cc: Al Viro <viro@zeniv.linux.org.uk>
> > Cc: David Howells <dhowells@redhat.com>
> > Cc: Catalin Marinas <catalin.marinas@arm.com>
> > Cc: Will Deacon <will.deacon@arm.com>
> > Cc: linux-arm-kernel at lists.infradead.org
> > Signed-off-by: Stafford Horne <shorne@gmail.com>
> > ---
> > Change in v2:
> >  - Add a few more Cc's to get attention of the right people
> >  - Add a fixes tag for better audit
> > 
> >  include/uapi/asm-generic/unistd.h | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> As suggested by Arnd, I'll pick this up via arm64 for 4.11. I was on holiday
> last week, so sorry for the delay.

Thanks,  I talked to Masami as well, and he told me that might be the
case.

-Stafford

> Thanks,
> 
> Will