From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 23/35] drivers/mfd: Convert remaining uses of pr_warning to pr_warn
Date: Tue, 14 Mar 2017 14:04:55 +0000 [thread overview]
Message-ID: <20170314140455.umlhdbuj3grqtu6i@dell> (raw)
In-Reply-To: <a6c827c14d0b9f4be42e549ec4c629245516e979.1487314667.git.joe@perches.com>
On Thu, 16 Feb 2017, Joe Perches wrote:
> To enable eventual removal of pr_warning
>
> This makes pr_warn use consistent for drivers/mfd
>
> Prior to this patch, there were 4 uses of pr_warning and
> 9 uses of pr_warn in drivers/mfd
>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
> drivers/mfd/db8500-prcmu.c | 2 +-
> drivers/mfd/sta2x11-mfd.c | 4 ++--
> drivers/mfd/twl4030-power.c | 7 ++-----
> 3 files changed, 5 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/mfd/db8500-prcmu.c b/drivers/mfd/db8500-prcmu.c
> index ca38a6a14110..5c739ac752e8 100644
> --- a/drivers/mfd/db8500-prcmu.c
> +++ b/drivers/mfd/db8500-prcmu.c
> @@ -2377,7 +2377,7 @@ static void ack_dbb_wakeup(void)
>
> static inline void print_unknown_header_warning(u8 n, u8 header)
> {
> - pr_warning("prcmu: Unknown message header (%d) in mailbox %d.\n",
> + pr_warn("prcmu: Unknown message header (%d) in mailbox %d\n",
> header, n);
> }
>
> diff --git a/drivers/mfd/sta2x11-mfd.c b/drivers/mfd/sta2x11-mfd.c
> index 9292202039ee..3aeafa228baf 100644
> --- a/drivers/mfd/sta2x11-mfd.c
> +++ b/drivers/mfd/sta2x11-mfd.c
> @@ -60,8 +60,8 @@ static struct sta2x11_mfd *sta2x11_mfd_find(struct pci_dev *pdev)
> struct sta2x11_mfd *mfd;
>
> if (!pdev && !list_empty(&sta2x11_mfd_list)) {
> - pr_warning("%s: Unspecified device, "
> - "using first instance\n", __func__);
> + pr_warn("%s: Unspecified device, using first instance\n",
> + __func__);
> return list_entry(sta2x11_mfd_list.next,
> struct sta2x11_mfd, list);
> }
> diff --git a/drivers/mfd/twl4030-power.c b/drivers/mfd/twl4030-power.c
> index 1beb722f6080..8be023ba8e3e 100644
> --- a/drivers/mfd/twl4030-power.c
> +++ b/drivers/mfd/twl4030-power.c
> @@ -502,9 +502,7 @@ static int load_twl4030_script(const struct twl4030_power_data *pdata,
> }
> if (tscript->flags & TWL4030_SLEEP_SCRIPT) {
> if (!order)
> - pr_warning("TWL4030: Bad order of scripts (sleep "\
> - "script before wakeup) Leads to boot"\
> - "failure on some boards\n");
> + pr_warn("TWL4030: Bad order of scripts (sleep script before wakeup) Leads to boot failure on some boards\n");
Is 80 chars considered the lessor sin?
> err = twl4030_config_sleep_sequence(address);
> }
> out:
> @@ -929,8 +927,7 @@ static int twl4030_power_probe(struct platform_device *pdev)
> err = twl_i2c_read_u8(TWL_MODULE_PM_MASTER, &val,
> TWL4030_PM_MASTER_CFG_P123_TRANSITION);
> if (err) {
> - pr_warning("TWL4030 Unable to read registers\n");
> -
> + pr_warn("TWL4030 Unable to read registers\n");
> } else if (!(val & SEQ_OFFSYNC)) {
> val |= SEQ_OFFSYNC;
> err = twl_i2c_write_u8(TWL_MODULE_PM_MASTER, val,
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2017-03-14 14:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-17 7:11 [PATCH 00/35] treewide trivial patches converting pr_warning to pr_warn Joe Perches
2017-02-17 7:11 ` [PATCH 02/35] ARM: ep93xx: Convert remaining uses of " Joe Perches
2017-02-17 16:26 ` Hartley Sweeten
2017-02-17 7:11 ` [PATCH 03/35] arm64: " Joe Perches
2017-02-17 10:52 ` Mark Rutland
2017-02-17 7:11 ` [PATCH 23/35] drivers/mfd: " Joe Perches
2017-03-14 14:04 ` Lee Jones [this message]
2017-03-14 17:17 ` Joe Perches
2017-03-15 12:23 ` Lee Jones
2017-03-15 14:17 ` Joe Perches
2017-03-23 10:52 ` Lee Jones
2017-02-17 12:27 ` [PATCH 00/35] treewide trivial patches converting " Rafael J. Wysocki
2017-02-17 12:37 ` Geert Uytterhoeven
2017-02-23 15:28 ` Rob Herring
2017-02-23 17:18 ` Joe Perches
2017-02-23 17:41 ` Emil Velikov
2017-02-23 17:53 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170314140455.umlhdbuj3grqtu6i@dell \
--to=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox