From: vigneshr@ti.com (Vignesh R)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] serial: 8250: 8250_core: Fix irq name for 8250 serial irq
Date: Thu, 16 Mar 2017 17:56:53 +0530 [thread overview]
Message-ID: <20170316122653.19930-1-vigneshr@ti.com> (raw)
Using dev_name() as irq name during request_irq() might be misleading in
case of serial over PCI. Therefore use a better alternative name for
identifying serial port irqs as "serial" appended with serial_index of
the port. This ensures that "serial" string is always present in irq
name while port index will help in distinguishing b/w different ports.
Signed-off-by: Vignesh R <vigneshr@ti.com>
---
Based on top of tty-next.
drivers/tty/serial/8250/8250_core.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial/8250/8250_core.c
index f83b69f30987..78bf621d6827 100644
--- a/drivers/tty/serial/8250/8250_core.c
+++ b/drivers/tty/serial/8250/8250_core.c
@@ -213,12 +213,20 @@ static int serial_link_irq_chain(struct uart_8250_port *up)
ret = 0;
} else {
+ char *irqname = kmalloc(20, GFP_KERNEL);
+ if (!irqname) {
+ spin_unlock_irq(&i->lock);
+ return -ENOMEM;
+ }
+ snprintf(irqname, 20,
+ "serial%d", serial_index(&up->port));
+
INIT_LIST_HEAD(&up->list);
i->head = &up->list;
spin_unlock_irq(&i->lock);
irq_flags |= up->port.irqflags;
ret = request_irq(up->port.irq, serial8250_interrupt,
- irq_flags, dev_name(up->port.dev), i);
+ irq_flags, irqname, i);
if (ret < 0)
serial_do_unlink(i, up);
}
--
2.11.0
next reply other threads:[~2017-03-16 12:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-16 12:26 Vignesh R [this message]
2017-03-16 12:46 ` [PATCH] serial: 8250: 8250_core: Fix irq name for 8250 serial irq Jiri Slaby
2017-03-16 12:54 ` Jiri Slaby
2017-03-16 13:36 ` Russell King - ARM Linux
2017-03-16 14:55 ` Robin Murphy
2017-03-16 20:58 ` Andy Shevchenko
2017-03-20 12:24 ` Vignesh R
2017-03-20 12:32 ` Russell King - ARM Linux
2017-03-16 21:46 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170316122653.19930-1-vigneshr@ti.com \
--to=vigneshr@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox