From: robert.richter@cavium.com (Robert Richter)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 8/8] irqchip, gicv3-its, cma: Use CMA for allocation of large device tables
Date: Thu, 16 Mar 2017 14:31:54 +0100 [thread overview]
Message-ID: <20170316133154.GA16822@rric.localdomain> (raw)
In-Reply-To: <9b492795-3759-801e-c77d-e74e86c814d1@arm.com>
On 15.03.17 18:46:22, Marc Zyngier wrote:
> On 15/03/17 18:37, Robert Richter wrote:
> > On 14.03.17 12:40:45, Shanker Donthineni wrote:
> >>> @@ -1698,6 +1706,9 @@ static int __init its_init_one(struct its_node *its)
> >>> return err;
> >>> }
> >>>
> >>> + /* Setup dma_ops for dmam_alloc_coherent() */
> >>> + arch_setup_dma_ops(&its->dev, 0, 0, NULL, true);
> >>> +
> >
> >> Why you are hard-coding DMA coherent property to true here ? It
> >> breaks the MSI(x) functionally on systems where ITS hardware doesn't
> >> support coherency.
> >
> > Aren't current ITS tables coherent only?
>
> No, there is no such guarantee. Actually, there is strictly no need for
> coherency, as the ITS tables are only written by the ITS itself, for its
> own purpose.
So no need to change that, right?
Thanks,
-Robert
next prev parent reply other threads:[~2017-03-16 13:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-06 12:57 [PATCH v2 0/8] irqchip/gic-v3-its: Implement ITS nodes as kernel devices and use CMA Robert Richter
2017-03-06 12:57 ` [PATCH v2 1/8] irqchip/gic-v3-its: Initialize its nodes in probe order Robert Richter
2017-03-06 12:57 ` [PATCH v2 2/8] irqchip/gic-v3-its: Initialize MSIs with subsys_initcalls Robert Richter
2017-03-06 12:57 ` [PATCH v2 3/8] irqchip/gic-v3-its: Split probing from its node initialization Robert Richter
2017-03-06 12:57 ` [PATCH v2 4/8] irqchip/gic-v3-its: Decouple its initialization from gic Robert Richter
2017-03-06 12:57 ` [PATCH v2 5/8] irqchip/gic-v3-its: Prevent its init ordering dependencies Robert Richter
2017-03-06 12:57 ` [PATCH v2 6/8] irqchip/gic-v3-its: Initialize its nodes later Robert Richter
2017-03-06 12:57 ` [PATCH v2 7/8] irqchip/gic-v3-its: Handle its nodes as kernel devices Robert Richter
2017-03-06 12:57 ` [PATCH v2 8/8] irqchip, gicv3-its, cma: Use CMA for allocation of large device tables Robert Richter
2017-03-14 17:40 ` Shanker Donthineni
2017-03-15 18:37 ` Robert Richter
2017-03-15 18:46 ` Marc Zyngier
2017-03-16 13:31 ` Robert Richter [this message]
2017-03-16 13:41 ` Marc Zyngier
2017-03-16 14:03 ` Shanker Donthineni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170316133154.GA16822@rric.localdomain \
--to=robert.richter@cavium.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox