From: gregkh@linuxfoundation.org (Greg Kroah-Hartman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] Revert "tty: serial: pl011: add ttyAMA for matching pl011 console"
Date: Fri, 17 Mar 2017 14:04:21 +0900 [thread overview]
Message-ID: <20170317050421.GA9400@kroah.com> (raw)
In-Reply-To: <008d062d-1095-5a65-3a69-33bee1f648d7@gmail.com>
On Thu, Mar 16, 2017 at 12:31:53PM +0300, Aleksey Makarov wrote:
>
>
> On 03/16/2017 10:11 AM, Jayachandran C. wrote:
> > Hi Greg,
> >
> > On Tue, Mar 14, 2017 at 9:44 PM, Sudeep Holla <sudeep.holla@arm.com> wrote:
> >>
> >>
> >> On 01/03/17 15:23, Aleksey Makarov wrote:
> >>> The original patch makes the condition always true, so it is wrong.
> >>>
> >>> It masks (but not fixes) the bug described in the commit message
> >>> but introduces a regression (no console is selected by SPCR)
> >>> in regular (no 'console=ttyAMA') case.
> >>>
> >>> s/||/&&/ would not fix the problem as the root cause was identified
> >>> incorrectly.
> >>>
> >>> This reverts commit aea9a80ba98a0c9b4de88850260e9fbdcc98360b.
> >>>
> >>
> >> Sorry for that, I will test your patches and respond to that. For this
> >> patch:
> >>
> >> Acked-by: Sudeep Holla <sudeep.holla@arm.com>
> >>
> >
> > This fixes a regression I see in v4.11-rc2
> >
> > Tested-by: Jayachandran C <jnair@caviumnetworks.com>
> >
> > I don't see it in the tty/serial tree yet
>
> It's commit 713b93f1b849 from tty-next branch of
> https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git
>
> So it looks like it is scheduled for 4.12
>
> Greg, this is a fix for regression. Can it be applied to 4.11-rcX?
Yes, will do that now, thanks.
greg k-h
prev parent reply other threads:[~2017-03-17 5:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-01 12:26 [PATCH] Revert "tty: serial: pl011: add ttyAMA for matching pl011 console" Aleksey Makarov
2017-03-01 12:50 ` [PATCH v2] " Aleksey Makarov
2017-03-01 12:59 ` [PATCH] " Robin Murphy
2017-03-01 13:01 ` Aleksey Makarov
2017-03-01 13:55 ` Robin Murphy
2017-03-01 15:23 ` [PATCH v3] " Aleksey Makarov
2017-03-14 16:14 ` Sudeep Holla
2017-03-16 7:11 ` Jayachandran C.
2017-03-16 9:31 ` Aleksey Makarov
2017-03-17 5:04 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170317050421.GA9400@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).