From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v21 03/13] clocksource: arm_arch_timer: remove arch_timer_detect_rate
Date: Fri, 17 Mar 2017 18:07:26 +0000 [thread overview]
Message-ID: <20170317180725.GC15909@leverpostej> (raw)
In-Reply-To: <20170206185015.12296-4-fu.wei@linaro.org>
On Tue, Feb 07, 2017 at 02:50:05AM +0800, fu.wei at linaro.org wrote:
> From: Fu Wei <fu.wei@linaro.org>
>
> The original counter frequency detection call(arch_timer_detect_rate)
> include getting the frequency from the per-cpu arch-timer and the
> memory-mapped (MMIO) timer interfaces. But they will be needed only when
> the system initializes the relevant timer.
>
> This patch remove arch_timer_detect_rate founction, and use the
> arch_timer_get_sysreg_freq and arch_timer_get_mmio_freq directly.
>
> Signed-off-by: Fu Wei <fu.wei@linaro.org>
Could you please fold this with the prior patch?
> @@ -1087,7 +1072,12 @@ static int __init arch_timer_mem_init(struct device_node *np)
> */
> if (!arch_timer_rate &&
> of_property_read_u32(np, "clock-frequency", &arch_timer_rate))
> - arch_timer_detect_rate(base);
> + arch_timer_rate = arch_timer_get_mmio_freq(base);
> + if (!arch_timer_rate) {
> + pr_err(FW_BUG "frequency not available for MMIO timer.\n");
It would be better to say "MMIO frequency not available.\n" here.
Thanks,
Mark.
next prev parent reply other threads:[~2017-03-17 18:07 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-06 18:50 [PATCH v21 00/13] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer fu.wei at linaro.org
2017-02-06 18:50 ` [PATCH v21 01/13] clocksource: arm_arch_timer: introduce two functions to get the frequency from mmio and sysreg fu.wei at linaro.org
2017-03-17 18:05 ` Mark Rutland
2017-03-20 7:36 ` Fu Wei
2017-03-20 9:43 ` Fu Wei
2017-03-20 10:41 ` Mark Rutland
2017-03-20 11:09 ` Fu Wei
2017-02-06 18:50 ` [PATCH v21 02/13] clocksource: arm_arch_timer: separate out device-tree code from arch_timer_detect_rate fu.wei at linaro.org
2017-02-06 18:50 ` [PATCH v21 03/13] clocksource: arm_arch_timer: remove arch_timer_detect_rate fu.wei at linaro.org
2017-03-17 18:07 ` Mark Rutland [this message]
2017-03-20 6:59 ` Fu Wei
2017-02-06 18:50 ` [PATCH v21 04/13] clocksource: arm_arch_timer: split arch_timer_rate for different types of timer fu.wei at linaro.org
2017-03-17 19:05 ` Mark Rutland
2017-03-20 13:35 ` Fu Wei
2017-02-06 18:50 ` [PATCH v21 05/13] clocksource: arm_arch_timer: refactor arch_timer_needs_probing fu.wei at linaro.org
2017-02-06 18:50 ` [PATCH v21 06/13] clocksource: arm_arch_timer: move arch_timer_needs_of_probing into DT init call fu.wei at linaro.org
2017-02-06 18:50 ` [PATCH v21 07/13] clocksource: arm_arch_timer: introduce some new structs to prepare for GTDT fu.wei at linaro.org
2017-02-06 18:50 ` [PATCH v21 08/13] clocksource: arm_arch_timer: refactor MMIO timer probing fu.wei at linaro.org
2017-02-06 18:50 ` [PATCH v21 09/13] acpi/arm64: Add GTDT table parse driver fu.wei at linaro.org
2017-02-06 18:50 ` [PATCH v21 10/13] clocksource: arm_arch_timer: simplify ACPI support code fu.wei at linaro.org
2017-02-06 18:50 ` [PATCH v21 11/13] acpi/arm64: Add memory-mapped timer support in GTDT driver fu.wei at linaro.org
2017-03-17 19:40 ` Mark Rutland
2017-03-20 13:38 ` Fu Wei
2017-02-06 18:50 ` [PATCH v21 12/13] clocksource: arm_arch_timer: add GTDT support for memory-mapped timer fu.wei at linaro.org
2017-02-06 18:50 ` [PATCH v21 13/13] acpi/arm64: Add SBSA Generic Watchdog support in GTDT driver fu.wei at linaro.org
2017-03-17 20:01 ` Mark Rutland
2017-03-20 17:57 ` Fu Wei
2017-03-20 18:09 ` Mark Rutland
2017-03-20 18:50 ` [Linaro-acpi] " Lurndal, Scott
2017-03-21 3:48 ` Fu Wei
2017-03-21 12:48 ` Lurndal, Scott
2017-03-21 5:12 ` Fu Wei
2017-02-20 16:20 ` [PATCH v21 00/13] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer Fu Wei
2017-03-09 22:47 ` Fu Wei
2017-03-17 20:03 ` Mark Rutland
2017-03-20 5:09 ` Fu Wei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170317180725.GC15909@leverpostej \
--to=mark.rutland@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox