From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/8] soc: imx: gpc: fix gpc clk get error handling
Date: Mon, 20 Mar 2017 16:05:24 +0800 [thread overview]
Message-ID: <20170320080523.GG3443@dragon> (raw)
In-Reply-To: <1489990547-1510-2-git-send-email-aisheng.dong@nxp.com>
On Mon, Mar 20, 2017 at 02:15:40PM +0800, Dong Aisheng wrote:
> diff --git a/drivers/soc/imx/gpc.c b/drivers/soc/imx/gpc.c
> index 1e9b3b8..c9bfdfd 100644
> --- a/drivers/soc/imx/gpc.c
> +++ b/drivers/soc/imx/gpc.c
> @@ -143,7 +143,7 @@ static int imx_pgc_get_clocks(struct device *dev, struct imx_pm_domain *domain)
> return 0;
>
> clk_err:
> - for (; i >= 0; i--)
> + while (i--)
> clk_put(domain->clk[i]);
Will clk[0] be put then?
Shawn
>
> return ret;
next prev parent reply other threads:[~2017-03-20 8:05 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-20 6:15 [PATCH 0/8] soc: imx: gpc: fixes and clean up Dong Aisheng
2017-03-20 6:15 ` [PATCH 1/8] soc: imx: gpc: fix gpc clk get error handling Dong Aisheng
2017-03-20 8:05 ` Shawn Guo [this message]
2017-03-22 18:33 ` Dong Aisheng
2017-03-22 6:38 ` Shawn Guo
2017-03-20 6:15 ` [PATCH 2/8] soc: imx: gpc: fix the wrong using of regmap cache Dong Aisheng
2017-03-20 9:38 ` Lucas Stach
2017-03-22 18:53 ` Dong Aisheng
2017-03-22 8:43 ` Lucas Stach
2017-03-20 6:15 ` [PATCH 3/8] soc: imx: gpc: fix domain_index sanity check issue Dong Aisheng
2017-03-20 9:40 ` Lucas Stach
2017-03-20 6:15 ` [PATCH 4/8] soc: imx: gpc: fix imx6sl gpc power domain regression Dong Aisheng
2017-03-20 9:26 ` Lucas Stach
2017-03-22 19:23 ` Dong Aisheng
2017-03-22 8:46 ` Lucas Stach
2017-03-23 0:47 ` Dong Aisheng
2017-03-20 6:15 ` [PATCH 5/8] soc: imx: gpc: fix comment when power up domain Dong Aisheng
2017-03-20 9:41 ` Lucas Stach
2017-03-20 6:15 ` [PATCH 6/8] soc: imx: gpc: keep PGC_X_CTRL name align with reference manual Dong Aisheng
2017-03-20 9:42 ` Lucas Stach
2017-03-20 6:15 ` [PATCH 7/8] dt-bindings: imx-gpc: correct the DOMAIN_INDEX using Dong Aisheng
2017-03-20 9:43 ` Lucas Stach
2017-03-20 6:15 ` [PATCH 8/8] soc: imx: gpc: remove unnecessary readable_reg callback Dong Aisheng
2017-03-20 9:43 ` Lucas Stach
2017-03-22 19:25 ` Dong Aisheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170320080523.GG3443@dragon \
--to=shawnguo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).