From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 6/7] arm64: hugetlb: Spring clean huge pte accessors
Date: Wed, 22 Mar 2017 14:24:39 +0000 [thread overview]
Message-ID: <20170322142439.GG2977@leverpostej> (raw)
In-Reply-To: <20170321180421.18332-7-punit.agrawal@arm.com>
On Tue, Mar 21, 2017 at 06:04:20PM +0000, Punit Agrawal wrote:
> + /*
> + * If HW_AFDBM is enabled, then the HW could
> + * turn on the dirty bit for any of the page
> + * in the set, so check them all.
> + */
Nit: we've carried over a grammar bug from the existing comment, which
would be nive to fix up. Can we either s/page/pages/ or s/of the // ?
Either way, the logic looks good.
Reviewed-by: Mark Rutland <mark.rutland@arm.com>
Mark.
next prev parent reply other threads:[~2017-03-22 14:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-21 18:04 [PATCH 0/7] arm64: hugetlb cleanup + break-before-make fixes Punit Agrawal
2017-03-21 18:04 ` [PATCH 1/7] arm64: hugetlb: set_huge_pte_at Add WARN_ON on !pte_present Punit Agrawal
2017-03-21 18:04 ` [PATCH 2/7] arm64: hugetlb: Cleanup setup_hugepagesz Punit Agrawal
2017-03-22 14:01 ` Mark Rutland
2017-03-21 18:04 ` [PATCH 3/7] arm64: hugetlb: Refactor find_num_contig Punit Agrawal
2017-03-22 14:14 ` Mark Rutland
2017-03-21 18:04 ` [PATCH 4/7] arm64: hugetlb: Introduce pte_pgprot helper Punit Agrawal
2017-03-22 14:16 ` Mark Rutland
2017-03-21 18:04 ` [PATCH 5/7] arm64: hugetlb: Remove spurious calls to huge_ptep_offset Punit Agrawal
2017-03-22 14:18 ` Mark Rutland
2017-03-21 18:04 ` [PATCH 6/7] arm64: hugetlb: Spring clean huge pte accessors Punit Agrawal
2017-03-22 14:24 ` Mark Rutland [this message]
2017-03-21 18:04 ` [PATCH 7/7] arm64: hugetlb: Add break-before-make logic for contiguous entries Punit Agrawal
2017-03-22 14:38 ` Mark Rutland
2017-03-22 18:14 ` Punit Agrawal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170322142439.GG2977@leverpostej \
--to=mark.rutland@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).