linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: briannorris@chromium.org (Brian Norris)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 4/4] arm64: dts: rockchip: add regulator info for Kevin digitizer
Date: Wed, 22 Mar 2017 11:14:42 -0700	[thread overview]
Message-ID: <20170322181441.GC98450@google.com> (raw)
In-Reply-To: <20415662.PctC9IM4SC@phil>

On Wed, Mar 22, 2017 at 09:26:41AM +0100, Heiko Stuebner wrote:
> Am Montag, 20. M?rz 2017, 16:53:44 CET schrieb Brian Norris:
> > We need to enable this regulator before the digitizer can be used. Wacom
> > recommended waiting for 100 ms before talking to the HID.
> > 
> > Signed-off-by: Brian Norris <briannorris@chromium.org>
> > ---
> > v3:
> >  * reintroduced into patch set; bindings are in linux-next
> > ---
> >  arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts
> > b/arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts index
> > 2f720cf2fd07..f4714c4606f3 100644
> > --- a/arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts
> > +++ b/arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts
> > @@ -232,6 +232,9 @@ ap_i2c_dig: &i2c2 {
> 
> according to the hid-over-i2c binding, this should use a special compatible 
> like
> 
> 	compatible = "wacom,w9013", "hid-over-i2c"
> 
> As the binding patch is from Caesar, I assume that is the Kevin component and
> I can add that myself, just need confirmation that this is actually the correct 
> component :-) .

*Sigh.* The I2C (and SPI) framework is still broken w.r.t. multiple
compatible strings and drivers built as modules [1]. So I'd really
rather not do this...

...but yes, that's a fair component description.

Brian

[1] Some discussion about SPI:
    https://patchwork.kernel.org/patch/7630571/
    And the discussion about I2C (25% through that thread):
    https://patchwork.kernel.org/patch/9455245/

  reply	other threads:[~2017-03-22 18:14 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-20 23:53 [PATCH v3 0/4] arm64: dts: rockchip: support Google Kevin Brian Norris
2017-03-20 23:53 ` [PATCH v3 1/4] dt-bindings: Document rk3399 Gru/Kevin Brian Norris
2017-03-22  9:01   ` Heiko Stuebner
2017-03-22 17:56     ` Brian Norris
2017-03-20 23:53 ` [PATCH v3 2/4] arm64: dts: rockchip: add Gru/Kevin DTS Brian Norris
2017-03-21 11:02   ` Enric Balletbo Serra
2017-03-22 11:59   ` Heiko Stuebner
2017-03-22 17:57     ` Brian Norris
2017-03-20 23:53 ` [PATCH v3 3/4] arm64: dts: rockchip: describe Gru/Kevin OPPs + CPU regulators Brian Norris
2017-03-21 11:04   ` Enric Balletbo Serra
2017-03-22 12:00   ` Heiko Stuebner
2017-03-20 23:53 ` [PATCH v3 4/4] arm64: dts: rockchip: add regulator info for Kevin digitizer Brian Norris
2017-03-22  8:26   ` Heiko Stuebner
2017-03-22 18:14     ` Brian Norris [this message]
2017-03-22 23:57       ` Heiko Stuebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170322181441.GC98450@google.com \
    --to=briannorris@chromium.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).