From: dongas86@gmail.com (Dong Aisheng)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 8/8] soc: imx: gpc: remove unnecessary readable_reg callback
Date: Thu, 23 Mar 2017 03:25:15 +0800 [thread overview]
Message-ID: <20170322192515.GD16264@b29396-OptiPlex-7040> (raw)
In-Reply-To: <1490003027.2895.19.camel@pengutronix.de>
On Mon, Mar 20, 2017 at 10:43:47AM +0100, Lucas Stach wrote:
> Am Montag, den 20.03.2017, 14:15 +0800 schrieb Dong Aisheng:
> > It is not really necessary to provide the current .readable_reg
> > implementation as we know what we're doing in our driver
> > and the regmap core has already done the partial check for
> > available maximum regs.
> >
> > Cc: Lucas Stach <l.stach@pengutronix.de>
> > Cc: Shawn Guo <shawnguo@kernel.org>
> > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
>
> Acked-by: Lucas Stach <l.stach@pengutronix.de>
>
Thanks for the review and Acks.
Regards
Dong Aisheng
> > ---
> > drivers/soc/imx/gpc.c | 8 --------
> > 1 file changed, 8 deletions(-)
> >
> > diff --git a/drivers/soc/imx/gpc.c b/drivers/soc/imx/gpc.c
> > index a744f7e..4885ec2 100644
> > --- a/drivers/soc/imx/gpc.c
> > +++ b/drivers/soc/imx/gpc.c
> > @@ -284,18 +284,10 @@ static const struct of_device_id imx_gpc_dt_ids[] = {
> > { }
> > };
> >
> > -static bool imx_gpc_readable_reg(struct device *dev, unsigned int reg)
> > -{
> > - return (reg % 4 == 0) && (reg <= 0x2ac);
> > -}
> > -
> > static const struct regmap_config imx_gpc_regmap_config = {
> > .reg_bits = 32,
> > .val_bits = 32,
> > .reg_stride = 4,
> > -
> > - .readable_reg = imx_gpc_readable_reg,
> > -
> > .max_register = 0x2ac,
> > };
> >
>
>
prev parent reply other threads:[~2017-03-22 19:25 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-20 6:15 [PATCH 0/8] soc: imx: gpc: fixes and clean up Dong Aisheng
2017-03-20 6:15 ` [PATCH 1/8] soc: imx: gpc: fix gpc clk get error handling Dong Aisheng
2017-03-20 8:05 ` Shawn Guo
2017-03-22 18:33 ` Dong Aisheng
2017-03-22 6:38 ` Shawn Guo
2017-03-20 6:15 ` [PATCH 2/8] soc: imx: gpc: fix the wrong using of regmap cache Dong Aisheng
2017-03-20 9:38 ` Lucas Stach
2017-03-22 18:53 ` Dong Aisheng
2017-03-22 8:43 ` Lucas Stach
2017-03-20 6:15 ` [PATCH 3/8] soc: imx: gpc: fix domain_index sanity check issue Dong Aisheng
2017-03-20 9:40 ` Lucas Stach
2017-03-20 6:15 ` [PATCH 4/8] soc: imx: gpc: fix imx6sl gpc power domain regression Dong Aisheng
2017-03-20 9:26 ` Lucas Stach
2017-03-22 19:23 ` Dong Aisheng
2017-03-22 8:46 ` Lucas Stach
2017-03-23 0:47 ` Dong Aisheng
2017-03-20 6:15 ` [PATCH 5/8] soc: imx: gpc: fix comment when power up domain Dong Aisheng
2017-03-20 9:41 ` Lucas Stach
2017-03-20 6:15 ` [PATCH 6/8] soc: imx: gpc: keep PGC_X_CTRL name align with reference manual Dong Aisheng
2017-03-20 9:42 ` Lucas Stach
2017-03-20 6:15 ` [PATCH 7/8] dt-bindings: imx-gpc: correct the DOMAIN_INDEX using Dong Aisheng
2017-03-20 9:43 ` Lucas Stach
2017-03-20 6:15 ` [PATCH 8/8] soc: imx: gpc: remove unnecessary readable_reg callback Dong Aisheng
2017-03-20 9:43 ` Lucas Stach
2017-03-22 19:25 ` Dong Aisheng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170322192515.GD16264@b29396-OptiPlex-7040 \
--to=dongas86@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).