From mboxrd@z Thu Jan  1 00:00:00 1970
From: dongas86@gmail.com (Dong Aisheng)
Date: Thu, 23 Mar 2017 03:25:15 +0800
Subject: [PATCH 8/8] soc: imx: gpc: remove unnecessary readable_reg
 callback
In-Reply-To: <1490003027.2895.19.camel@pengutronix.de>
References: <1489990547-1510-1-git-send-email-aisheng.dong@nxp.com>
 <1489990547-1510-9-git-send-email-aisheng.dong@nxp.com>
 <1490003027.2895.19.camel@pengutronix.de>
Message-ID: <20170322192515.GD16264@b29396-OptiPlex-7040>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

On Mon, Mar 20, 2017 at 10:43:47AM +0100, Lucas Stach wrote:
> Am Montag, den 20.03.2017, 14:15 +0800 schrieb Dong Aisheng:
> > It is not really necessary to provide the current .readable_reg
> > implementation as we know what we're doing in our driver
> > and the regmap core has already done the partial check for
> > available maximum regs.
> > 
> > Cc: Lucas Stach <l.stach@pengutronix.de>
> > Cc: Shawn Guo <shawnguo@kernel.org>
> > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> 
> Acked-by: Lucas Stach <l.stach@pengutronix.de>
> 

Thanks for the review and Acks.

Regards
Dong Aisheng

> > ---
> >  drivers/soc/imx/gpc.c | 8 --------
> >  1 file changed, 8 deletions(-)
> > 
> > diff --git a/drivers/soc/imx/gpc.c b/drivers/soc/imx/gpc.c
> > index a744f7e..4885ec2 100644
> > --- a/drivers/soc/imx/gpc.c
> > +++ b/drivers/soc/imx/gpc.c
> > @@ -284,18 +284,10 @@ static const struct of_device_id imx_gpc_dt_ids[] = {
> >  	{ }
> >  };
> >  
> > -static bool imx_gpc_readable_reg(struct device *dev, unsigned int reg)
> > -{
> > -	return (reg % 4 == 0) && (reg <= 0x2ac);
> > -}
> > -
> >  static const struct regmap_config imx_gpc_regmap_config = {
> >  	.reg_bits = 32,
> >  	.val_bits = 32,
> >  	.reg_stride = 4,
> > -
> > -	.readable_reg = imx_gpc_readable_reg,
> > -
> >  	.max_register = 0x2ac,
> >  };
> >  
> 
>