From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: cpufeature: Make ID reg accessor naming less counterintuitive
Date: Thu, 23 Mar 2017 15:37:51 +0000 [thread overview]
Message-ID: <20170323153750.GJ9287@leverpostej> (raw)
In-Reply-To: <1490282079-2724-1-git-send-email-Dave.Martin@arm.com>
On Thu, Mar 23, 2017 at 03:14:39PM +0000, Dave Martin wrote:
> read_system_reg() can readily be confused with read_sysreg(),
> whereas these are really quite different in their meaning.
>
> This patches attempts to reduce the ambiguity be reserving "sysreg"
> for the actual system register accessors.
>
> read_system_reg() is instead renamed to read_sanitised_ftr_reg(),
> to make it more obvious that the Linux-defined sanitised feature
> register cache is being accessed here, not the underlying
> architectural system registers.
>
> cpufeature.c's internal __raw_read_system_reg() function is renamed
> in line with its actual purpose: a form of read_sysreg() that
> indexes on (non-compiletime-constant) encoding rather than symbolic
> register name.
>
> Signed-off-by: Dave Martin <Dave.Martin@arm.com>
As discussed in the other thread [1], the read_sanitised_ftr_reg() makes
sense to me. I'm also happy with the __read_sysreg_by_encoding() change.
FWIW:
Acked-by: Mark Rutland <mark.rutland@arm.com>
Mark.
[1] http://lists.infradead.org/pipermail/linux-arm-kernel/2017-March/496305.html
next prev parent reply other threads:[~2017-03-23 15:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-23 15:14 [PATCH] arm64: cpufeature: Make ID reg accessor naming less counterintuitive Dave Martin
2017-03-23 15:37 ` Mark Rutland [this message]
2017-03-24 17:36 ` Suzuki K Poulose
2017-04-04 15:56 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170323153750.GJ9287@leverpostej \
--to=mark.rutland@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox