* [PATCH v2 2/4] mvebu: xp: Add pwm properties to .dtsi files
[not found] <20170318154305.28348-1-ralph.sennhauser@gmail.com>
@ 2017-03-18 15:43 ` Ralph Sennhauser
2017-03-23 16:40 ` Gregory CLEMENT
2017-03-18 15:43 ` [PATCH v2 3/4] ARM: mvebu: Enable SENSORS_PWM_FAN in defconfig Ralph Sennhauser
2017-03-18 15:43 ` [PATCH v2 4/4] mvebu: wrt1900ac: Use pwm-fan rather than gpio-fan Ralph Sennhauser
2 siblings, 1 reply; 7+ messages in thread
From: Ralph Sennhauser @ 2017-03-18 15:43 UTC (permalink / raw)
To: linux-arm-kernel
From: Andrew Lunn <andrew@lunn.ch>
Add properties to the gpio nodes to allow them to be also used as pwm
lines.
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
URL: https://patchwork.ozlabs.org/patch/427294/
Signed-off-by: Ralph Sennhauser <ralph.sennhauser@gmail.com>
---
arch/arm/boot/dts/armada-370.dtsi | 10 ++++++++--
arch/arm/boot/dts/armada-xp-mv78230.dtsi | 10 ++++++++--
arch/arm/boot/dts/armada-xp-mv78260.dtsi | 8 ++++++--
arch/arm/boot/dts/armada-xp-mv78460.dtsi | 10 ++++++++--
4 files changed, 30 insertions(+), 8 deletions(-)
diff --git a/arch/arm/boot/dts/armada-370.dtsi b/arch/arm/boot/dts/armada-370.dtsi
index cc011c8..aa9fe72 100644
--- a/arch/arm/boot/dts/armada-370.dtsi
+++ b/arch/arm/boot/dts/armada-370.dtsi
@@ -138,24 +138,30 @@
gpio0: gpio at 18100 {
compatible = "marvell,orion-gpio";
- reg = <0x18100 0x40>;
+ reg = <0x18100 0x40>, <0x181c0 0x08>;
+ reg-names = "gpio", "pwm";
ngpios = <32>;
gpio-controller;
#gpio-cells = <2>;
+ #pwm-cells = <2>;
interrupt-controller;
#interrupt-cells = <2>;
interrupts = <82>, <83>, <84>, <85>;
+ clocks = <&coreclk 0>;
};
gpio1: gpio at 18140 {
compatible = "marvell,orion-gpio";
- reg = <0x18140 0x40>;
+ reg = <0x18140 0x40>, <0x181c8 0x08>;
+ reg-names = "gpio", "pwm";
ngpios = <32>;
gpio-controller;
#gpio-cells = <2>;
+ #pwm-cells = <2>;
interrupt-controller;
#interrupt-cells = <2>;
interrupts = <87>, <88>, <89>, <90>;
+ clocks = <&coreclk 0>;
};
gpio2: gpio at 18180 {
diff --git a/arch/arm/boot/dts/armada-xp-mv78230.dtsi b/arch/arm/boot/dts/armada-xp-mv78230.dtsi
index 07c5090..fc3934f 100644
--- a/arch/arm/boot/dts/armada-xp-mv78230.dtsi
+++ b/arch/arm/boot/dts/armada-xp-mv78230.dtsi
@@ -203,24 +203,30 @@
internal-regs {
gpio0: gpio at 18100 {
compatible = "marvell,orion-gpio";
- reg = <0x18100 0x40>;
+ reg = <0x18100 0x40>, <0x181c0 0x08>;
+ reg-names = "gpio", "pwm";
ngpios = <32>;
gpio-controller;
#gpio-cells = <2>;
+ #pwm-cells = <2>;
interrupt-controller;
#interrupt-cells = <2>;
interrupts = <82>, <83>, <84>, <85>;
+ clocks = <&coreclk 0>;
};
gpio1: gpio at 18140 {
compatible = "marvell,orion-gpio";
- reg = <0x18140 0x40>;
+ reg = <0x18140 0x40>, <0x181c8 0x08>;
+ reg-names = "gpio", "pwm";
ngpios = <17>;
gpio-controller;
#gpio-cells = <2>;
+ #pwm-cells = <2>;
interrupt-controller;
#interrupt-cells = <2>;
interrupts = <87>, <88>, <89>;
+ clocks = <&coreclk 0>;
};
};
};
diff --git a/arch/arm/boot/dts/armada-xp-mv78260.dtsi b/arch/arm/boot/dts/armada-xp-mv78260.dtsi
index 64e936a..04dda6a 100644
--- a/arch/arm/boot/dts/armada-xp-mv78260.dtsi
+++ b/arch/arm/boot/dts/armada-xp-mv78260.dtsi
@@ -286,24 +286,28 @@
internal-regs {
gpio0: gpio at 18100 {
compatible = "marvell,orion-gpio";
- reg = <0x18100 0x40>;
+ reg = <0x18100 0x40>, <0x181c0 0x08>;
+ reg-names = "gpio", "pwm";
ngpios = <32>;
gpio-controller;
#gpio-cells = <2>;
+ #pwm-cells = <2>;
interrupt-controller;
#interrupt-cells = <2>;
interrupts = <82>, <83>, <84>, <85>;
+ clocks = <&coreclk 0>;
};
gpio1: gpio at 18140 {
compatible = "marvell,orion-gpio";
- reg = <0x18140 0x40>;
+ reg = <0x18140 0x40>, <0x181c8 0x08>;
ngpios = <32>;
gpio-controller;
#gpio-cells = <2>;
interrupt-controller;
#interrupt-cells = <2>;
interrupts = <87>, <88>, <89>, <90>;
+ clocks = <&coreclk 0>;
};
gpio2: gpio at 18180 {
diff --git a/arch/arm/boot/dts/armada-xp-mv78460.dtsi b/arch/arm/boot/dts/armada-xp-mv78460.dtsi
index d1383dd..fb6d28a 100644
--- a/arch/arm/boot/dts/armada-xp-mv78460.dtsi
+++ b/arch/arm/boot/dts/armada-xp-mv78460.dtsi
@@ -324,24 +324,30 @@
internal-regs {
gpio0: gpio at 18100 {
compatible = "marvell,orion-gpio";
- reg = <0x18100 0x40>;
+ reg = <0x18100 0x40>, <0x181c0 0x08>;
+ reg-names = "gpio", "pwm";
ngpios = <32>;
gpio-controller;
#gpio-cells = <2>;
+ #pwm-cells = <2>;
interrupt-controller;
#interrupt-cells = <2>;
interrupts = <82>, <83>, <84>, <85>;
+ clocks = <&coreclk 0>;
};
gpio1: gpio at 18140 {
compatible = "marvell,orion-gpio";
- reg = <0x18140 0x40>;
+ reg = <0x18140 0x40>, <0x181c8 0x08>;
+ reg-names = "gpio", "pwm";
ngpios = <32>;
gpio-controller;
#gpio-cells = <2>;
+ #pwm-cells = <2>;
interrupt-controller;
#interrupt-cells = <2>;
interrupts = <87>, <88>, <89>, <90>;
+ clocks = <&coreclk 0>;
};
gpio2: gpio at 18180 {
--
2.10.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v2 3/4] ARM: mvebu: Enable SENSORS_PWM_FAN in defconfig
[not found] <20170318154305.28348-1-ralph.sennhauser@gmail.com>
2017-03-18 15:43 ` [PATCH v2 2/4] mvebu: xp: Add pwm properties to .dtsi files Ralph Sennhauser
@ 2017-03-18 15:43 ` Ralph Sennhauser
2017-03-18 15:43 ` [PATCH v2 4/4] mvebu: wrt1900ac: Use pwm-fan rather than gpio-fan Ralph Sennhauser
2 siblings, 0 replies; 7+ messages in thread
From: Ralph Sennhauser @ 2017-03-18 15:43 UTC (permalink / raw)
To: linux-arm-kernel
From: Andrew Lunn <andrew@lunn.ch>
Now that the gpio driver also supports PWM operation, enable the PWM
framework and fan driver in mvebu_v7_defconfig.
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
URL: https://patchwork.ozlabs.org/patch/427297/
[Ralph Sennhauser: add fan driver to defconfig]
Signed-off-by: Ralph Sennhauser <ralph.sennhauser@gmail.com>
---
arch/arm/configs/mvebu_v7_defconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/configs/mvebu_v7_defconfig b/arch/arm/configs/mvebu_v7_defconfig
index f1a0e25..6955370 100644
--- a/arch/arm/configs/mvebu_v7_defconfig
+++ b/arch/arm/configs/mvebu_v7_defconfig
@@ -135,6 +135,8 @@ CONFIG_DMADEVICES=y
CONFIG_MV_XOR=y
# CONFIG_IOMMU_SUPPORT is not set
CONFIG_MEMORY=y
+CONFIG_PWM=y
+CONFIG_SENSORS_PWM_FAN=y
CONFIG_EXT4_FS=y
CONFIG_ISO9660_FS=y
CONFIG_JOLIET=y
--
2.10.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v2 4/4] mvebu: wrt1900ac: Use pwm-fan rather than gpio-fan
[not found] <20170318154305.28348-1-ralph.sennhauser@gmail.com>
2017-03-18 15:43 ` [PATCH v2 2/4] mvebu: xp: Add pwm properties to .dtsi files Ralph Sennhauser
2017-03-18 15:43 ` [PATCH v2 3/4] ARM: mvebu: Enable SENSORS_PWM_FAN in defconfig Ralph Sennhauser
@ 2017-03-18 15:43 ` Ralph Sennhauser
2 siblings, 0 replies; 7+ messages in thread
From: Ralph Sennhauser @ 2017-03-18 15:43 UTC (permalink / raw)
To: linux-arm-kernel
From: Andrew Lunn <andrew@lunn.ch>
The mvebu gpio driver can also perform PWM on some pins. Us the pwm-fan
driver to control the fan of the WRT1900AC, giving us finer grained
control over its speed and hence noise.
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
URL: https://patchwork.ozlabs.org/patch/427291/
Signed-off-by: Ralph Sennhauser <ralph.sennhauser@gmail.com>
---
arch/arm/boot/dts/armada-xp-linksys-mamba.dts | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/arch/arm/boot/dts/armada-xp-linksys-mamba.dts b/arch/arm/boot/dts/armada-xp-linksys-mamba.dts
index 3744ba3..836b275e 100644
--- a/arch/arm/boot/dts/armada-xp-linksys-mamba.dts
+++ b/arch/arm/boot/dts/armada-xp-linksys-mamba.dts
@@ -293,13 +293,11 @@
};
};
- gpio_fan {
+ pwm_fan {
/* SUNON HA4010V4-0000-C99 */
- compatible = "gpio-fan";
- gpios = <&gpio0 24 0>;
- gpio-fan,speed-map = <0 0
- 4500 1>;
+ compatible = "pwm-fan";
+ pwms = <&gpio0 24 4000 0>;
};
dsa {
--
2.10.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v2 2/4] mvebu: xp: Add pwm properties to .dtsi files
2017-03-18 15:43 ` [PATCH v2 2/4] mvebu: xp: Add pwm properties to .dtsi files Ralph Sennhauser
@ 2017-03-23 16:40 ` Gregory CLEMENT
2017-03-23 21:22 ` Andrew Lunn
2017-03-24 8:11 ` Ralph Sennhauser
0 siblings, 2 replies; 7+ messages in thread
From: Gregory CLEMENT @ 2017-03-23 16:40 UTC (permalink / raw)
To: linux-arm-kernel
Hi Ralph,
On sam., mars 18 2017, Ralph Sennhauser <ralph.sennhauser@gmail.com> wrote:
It seems that I don't receive the 1st patch of the series.
Also could you refresh my mind to expose why these patchse were not
apply the first time and why we should apply them now?
Thanks,
Gregory
> From: Andrew Lunn <andrew@lunn.ch>
>
> Add properties to the gpio nodes to allow them to be also used as pwm
> lines.
>
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> URL: https://patchwork.ozlabs.org/patch/427294/
> Signed-off-by: Ralph Sennhauser <ralph.sennhauser@gmail.com>
> ---
> arch/arm/boot/dts/armada-370.dtsi | 10 ++++++++--
> arch/arm/boot/dts/armada-xp-mv78230.dtsi | 10 ++++++++--
> arch/arm/boot/dts/armada-xp-mv78260.dtsi | 8 ++++++--
> arch/arm/boot/dts/armada-xp-mv78460.dtsi | 10 ++++++++--
> 4 files changed, 30 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm/boot/dts/armada-370.dtsi b/arch/arm/boot/dts/armada-370.dtsi
> index cc011c8..aa9fe72 100644
> --- a/arch/arm/boot/dts/armada-370.dtsi
> +++ b/arch/arm/boot/dts/armada-370.dtsi
> @@ -138,24 +138,30 @@
>
> gpio0: gpio at 18100 {
> compatible = "marvell,orion-gpio";
> - reg = <0x18100 0x40>;
> + reg = <0x18100 0x40>, <0x181c0 0x08>;
> + reg-names = "gpio", "pwm";
> ngpios = <32>;
> gpio-controller;
> #gpio-cells = <2>;
> + #pwm-cells = <2>;
> interrupt-controller;
> #interrupt-cells = <2>;
> interrupts = <82>, <83>, <84>, <85>;
> + clocks = <&coreclk 0>;
> };
>
> gpio1: gpio at 18140 {
> compatible = "marvell,orion-gpio";
> - reg = <0x18140 0x40>;
> + reg = <0x18140 0x40>, <0x181c8 0x08>;
> + reg-names = "gpio", "pwm";
> ngpios = <32>;
> gpio-controller;
> #gpio-cells = <2>;
> + #pwm-cells = <2>;
> interrupt-controller;
> #interrupt-cells = <2>;
> interrupts = <87>, <88>, <89>, <90>;
> + clocks = <&coreclk 0>;
> };
>
> gpio2: gpio at 18180 {
> diff --git a/arch/arm/boot/dts/armada-xp-mv78230.dtsi b/arch/arm/boot/dts/armada-xp-mv78230.dtsi
> index 07c5090..fc3934f 100644
> --- a/arch/arm/boot/dts/armada-xp-mv78230.dtsi
> +++ b/arch/arm/boot/dts/armada-xp-mv78230.dtsi
> @@ -203,24 +203,30 @@
> internal-regs {
> gpio0: gpio at 18100 {
> compatible = "marvell,orion-gpio";
> - reg = <0x18100 0x40>;
> + reg = <0x18100 0x40>, <0x181c0 0x08>;
> + reg-names = "gpio", "pwm";
> ngpios = <32>;
> gpio-controller;
> #gpio-cells = <2>;
> + #pwm-cells = <2>;
> interrupt-controller;
> #interrupt-cells = <2>;
> interrupts = <82>, <83>, <84>, <85>;
> + clocks = <&coreclk 0>;
> };
>
> gpio1: gpio at 18140 {
> compatible = "marvell,orion-gpio";
> - reg = <0x18140 0x40>;
> + reg = <0x18140 0x40>, <0x181c8 0x08>;
> + reg-names = "gpio", "pwm";
> ngpios = <17>;
> gpio-controller;
> #gpio-cells = <2>;
> + #pwm-cells = <2>;
> interrupt-controller;
> #interrupt-cells = <2>;
> interrupts = <87>, <88>, <89>;
> + clocks = <&coreclk 0>;
> };
> };
> };
> diff --git a/arch/arm/boot/dts/armada-xp-mv78260.dtsi b/arch/arm/boot/dts/armada-xp-mv78260.dtsi
> index 64e936a..04dda6a 100644
> --- a/arch/arm/boot/dts/armada-xp-mv78260.dtsi
> +++ b/arch/arm/boot/dts/armada-xp-mv78260.dtsi
> @@ -286,24 +286,28 @@
> internal-regs {
> gpio0: gpio at 18100 {
> compatible = "marvell,orion-gpio";
> - reg = <0x18100 0x40>;
> + reg = <0x18100 0x40>, <0x181c0 0x08>;
> + reg-names = "gpio", "pwm";
> ngpios = <32>;
> gpio-controller;
> #gpio-cells = <2>;
> + #pwm-cells = <2>;
> interrupt-controller;
> #interrupt-cells = <2>;
> interrupts = <82>, <83>, <84>, <85>;
> + clocks = <&coreclk 0>;
> };
>
> gpio1: gpio at 18140 {
> compatible = "marvell,orion-gpio";
> - reg = <0x18140 0x40>;
> + reg = <0x18140 0x40>, <0x181c8 0x08>;
> ngpios = <32>;
> gpio-controller;
> #gpio-cells = <2>;
> interrupt-controller;
> #interrupt-cells = <2>;
> interrupts = <87>, <88>, <89>, <90>;
> + clocks = <&coreclk 0>;
> };
>
> gpio2: gpio at 18180 {
> diff --git a/arch/arm/boot/dts/armada-xp-mv78460.dtsi b/arch/arm/boot/dts/armada-xp-mv78460.dtsi
> index d1383dd..fb6d28a 100644
> --- a/arch/arm/boot/dts/armada-xp-mv78460.dtsi
> +++ b/arch/arm/boot/dts/armada-xp-mv78460.dtsi
> @@ -324,24 +324,30 @@
> internal-regs {
> gpio0: gpio at 18100 {
> compatible = "marvell,orion-gpio";
> - reg = <0x18100 0x40>;
> + reg = <0x18100 0x40>, <0x181c0 0x08>;
> + reg-names = "gpio", "pwm";
> ngpios = <32>;
> gpio-controller;
> #gpio-cells = <2>;
> + #pwm-cells = <2>;
> interrupt-controller;
> #interrupt-cells = <2>;
> interrupts = <82>, <83>, <84>, <85>;
> + clocks = <&coreclk 0>;
> };
>
> gpio1: gpio at 18140 {
> compatible = "marvell,orion-gpio";
> - reg = <0x18140 0x40>;
> + reg = <0x18140 0x40>, <0x181c8 0x08>;
> + reg-names = "gpio", "pwm";
> ngpios = <32>;
> gpio-controller;
> #gpio-cells = <2>;
> + #pwm-cells = <2>;
> interrupt-controller;
> #interrupt-cells = <2>;
> interrupts = <87>, <88>, <89>, <90>;
> + clocks = <&coreclk 0>;
> };
>
> gpio2: gpio at 18180 {
> --
> 2.10.2
>
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2 2/4] mvebu: xp: Add pwm properties to .dtsi files
2017-03-23 16:40 ` Gregory CLEMENT
@ 2017-03-23 21:22 ` Andrew Lunn
2017-03-24 8:11 ` Ralph Sennhauser
1 sibling, 0 replies; 7+ messages in thread
From: Andrew Lunn @ 2017-03-23 21:22 UTC (permalink / raw)
To: linux-arm-kernel
> Also could you refresh my mind to expose why these patchse were not
> apply the first time and why we should apply them now?
Hi Gregory
Because i got busy with other things, and never spent the time needed
to address the comments. Ralph has addressed all the comments from the
original posting.
Andrew
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2 2/4] mvebu: xp: Add pwm properties to .dtsi files
2017-03-23 16:40 ` Gregory CLEMENT
2017-03-23 21:22 ` Andrew Lunn
@ 2017-03-24 8:11 ` Ralph Sennhauser
2017-03-24 8:37 ` Gregory CLEMENT
1 sibling, 1 reply; 7+ messages in thread
From: Ralph Sennhauser @ 2017-03-24 8:11 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, 23 Mar 2017 17:40:53 +0100
Gregory CLEMENT <gregory.clement@free-electrons.com> wrote:
> Hi Ralph,
>
> On sam., mars 18 2017, Ralph Sennhauser <ralph.sennhauser@gmail.com>
> wrote:
>
> It seems that I don't receive the 1st patch of the series.
Hi Gregory,
it makes no sense to only send part of a series to a recipient. Will
have to improve my use of --cc-cmd it seems. Will pay attention to this
for v3.
Sorry
Ralph
>
> Also could you refresh my mind to expose why these patchse were not
> apply the first time and why we should apply them now?
>
> Thanks,
>
> Gregory
>
>
> > From: Andrew Lunn <andrew@lunn.ch>
> >
> > Add properties to the gpio nodes to allow them to be also used as
> > pwm lines.
> >
> > Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> > URL: https://patchwork.ozlabs.org/patch/427294/
> > Signed-off-by: Ralph Sennhauser <ralph.sennhauser@gmail.com>
> > ---
> > arch/arm/boot/dts/armada-370.dtsi | 10 ++++++++--
> > arch/arm/boot/dts/armada-xp-mv78230.dtsi | 10 ++++++++--
> > arch/arm/boot/dts/armada-xp-mv78260.dtsi | 8 ++++++--
> > arch/arm/boot/dts/armada-xp-mv78460.dtsi | 10 ++++++++--
> > 4 files changed, 30 insertions(+), 8 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/armada-370.dtsi
> > b/arch/arm/boot/dts/armada-370.dtsi index cc011c8..aa9fe72 100644
> > --- a/arch/arm/boot/dts/armada-370.dtsi
> > +++ b/arch/arm/boot/dts/armada-370.dtsi
> > @@ -138,24 +138,30 @@
> >
> > gpio0: gpio at 18100 {
> > compatible = "marvell,orion-gpio";
> > - reg = <0x18100 0x40>;
> > + reg = <0x18100 0x40>, <0x181c0
> > 0x08>;
> > + reg-names = "gpio", "pwm";
> > ngpios = <32>;
> > gpio-controller;
> > #gpio-cells = <2>;
> > + #pwm-cells = <2>;
> > interrupt-controller;
> > #interrupt-cells = <2>;
> > interrupts = <82>, <83>, <84>,
> > <85>;
> > + clocks = <&coreclk 0>;
> > };
> >
> > gpio1: gpio at 18140 {
> > compatible = "marvell,orion-gpio";
> > - reg = <0x18140 0x40>;
> > + reg = <0x18140 0x40>, <0x181c8
> > 0x08>;
> > + reg-names = "gpio", "pwm";
> > ngpios = <32>;
> > gpio-controller;
> > #gpio-cells = <2>;
> > + #pwm-cells = <2>;
> > interrupt-controller;
> > #interrupt-cells = <2>;
> > interrupts = <87>, <88>, <89>,
> > <90>;
> > + clocks = <&coreclk 0>;
> > };
> >
> > gpio2: gpio at 18180 {
> > diff --git a/arch/arm/boot/dts/armada-xp-mv78230.dtsi
> > b/arch/arm/boot/dts/armada-xp-mv78230.dtsi index 07c5090..fc3934f
> > 100644 --- a/arch/arm/boot/dts/armada-xp-mv78230.dtsi
> > +++ b/arch/arm/boot/dts/armada-xp-mv78230.dtsi
> > @@ -203,24 +203,30 @@
> > internal-regs {
> > gpio0: gpio at 18100 {
> > compatible = "marvell,orion-gpio";
> > - reg = <0x18100 0x40>;
> > + reg = <0x18100 0x40>, <0x181c0
> > 0x08>;
> > + reg-names = "gpio", "pwm";
> > ngpios = <32>;
> > gpio-controller;
> > #gpio-cells = <2>;
> > + #pwm-cells = <2>;
> > interrupt-controller;
> > #interrupt-cells = <2>;
> > interrupts = <82>, <83>, <84>,
> > <85>;
> > + clocks = <&coreclk 0>;
> > };
> >
> > gpio1: gpio at 18140 {
> > compatible = "marvell,orion-gpio";
> > - reg = <0x18140 0x40>;
> > + reg = <0x18140 0x40>, <0x181c8
> > 0x08>;
> > + reg-names = "gpio", "pwm";
> > ngpios = <17>;
> > gpio-controller;
> > #gpio-cells = <2>;
> > + #pwm-cells = <2>;
> > interrupt-controller;
> > #interrupt-cells = <2>;
> > interrupts = <87>, <88>, <89>;
> > + clocks = <&coreclk 0>;
> > };
> > };
> > };
> > diff --git a/arch/arm/boot/dts/armada-xp-mv78260.dtsi
> > b/arch/arm/boot/dts/armada-xp-mv78260.dtsi index 64e936a..04dda6a
> > 100644 --- a/arch/arm/boot/dts/armada-xp-mv78260.dtsi
> > +++ b/arch/arm/boot/dts/armada-xp-mv78260.dtsi
> > @@ -286,24 +286,28 @@
> > internal-regs {
> > gpio0: gpio at 18100 {
> > compatible = "marvell,orion-gpio";
> > - reg = <0x18100 0x40>;
> > + reg = <0x18100 0x40>, <0x181c0
> > 0x08>;
> > + reg-names = "gpio", "pwm";
> > ngpios = <32>;
> > gpio-controller;
> > #gpio-cells = <2>;
> > + #pwm-cells = <2>;
> > interrupt-controller;
> > #interrupt-cells = <2>;
> > interrupts = <82>, <83>, <84>,
> > <85>;
> > + clocks = <&coreclk 0>;
> > };
> >
> > gpio1: gpio at 18140 {
> > compatible = "marvell,orion-gpio";
> > - reg = <0x18140 0x40>;
> > + reg = <0x18140 0x40>, <0x181c8
> > 0x08>; ngpios = <32>;
> > gpio-controller;
> > #gpio-cells = <2>;
> > interrupt-controller;
> > #interrupt-cells = <2>;
> > interrupts = <87>, <88>, <89>,
> > <90>;
> > + clocks = <&coreclk 0>;
> > };
> >
> > gpio2: gpio at 18180 {
> > diff --git a/arch/arm/boot/dts/armada-xp-mv78460.dtsi
> > b/arch/arm/boot/dts/armada-xp-mv78460.dtsi index d1383dd..fb6d28a
> > 100644 --- a/arch/arm/boot/dts/armada-xp-mv78460.dtsi
> > +++ b/arch/arm/boot/dts/armada-xp-mv78460.dtsi
> > @@ -324,24 +324,30 @@
> > internal-regs {
> > gpio0: gpio at 18100 {
> > compatible = "marvell,orion-gpio";
> > - reg = <0x18100 0x40>;
> > + reg = <0x18100 0x40>, <0x181c0
> > 0x08>;
> > + reg-names = "gpio", "pwm";
> > ngpios = <32>;
> > gpio-controller;
> > #gpio-cells = <2>;
> > + #pwm-cells = <2>;
> > interrupt-controller;
> > #interrupt-cells = <2>;
> > interrupts = <82>, <83>, <84>,
> > <85>;
> > + clocks = <&coreclk 0>;
> > };
> >
> > gpio1: gpio at 18140 {
> > compatible = "marvell,orion-gpio";
> > - reg = <0x18140 0x40>;
> > + reg = <0x18140 0x40>, <0x181c8
> > 0x08>;
> > + reg-names = "gpio", "pwm";
> > ngpios = <32>;
> > gpio-controller;
> > #gpio-cells = <2>;
> > + #pwm-cells = <2>;
> > interrupt-controller;
> > #interrupt-cells = <2>;
> > interrupts = <87>, <88>, <89>,
> > <90>;
> > + clocks = <&coreclk 0>;
> > };
> >
> > gpio2: gpio at 18180 {
> > --
> > 2.10.2
> >
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2 2/4] mvebu: xp: Add pwm properties to .dtsi files
2017-03-24 8:11 ` Ralph Sennhauser
@ 2017-03-24 8:37 ` Gregory CLEMENT
0 siblings, 0 replies; 7+ messages in thread
From: Gregory CLEMENT @ 2017-03-24 8:37 UTC (permalink / raw)
To: linux-arm-kernel
Hi Ralph,
On ven., mars 24 2017, Ralph Sennhauser <ralph.sennhauser@gmail.com> wrote:
> On Thu, 23 Mar 2017 17:40:53 +0100
> Gregory CLEMENT <gregory.clement@free-electrons.com> wrote:
>
>> Hi Ralph,
>>
>> On sam., mars 18 2017, Ralph Sennhauser <ralph.sennhauser@gmail.com>
>> wrote:
>>
>> It seems that I don't receive the 1st patch of the series.
>
> Hi Gregory,
>
> it makes no sense to only send part of a series to a recipient. Will
To be frank it depends. Some maintainers don't want to receive a patch
which is not related to their subsystem. But it is not my case, I prefer
to have the full picture.
> have to improve my use of --cc-cmd it seems. Will pay attention to this
> for v3.
Also don't forget to add te cover letter too if you have written one.
Thanks!
Gregory
>
> Sorry
> Ralph
>
>>
>> Also could you refresh my mind to expose why these patchse were not
>> apply the first time and why we should apply them now?
>>
>> Thanks,
>>
>> Gregory
>>
>>
>> > From: Andrew Lunn <andrew@lunn.ch>
>> >
>> > Add properties to the gpio nodes to allow them to be also used as
>> > pwm lines.
>> >
>> > Signed-off-by: Andrew Lunn <andrew@lunn.ch>
>> > URL: https://patchwork.ozlabs.org/patch/427294/
>> > Signed-off-by: Ralph Sennhauser <ralph.sennhauser@gmail.com>
>> > ---
>> > arch/arm/boot/dts/armada-370.dtsi | 10 ++++++++--
>> > arch/arm/boot/dts/armada-xp-mv78230.dtsi | 10 ++++++++--
>> > arch/arm/boot/dts/armada-xp-mv78260.dtsi | 8 ++++++--
>> > arch/arm/boot/dts/armada-xp-mv78460.dtsi | 10 ++++++++--
>> > 4 files changed, 30 insertions(+), 8 deletions(-)
>> >
>> > diff --git a/arch/arm/boot/dts/armada-370.dtsi
>> > b/arch/arm/boot/dts/armada-370.dtsi index cc011c8..aa9fe72 100644
>> > --- a/arch/arm/boot/dts/armada-370.dtsi
>> > +++ b/arch/arm/boot/dts/armada-370.dtsi
>> > @@ -138,24 +138,30 @@
>> >
>> > gpio0: gpio at 18100 {
>> > compatible = "marvell,orion-gpio";
>> > - reg = <0x18100 0x40>;
>> > + reg = <0x18100 0x40>, <0x181c0
>> > 0x08>;
>> > + reg-names = "gpio", "pwm";
>> > ngpios = <32>;
>> > gpio-controller;
>> > #gpio-cells = <2>;
>> > + #pwm-cells = <2>;
>> > interrupt-controller;
>> > #interrupt-cells = <2>;
>> > interrupts = <82>, <83>, <84>,
>> > <85>;
>> > + clocks = <&coreclk 0>;
>> > };
>> >
>> > gpio1: gpio at 18140 {
>> > compatible = "marvell,orion-gpio";
>> > - reg = <0x18140 0x40>;
>> > + reg = <0x18140 0x40>, <0x181c8
>> > 0x08>;
>> > + reg-names = "gpio", "pwm";
>> > ngpios = <32>;
>> > gpio-controller;
>> > #gpio-cells = <2>;
>> > + #pwm-cells = <2>;
>> > interrupt-controller;
>> > #interrupt-cells = <2>;
>> > interrupts = <87>, <88>, <89>,
>> > <90>;
>> > + clocks = <&coreclk 0>;
>> > };
>> >
>> > gpio2: gpio at 18180 {
>> > diff --git a/arch/arm/boot/dts/armada-xp-mv78230.dtsi
>> > b/arch/arm/boot/dts/armada-xp-mv78230.dtsi index 07c5090..fc3934f
>> > 100644 --- a/arch/arm/boot/dts/armada-xp-mv78230.dtsi
>> > +++ b/arch/arm/boot/dts/armada-xp-mv78230.dtsi
>> > @@ -203,24 +203,30 @@
>> > internal-regs {
>> > gpio0: gpio at 18100 {
>> > compatible = "marvell,orion-gpio";
>> > - reg = <0x18100 0x40>;
>> > + reg = <0x18100 0x40>, <0x181c0
>> > 0x08>;
>> > + reg-names = "gpio", "pwm";
>> > ngpios = <32>;
>> > gpio-controller;
>> > #gpio-cells = <2>;
>> > + #pwm-cells = <2>;
>> > interrupt-controller;
>> > #interrupt-cells = <2>;
>> > interrupts = <82>, <83>, <84>,
>> > <85>;
>> > + clocks = <&coreclk 0>;
>> > };
>> >
>> > gpio1: gpio at 18140 {
>> > compatible = "marvell,orion-gpio";
>> > - reg = <0x18140 0x40>;
>> > + reg = <0x18140 0x40>, <0x181c8
>> > 0x08>;
>> > + reg-names = "gpio", "pwm";
>> > ngpios = <17>;
>> > gpio-controller;
>> > #gpio-cells = <2>;
>> > + #pwm-cells = <2>;
>> > interrupt-controller;
>> > #interrupt-cells = <2>;
>> > interrupts = <87>, <88>, <89>;
>> > + clocks = <&coreclk 0>;
>> > };
>> > };
>> > };
>> > diff --git a/arch/arm/boot/dts/armada-xp-mv78260.dtsi
>> > b/arch/arm/boot/dts/armada-xp-mv78260.dtsi index 64e936a..04dda6a
>> > 100644 --- a/arch/arm/boot/dts/armada-xp-mv78260.dtsi
>> > +++ b/arch/arm/boot/dts/armada-xp-mv78260.dtsi
>> > @@ -286,24 +286,28 @@
>> > internal-regs {
>> > gpio0: gpio at 18100 {
>> > compatible = "marvell,orion-gpio";
>> > - reg = <0x18100 0x40>;
>> > + reg = <0x18100 0x40>, <0x181c0
>> > 0x08>;
>> > + reg-names = "gpio", "pwm";
>> > ngpios = <32>;
>> > gpio-controller;
>> > #gpio-cells = <2>;
>> > + #pwm-cells = <2>;
>> > interrupt-controller;
>> > #interrupt-cells = <2>;
>> > interrupts = <82>, <83>, <84>,
>> > <85>;
>> > + clocks = <&coreclk 0>;
>> > };
>> >
>> > gpio1: gpio at 18140 {
>> > compatible = "marvell,orion-gpio";
>> > - reg = <0x18140 0x40>;
>> > + reg = <0x18140 0x40>, <0x181c8
>> > 0x08>; ngpios = <32>;
>> > gpio-controller;
>> > #gpio-cells = <2>;
>> > interrupt-controller;
>> > #interrupt-cells = <2>;
>> > interrupts = <87>, <88>, <89>,
>> > <90>;
>> > + clocks = <&coreclk 0>;
>> > };
>> >
>> > gpio2: gpio at 18180 {
>> > diff --git a/arch/arm/boot/dts/armada-xp-mv78460.dtsi
>> > b/arch/arm/boot/dts/armada-xp-mv78460.dtsi index d1383dd..fb6d28a
>> > 100644 --- a/arch/arm/boot/dts/armada-xp-mv78460.dtsi
>> > +++ b/arch/arm/boot/dts/armada-xp-mv78460.dtsi
>> > @@ -324,24 +324,30 @@
>> > internal-regs {
>> > gpio0: gpio at 18100 {
>> > compatible = "marvell,orion-gpio";
>> > - reg = <0x18100 0x40>;
>> > + reg = <0x18100 0x40>, <0x181c0
>> > 0x08>;
>> > + reg-names = "gpio", "pwm";
>> > ngpios = <32>;
>> > gpio-controller;
>> > #gpio-cells = <2>;
>> > + #pwm-cells = <2>;
>> > interrupt-controller;
>> > #interrupt-cells = <2>;
>> > interrupts = <82>, <83>, <84>,
>> > <85>;
>> > + clocks = <&coreclk 0>;
>> > };
>> >
>> > gpio1: gpio at 18140 {
>> > compatible = "marvell,orion-gpio";
>> > - reg = <0x18140 0x40>;
>> > + reg = <0x18140 0x40>, <0x181c8
>> > 0x08>;
>> > + reg-names = "gpio", "pwm";
>> > ngpios = <32>;
>> > gpio-controller;
>> > #gpio-cells = <2>;
>> > + #pwm-cells = <2>;
>> > interrupt-controller;
>> > #interrupt-cells = <2>;
>> > interrupts = <87>, <88>, <89>,
>> > <90>;
>> > + clocks = <&coreclk 0>;
>> > };
>> >
>> > gpio2: gpio at 18180 {
>> > --
>> > 2.10.2
>> >
>>
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-03-24 8:37 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20170318154305.28348-1-ralph.sennhauser@gmail.com>
2017-03-18 15:43 ` [PATCH v2 2/4] mvebu: xp: Add pwm properties to .dtsi files Ralph Sennhauser
2017-03-23 16:40 ` Gregory CLEMENT
2017-03-23 21:22 ` Andrew Lunn
2017-03-24 8:11 ` Ralph Sennhauser
2017-03-24 8:37 ` Gregory CLEMENT
2017-03-18 15:43 ` [PATCH v2 3/4] ARM: mvebu: Enable SENSORS_PWM_FAN in defconfig Ralph Sennhauser
2017-03-18 15:43 ` [PATCH v2 4/4] mvebu: wrt1900ac: Use pwm-fan rather than gpio-fan Ralph Sennhauser
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).