From: boris.brezillon@free-electrons.com (Boris Brezillon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] mtd: physmap_of: really fix the physmap add-ons
Date: Wed, 29 Mar 2017 16:51:37 +0200 [thread overview]
Message-ID: <20170329165137.05336eaf@bbrezillon> (raw)
In-Reply-To: <20170327151658.6175-1-linus.walleij@linaro.org>
Hi Linus,
On Mon, 27 Mar 2017 17:16:58 +0200
Linus Walleij <linus.walleij@linaro.org> wrote:
> The current way of building the of_physmap add-ons result in just
> the add-on being in the object code, and not the actual core
> implementation and regress the Gemini and Versatile.
>
> There is no way around exporting these functions. If they are
> built as modules, they will become modules with exported functions,
> if they are builtins they will become builtins.
>
> Fixes: 4f04f68e1598 ("mtd: physmap_of: fixup gemini/versatile dependencies")
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> ChangeLog v1->v2:
> - Make the Kconfig entries tristate so they can follow the config
> of the main code portions.
> - Use the IS_ENABLED() macro from <linux/kconfig.h> to determine
> whether a certain function is available for builtin OR module.
> This is finally the silver bullet: allyes and allmod builds
> fine on x86_64.
Did you try something like that [1]? This way you wouldn't have to
export the gemini and versatile symbols and the core code would still
be embedded in the object file.
Regards,
Boris
[1]http://code.bulix.org/i810qd-124738
prev parent reply other threads:[~2017-03-29 14:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-27 15:16 [PATCH v2] mtd: physmap_of: really fix the physmap add-ons Linus Walleij
2017-03-29 14:51 ` Boris Brezillon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170329165137.05336eaf@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).