From mboxrd@z Thu Jan 1 00:00:00 1970 From: maxime.ripard@free-electrons.com (Maxime Ripard) Date: Mon, 3 Apr 2017 13:37:21 +0200 Subject: [PATCH v3 12/20] ARM: dts: sun8i: Enable dwmac-sun8i on the Orange Pi plus In-Reply-To: <20170403091444.29876-13-clabbe.montjoie@gmail.com> References: <20170403091444.29876-1-clabbe.montjoie@gmail.com> <20170403091444.29876-13-clabbe.montjoie@gmail.com> Message-ID: <20170403113721.nijh2uwgepfkrpm4@lukather> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Apr 03, 2017 at 11:14:36AM +0200, Corentin Labbe wrote: > The dwmac-sun8i hardware is present on the Orange PI plus. > It uses an external PHY rtl8211e via RGMII. > > This patch create the needed regulator, emac and phy nodes. > > Signed-off-by: Corentin Labbe > --- > arch/arm/boot/dts/sun8i-h3-orangepi-plus.dts | 36 ++++++++++++++++++++++++++++ > 1 file changed, 36 insertions(+) > > diff --git a/arch/arm/boot/dts/sun8i-h3-orangepi-plus.dts b/arch/arm/boot/dts/sun8i-h3-orangepi-plus.dts > index 8c40ab7..6852006 100644 > --- a/arch/arm/boot/dts/sun8i-h3-orangepi-plus.dts > +++ b/arch/arm/boot/dts/sun8i-h3-orangepi-plus.dts > @@ -58,6 +58,18 @@ > enable-active-high; > gpio = <&pio 6 11 GPIO_ACTIVE_HIGH>; > }; > + > + reg_gmac_3v3: gmac-3v3 { > + compatible = "regulator-fixed"; > + pinctrl-names = "default"; > + pinctrl-0 = <&gmac_power_pin_orangepi>; > + regulator-name = "gmac-3v3"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + startup-delay-us = <100000>; > + enable-active-high; > + gpio = <&pio 3 6 GPIO_ACTIVE_HIGH>; > + }; > }; > > &ehci3 { > @@ -86,8 +98,32 @@ > pins = "PG11"; > function = "gpio_out"; > }; > + > + gmac_power_pin_orangepi: gmac_power_pin at 0 { > + pins = "PD6"; > + function = "gpio_out"; > + drive-strength = <10>; > + }; This is not needed, and will even harm the fixing of a bug that will require to remove all the GPIO nodes. It works fine without it, please remove it. Thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 801 bytes Desc: not available URL: