[RFC PATCH 0/7] Hummingboard2 improvements

[RFC PATCH 0/7] Hummingboard2 improvements

[Lucas Stach]

Hi Russell,

the following patches are on top your HB2 branch. They mostly change things
that are different/redundant on mainline and allow me to drop my version of
the HB2 DT, as they are mostly aligned now.

Feel free to squash those patches down, when you send out the HB2 DT. You
may also consider this a Tested-by for the patches from Jon and you that
are currently in your HB2 branch.

Regards,
Lucas

Lucas Stach (7):
  ARM: dts: imx6*-hummingboard2: fix formatting
  ARM: dts: imx6*-hummingboard2: add SGTL5000 VDDD supply
  ARM: dts: imx6*-hummingboard2: remove LDB node
  ARM: dts: imx6*-hummingboard2: fix PCIe reset polarity
  ARM: dts: imx6*-hummingboard2: remove non-mainline property from RTC
  ARM: dts: imx6*-hummingboard2: remove redundant PWM disables
  ARM: dts: imx6*-hummingboard2: rework regulators

 arch/arm/boot/dts/imx6qdl-hummingboard2.dtsi | 61 ++++++++++------------------
 1 file changed, 21 insertions(+), 40 deletions(-)

-- 
2.9.3

[RFC PATCH 1/7] ARM: dts: imx6*-hummingboard2: fix formatting

[Lucas Stach]

Trivial formatting change.

Signed-off-by: Lucas Stach <dev@lynxeye.de>
---
 arch/arm/boot/dts/imx6qdl-hummingboard2.dtsi | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/arch/arm/boot/dts/imx6qdl-hummingboard2.dtsi b/arch/arm/boot/dts/imx6qdl-hummingboard2.dtsi
index fc79751..4513e98 100644
--- a/arch/arm/boot/dts/imx6qdl-hummingboard2.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-hummingboard2.dtsi
@@ -486,9 +486,9 @@
 };
 
 &pwm1 {
-        pinctrl-names = "default";
-        pinctrl-0 = <&pinctrl_hummingboard2_pwm1>;
-        status = "okay";
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_hummingboard2_pwm1>;
+	status = "okay";
 };
 
 &pwm3 {
@@ -538,9 +538,7 @@
 
 &usdhc3 {
 	pinctrl-names = "default";
-	pinctrl-0 = <
-		&pinctrl_hummingboard2_usdhc3
-	>;
+	pinctrl-0 = <&pinctrl_hummingboard2_usdhc3>;
 	vmmc-supply = <&reg_3p3v>;
 	vqmmc-supply = <&reg_3p3v>;
 	bus-width = <8>;
-- 
2.9.3

[RFC PATCH 2/7] ARM: dts: imx6*-hummingboard2: add SGTL5000 VDDD supply

[Lucas Stach]

VDDD is supplied by VCC_1P8 on HB2.

Signed-off-by: Lucas Stach <dev@lynxeye.de>
---
 arch/arm/boot/dts/imx6qdl-hummingboard2.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/imx6qdl-hummingboard2.dtsi b/arch/arm/boot/dts/imx6qdl-hummingboard2.dtsi
index 4513e98..8246597 100644
--- a/arch/arm/boot/dts/imx6qdl-hummingboard2.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-hummingboard2.dtsi
@@ -182,6 +182,7 @@
 		reg = <0x0a>;
 		VDDA-supply = <&reg_3p3v>;
 		VDDIO-supply = <&reg_3p3v>;
+		VDDD-supply = <&reg_1p8v>;
 	};
 };
 
-- 
2.9.3

[RFC PATCH 3/7] ARM: dts: imx6*-hummingboard2: remove LDB node

[Lucas Stach]

It's disabled by default and the data mapping is supposed to be
retrieved from the attached panel driver in mainline.

Signed-off-by: Lucas Stach <dev@lynxeye.de>
---
 arch/arm/boot/dts/imx6qdl-hummingboard2.dtsi | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/arch/arm/boot/dts/imx6qdl-hummingboard2.dtsi b/arch/arm/boot/dts/imx6qdl-hummingboard2.dtsi
index 8246597..126169a 100644
--- a/arch/arm/boot/dts/imx6qdl-hummingboard2.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-hummingboard2.dtsi
@@ -470,15 +470,6 @@
 	};
 };
 
-&ldb {
-	status = "disabled";
-
-	lvds-channel at 0 {
-		fsl,data-mapping = "spwg";
-		fsl,data-width = <18>;
-	};
-};
-
 &pcie {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_hummingboard2_pcie_reset>;
-- 
2.9.3

[RFC PATCH 4/7] ARM: dts: imx6*-hummingboard2: fix PCIe reset polarity

[Lucas Stach]

The driver always uses active-low, but better describe reality in the DT.

Signed-off-by: Lucas Stach <dev@lynxeye.de>
---
 arch/arm/boot/dts/imx6qdl-hummingboard2.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/imx6qdl-hummingboard2.dtsi b/arch/arm/boot/dts/imx6qdl-hummingboard2.dtsi
index 126169a..9c4a7d1 100644
--- a/arch/arm/boot/dts/imx6qdl-hummingboard2.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-hummingboard2.dtsi
@@ -473,7 +473,7 @@
 &pcie {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_hummingboard2_pcie_reset>;
-	reset-gpio = <&gpio2 11 0>;
+	reset-gpio = <&gpio2 11 GPIO_ACTIVE_LOW>;
 	status = "okay";
 };
 
-- 
2.9.3

[RFC PATCH 5/7] ARM: dts: imx6*-hummingboard2: remove non-mainline property from RTC

[Lucas Stach]

Signed-off-by: Lucas Stach <dev@lynxeye.de>
---
 arch/arm/boot/dts/imx6qdl-hummingboard2.dtsi | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm/boot/dts/imx6qdl-hummingboard2.dtsi b/arch/arm/boot/dts/imx6qdl-hummingboard2.dtsi
index 9c4a7d1..31a029c 100644
--- a/arch/arm/boot/dts/imx6qdl-hummingboard2.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-hummingboard2.dtsi
@@ -171,7 +171,6 @@
 	pcf8523: rtc at 68 {
 		compatible = "nxp,pcf8523";
 		reg = <0x68>;
-		nxp,12p5_pf;
 	};
 
 	sgtl5000: codec at 0a {
-- 
2.9.3

[RFC PATCH 6/7] ARM: dts: imx6*-hummingboard2: remove redundant PWM disables

[Lucas Stach]

The PWM nodes are already disabled in the imx6qdl.dtsi, so there
is no need to disable them again in the board DTS.

Signed-off-by: Lucas Stach <dev@lynxeye.de>
---
 arch/arm/boot/dts/imx6qdl-hummingboard2.dtsi | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/arch/arm/boot/dts/imx6qdl-hummingboard2.dtsi b/arch/arm/boot/dts/imx6qdl-hummingboard2.dtsi
index 31a029c..892259f 100644
--- a/arch/arm/boot/dts/imx6qdl-hummingboard2.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-hummingboard2.dtsi
@@ -482,14 +482,6 @@
 	status = "okay";
 };
 
-&pwm3 {
-	status = "disabled";
-};
-
-&pwm4 {
-	status = "disabled";
-};
-
 &ssi1 {
 	status = "okay";
 };
-- 
2.9.3

[RFC PATCH 7/7] ARM: dts: imx6*-hummingboard2: rework regulators

[Lucas Stach]

Name the regulators according to the voltage rails they are feeding in
the schematic. The USB 2-4 regulators are fixed regulators and are always
on, as they are not a VBUS supply for a single USB host port on the i.MX6,
but supply VBUS to ports behind a USB hub and there is currently no way
to model this in mainline.

Signed-off-by: Lucas Stach <dev@lynxeye.de>
---
 arch/arm/boot/dts/imx6qdl-hummingboard2.dtsi | 30 ++++++++++++++--------------
 1 file changed, 15 insertions(+), 15 deletions(-)

diff --git a/arch/arm/boot/dts/imx6qdl-hummingboard2.dtsi b/arch/arm/boot/dts/imx6qdl-hummingboard2.dtsi
index 892259f..19fe9d1 100644
--- a/arch/arm/boot/dts/imx6qdl-hummingboard2.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-hummingboard2.dtsi
@@ -58,7 +58,7 @@
 
 	reg_3p3v: regulator-3p3v {
 		compatible = "regulator-fixed";
-		regulator-name = "3P3V";
+		regulator-name = "VCC_3V2";
 		regulator-min-microvolt = <3300000>;
 		regulator-max-microvolt = <3300000>;
 		regulator-always-on;
@@ -66,21 +66,22 @@
 
 	reg_1p8v: regulator-1p8v {
 		compatible = "regulator-fixed";
-		regulator-name = "1P8V";
+		regulator-name = "VCC_1V8";
 		regulator-min-microvolt = <1800000>;
 		regulator-max-microvolt = <1800000>;
 		regulator-always-on;
 	};
 
-	reg_usbh1_vbus: regulator-usb-h1-vbus {
+	reg_usbh2_vbus: regulator-usb-h1-vbus {
 		compatible = "regulator-fixed";
 		enable-active-high;
 		gpio = <&gpio1 0 GPIO_ACTIVE_HIGH>;
 		pinctrl-names = "default";
 		pinctrl-0 = <&pinctrl_hummingboard2_usbh1_vbus>;
-		regulator-name = "usb_h1_vbus";
+		regulator-name = "V_USB2";
 		regulator-min-microvolt = <5000000>;
 		regulator-max-microvolt = <5000000>;
+		regulator-always-on;
 	};
 
 	reg_usbotg_vbus: regulator-usb-otg-vbus {
@@ -89,33 +90,33 @@
 		gpio = <&gpio3 22 GPIO_ACTIVE_HIGH>;
 		pinctrl-names = "default";
 		pinctrl-0 = <&pinctrl_hummingboard2_usbotg_vbus>;
-		regulator-name = "usb_otg_vbus";
+		regulator-name = "V_USB1";
 		regulator-min-microvolt = <5000000>;
 		regulator-max-microvolt = <5000000>;
 	};
 
-	reg_usbh2_vbus: regulator-usb-h2-vbus {
-		compatible = "regulator-gpio";
+	reg_usbh3_vbus: regulator-usb-h2-vbus {
+		compatible = "regulator-fixed";
 		enable-active-high;
 		enable-gpio = <&gpio2 13 GPIO_ACTIVE_HIGH>;
 		pinctrl-names = "default";
 		pinctrl-0 = <&pinctrl_hummingboard2_usbh2_vbus>;
-		regulator-name = "usb_h2_vbus";
+		regulator-name = "V_USB3";
 		regulator-min-microvolt = <5000000>;
 		regulator-max-microvolt = <5000000>;
-		regulator-boot-on;
+		regulator-always-on;
 	};
 
-	reg_usbh3_vbus: regulator-usb-h3-vbus {
-		compatible = "regulator-gpio";
+	reg_usbh4_vbus: regulator-usb-h3-vbus {
+		compatible = "regulator-fixed";
 		enable-active-high;
 		enable-gpio = <&gpio7 10 GPIO_ACTIVE_HIGH>;
 		pinctrl-names = "default";
 		pinctrl-0 = <&pinctrl_hummingboard2_usbh3_vbus>;
-		regulator-name = "usb_h3_vbus";
+		regulator-name = "V_USB4";
 		regulator-min-microvolt = <5000000>;
 		regulator-max-microvolt = <5000000>;
-		regulator-boot-on;
+		regulator-always-on;
 	};
 
 	reg_usdhc2_vmmc: reg-usdhc2-vmmc {
@@ -126,7 +127,7 @@
 		regulator-boot-on;
 		regulator-max-microvolt = <3300000>;
 		regulator-min-microvolt = <3300000>;
-		regulator-name = "usdhc2_vmmc";
+		regulator-name = "V_SD";
 		startup-delay-us = <1000>;
 	};
 
@@ -488,7 +489,6 @@
 
 &usbh1 {
 	disable-over-current;
-	vbus-supply = <&reg_usbh1_vbus>;
 	status = "okay";
 };
 
-- 
2.9.3

[RFC PATCH 0/7] Hummingboard2 improvements

[Lucas Stach]

Hi Russell,

it seems this is making no progress. If you don't mind I'm going to pick
up the patches from you hb2 branch and submit the whole series to Shawn,
so we can finally get things merged. Are you okay with this?

Regards,
Lucas

Am Samstag, den 08.04.2017, 16:36 +0200 schrieb Lucas Stach:
> Hi Russell,
> 
> the following patches are on top your HB2 branch. They mostly change things
> that are different/redundant on mainline and allow me to drop my version of
> the HB2 DT, as they are mostly aligned now.
> 
> Feel free to squash those patches down, when you send out the HB2 DT. You
> may also consider this a Tested-by for the patches from Jon and you that
> are currently in your HB2 branch.
> 
> Regards,
> Lucas
> 
> Lucas Stach (7):
>   ARM: dts: imx6*-hummingboard2: fix formatting
>   ARM: dts: imx6*-hummingboard2: add SGTL5000 VDDD supply
>   ARM: dts: imx6*-hummingboard2: remove LDB node
>   ARM: dts: imx6*-hummingboard2: fix PCIe reset polarity
>   ARM: dts: imx6*-hummingboard2: remove non-mainline property from RTC
>   ARM: dts: imx6*-hummingboard2: remove redundant PWM disables
>   ARM: dts: imx6*-hummingboard2: rework regulators
> 
>  arch/arm/boot/dts/imx6qdl-hummingboard2.dtsi | 61 ++++++++++------------------
>  1 file changed, 21 insertions(+), 40 deletions(-)
> 

[RFC PATCH 0/7] Hummingboard2 improvements

[Russell King - ARM Linux]

On Fri, Jun 23, 2017 at 06:15:14PM +0200, Lucas Stach wrote:
> Hi Russell,
> 
> it seems this is making no progress. If you don't mind I'm going to pick
> up the patches from you hb2 branch and submit the whole series to Shawn,
> so we can finally get things merged. Are you okay with this?

If you remember from the reviews back in January of my patch set, Jon
Nettleton promised to send me a replacement set of DT files that were
properly licensed and updated along the lines of your patches in April.
I'm still waiting...

I notice that you failed to copy Jon with your patch set, which really
isn't helping given what was said in January.  So, I'm copying this
mail to Jon.

Moreover, applying your April patches (without squashing them in to
Jon's patches) doesn't really solve the review problems - if I send
them out again, the initial patches will still have the same issues
highlighted.  If I were to squash your patches in, it means your
work gets mis-appropriated as apparently Jon's work.  So probably
whatever I do now it'll be deemed to be wrong.

So, I suggest you talk directly to Jon.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.

[RFC PATCH 0/7] Hummingboard2 improvements

[Russell King - ARM Linux]

On Sat, Jun 24, 2017 at 08:30:31AM +0100, Russell King - ARM Linux wrote:
> On Fri, Jun 23, 2017 at 06:15:14PM +0200, Lucas Stach wrote:
> > Hi Russell,
> > 
> > it seems this is making no progress. If you don't mind I'm going to pick
> > up the patches from you hb2 branch and submit the whole series to Shawn,
> > so we can finally get things merged. Are you okay with this?
> 
> If you remember from the reviews back in January of my patch set, Jon
> Nettleton promised to send me a replacement set of DT files that were
> properly licensed and updated along the lines of your patches in April.
> I'm still waiting...

I've chased Jon a couple more times since (once today), and I'm feeling
that we're not getting anywhere.  I've now told him that we (SolidRun/
myself) are in danger of having this work replaced by others.  So, I'm
now adding Rabeeh to this thread.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.

[RFC PATCH 0/7] Hummingboard2 improvements

[Jon Nettleton]

On Sun, Jul 9, 2017 at 6:39 AM, Jon Nettleton <jon@solid-run.com> wrote:
>
>
>
> On Sat, Jul 8, 2017 at 3:59 PM, Russell King - ARM Linux <linux@armlinux.org.uk> wrote:
>>
>> On Sat, Jun 24, 2017 at 08:30:31AM +0100, Russell King - ARM Linux wrote:
>> > On Fri, Jun 23, 2017 at 06:15:14PM +0200, Lucas Stach wrote:
>> > > Hi Russell,
>> > >
>> > > it seems this is making no progress. If you don't mind I'm going to pick
>> > > up the patches from you hb2 branch and submit the whole series to Shawn,
>> > > so we can finally get things merged. Are you okay with this?
>> >
>> > If you remember from the reviews back in January of my patch set, Jon
>> > Nettleton promised to send me a replacement set of DT files that were
>> > properly licensed and updated along the lines of your patches in April.
>> > I'm still waiting...
>>
>> I've chased Jon a couple more times since (once today), and I'm feeling
>> that we're not getting anywhere.  I've now told him that we (SolidRun/
>> myself) are in danger of having this work replaced by others.  So, I'm
>> now adding Rabeeh to this thread.
>>
>>

Besides the licensing there are still a number of bugs that exist for
the device-tree files as they stand.  Most notably using the standard
regulator code for the SDHC device causes a hang on reboot with some
UHS cards.

Additionally we need to bring in the support for the SOM rev1.5 which
has been waiting on the TTY slave devices infrastructure to land.  We
have been trying to come up with a better solution than duplicating
all our device-tree files with a som revision however there doesn't
seem to be.  I would prefer to bring all the support in at once since
we are only shipping rev 1.5 soms at this point

[RFC PATCH 0/7] Hummingboard2 improvements

[Lucas Stach]

Hi Jon,

Am Sonntag, den 09.07.2017, 06:42 +0200 schrieb Jon Nettleton:
> On Sun, Jul 9, 2017 at 6:39 AM, Jon Nettleton <jon@solid-run.com> wrote:
> >
> >
> >
> > On Sat, Jul 8, 2017 at 3:59 PM, Russell King - ARM Linux <linux@armlinux.org.uk> wrote:
> >>
> >> On Sat, Jun 24, 2017 at 08:30:31AM +0100, Russell King - ARM Linux wrote:
> >> > On Fri, Jun 23, 2017 at 06:15:14PM +0200, Lucas Stach wrote:
> >> > > Hi Russell,
> >> > >
> >> > > it seems this is making no progress. If you don't mind I'm going to pick
> >> > > up the patches from you hb2 branch and submit the whole series to Shawn,
> >> > > so we can finally get things merged. Are you okay with this?
> >> >
> >> > If you remember from the reviews back in January of my patch set, Jon
> >> > Nettleton promised to send me a replacement set of DT files that were
> >> > properly licensed and updated along the lines of your patches in April.
> >> > I'm still waiting...
> >>
> >> I've chased Jon a couple more times since (once today), and I'm feeling
> >> that we're not getting anywhere.  I've now told him that we (SolidRun/
> >> myself) are in danger of having this work replaced by others.  So, I'm
> >> now adding Rabeeh to this thread.
> >>
> >>
> 
> Besides the licensing there are still a number of bugs that exist for
> the device-tree files as they stand.  Most notably using the standard
> regulator code for the SDHC device causes a hang on reboot with some
> UHS cards.

What's the issue here? Is the bootloader not coming up, or does the
kernel hang at boot?

> Additionally we need to bring in the support for the SOM rev1.5 which
> has been waiting on the TTY slave devices infrastructure to land.  We
> have been trying to come up with a better solution than duplicating
> all our device-tree files with a som revision however there doesn't
> seem to be.  I would prefer to bring all the support in at once since
> we are only shipping rev 1.5 soms at this point

What's the difference between the old and new SoMs? Can we patch the DTs
from the bootloader instead of introducing more variants?

Frankly this whole situation is very bad. I have this Hummingboard2
lying around for 1.5 years now, with no mainline support available. With
the reasoning above it doesn't seem like this is going to change in the
near future, as perfect is the enemy of good.

Is there anything we can do help out with this?

Regards,
Lucas

[RFC PATCH 0/7] Hummingboard2 improvements

[Jon Nettleton]

On Mon, Jul 10, 2017 at 10:52 AM, Lucas Stach <l.stach@pengutronix.de> wrote:
> Hi Jon,
>
> Am Sonntag, den 09.07.2017, 06:42 +0200 schrieb Jon Nettleton:
>> On Sun, Jul 9, 2017 at 6:39 AM, Jon Nettleton <jon@solid-run.com> wrote:
>> >
>> >
>> >
>> > On Sat, Jul 8, 2017 at 3:59 PM, Russell King - ARM Linux <linux@armlinux.org.uk> wrote:
>> >>
>> >> On Sat, Jun 24, 2017 at 08:30:31AM +0100, Russell King - ARM Linux wrote:
>> >> > On Fri, Jun 23, 2017 at 06:15:14PM +0200, Lucas Stach wrote:
>> >> > > Hi Russell,
>> >> > >
>> >> > > it seems this is making no progress. If you don't mind I'm going to pick
>> >> > > up the patches from you hb2 branch and submit the whole series to Shawn,
>> >> > > so we can finally get things merged. Are you okay with this?
>> >> >
>> >> > If you remember from the reviews back in January of my patch set, Jon
>> >> > Nettleton promised to send me a replacement set of DT files that were
>> >> > properly licensed and updated along the lines of your patches in April.
>> >> > I'm still waiting...
>> >>
>> >> I've chased Jon a couple more times since (once today), and I'm feeling
>> >> that we're not getting anywhere.  I've now told him that we (SolidRun/
>> >> myself) are in danger of having this work replaced by others.  So, I'm
>> >> now adding Rabeeh to this thread.
>> >>
>> >>
>>
>> Besides the licensing there are still a number of bugs that exist for
>> the device-tree files as they stand.  Most notably using the standard
>> regulator code for the SDHC device causes a hang on reboot with some
>> UHS cards.
>
> What's the issue here? Is the bootloader not coming up, or does the
> kernel hang at boot?

it crashes the SDHC firmware because there isn't a long enough time
between power down at 1.8V and power-up at 3.3V.  The old framework
used to use card-external-vcc-supply which allowed enough time for the
card to fully reset.

>
>> Additionally we need to bring in the support for the SOM rev1.5 which
>> has been waiting on the TTY slave devices infrastructure to land.  We
>> have been trying to come up with a better solution than duplicating
>> all our device-tree files with a som revision however there doesn't
>> seem to be.  I would prefer to bring all the support in at once since
>> we are only shipping rev 1.5 soms at this point
>
> What's the difference between the old and new SoMs? Can we patch the DTs
> from the bootloader instead of introducing more variants?

Yes that is the new plan now that u-boot supports this.

>
> Frankly this whole situation is very bad. I have this Hummingboard2
> lying around for 1.5 years now, with no mainline support available. With
> the reasoning above it doesn't seem like this is going to change in the
> near future, as perfect is the enemy of good.
>

I will have new patches ready for -rc1.  Spoke with Russell on irc
last night and the plan is to only support the fully populated board
for each family.  Then we can use overlays in u-boot to disable /
enable devices for the variants.

We will also look into user-space probing for additional devices in
order to load add-on device fragments later on in boot, although that
is a topic for another discussion.

Without changing the structure of our device-tree files in mainline we
are looking at maintaining 20 just for iMX6, and that will only grow.
Not to mention customer boards etc.  The main question now is, where
do we store all the overlay fragments?

-Jon