Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 5/6] mfd: exynos-lpass: Add missing remove() function
Date: Tue, 11 Apr 2017 13:03:19 +0100	[thread overview]
Message-ID: <20170411120319.wzdl5spygk5ugmww@dell> (raw)
In-Reply-To: <1490256207-10061-6-git-send-email-m.szyprowski@samsung.com>

On Thu, 23 Mar 2017, Marek Szyprowski wrote:

> Disable device on driver remove and release allocated regmap.
> 
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
> Acked-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>
> ---
>  drivers/mfd/exynos-lpass.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)

Applied, thanks.

> diff --git a/drivers/mfd/exynos-lpass.c b/drivers/mfd/exynos-lpass.c
> index be264988bdc9..9dbbedad916f 100644
> --- a/drivers/mfd/exynos-lpass.c
> +++ b/drivers/mfd/exynos-lpass.c
> @@ -137,6 +137,16 @@ static int exynos_lpass_probe(struct platform_device *pdev)
>  	return of_platform_populate(dev->of_node, NULL, NULL, dev);
>  }
>  
> +static int exynos_lpass_remove(struct platform_device *pdev)
> +{
> +	struct exynos_lpass *lpass = platform_get_drvdata(pdev);
> +
> +	exynos_lpass_disable(lpass);
> +	regmap_exit(lpass->top);
> +
> +	return 0;
> +}
> +
>  static int __maybe_unused exynos_lpass_suspend(struct device *dev)
>  {
>  	struct exynos_lpass *lpass = dev_get_drvdata(dev);
> @@ -171,6 +181,7 @@ static SIMPLE_DEV_PM_OPS(lpass_pm_ops, exynos_lpass_suspend,
>  		.of_match_table	= exynos_lpass_of_match,
>  	},
>  	.probe	= exynos_lpass_probe,
> +	.remove	= exynos_lpass_remove,
>  };
>  module_platform_driver(exynos_lpass_driver);
>  

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

  reply	other threads:[~2017-04-11 12:03 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20170323080346eucas1p216eec41325d220774ecec05b397e83a6@eucas1p2.samsung.com>
2017-03-23  8:03 ` [PATCH v4 0/6] Pad retentions support for Exynos5433 Marek Szyprowski
2017-03-23  8:03   ` [PATCH v4 1/6] pinctrl: samsung: Ensure that pad retention is disabled on driver init Marek Szyprowski
2017-03-23 19:14     ` Krzysztof Kozlowski
2017-03-23  8:03   ` [PATCH v4 2/6] pinctrl: samsung: Add support for pad retention control for Exynos5433 SoCs Marek Szyprowski
2017-03-23 19:15     ` Krzysztof Kozlowski
2017-03-23  8:03   ` [PATCH v4 3/6] mfd: exynos-lpass: Remove pad retention control Marek Szyprowski
2017-04-11 12:02     ` Lee Jones
2017-04-19 11:00       ` Marek Szyprowski
2017-04-24 10:35         ` Lee Jones
2017-03-23  8:03   ` [PATCH v4 4/6] mfd: exynos-lpass: Add support for clocks Marek Szyprowski
2017-04-11 12:03     ` Lee Jones
2017-03-23  8:03   ` [PATCH v4 5/6] mfd: exynos-lpass: Add missing remove() function Marek Szyprowski
2017-04-11 12:03     ` Lee Jones [this message]
2017-03-23  8:03   ` [PATCH v4 6/6] mfd: exynos-lpass: Add runtime PM support Marek Szyprowski
2017-04-11 12:03     ` Lee Jones
2017-03-28  9:22   ` [PATCH v4 0/6] Pad retentions support for Exynos5433 Linus Walleij
2017-03-28 10:14     ` Krzysztof Kozlowski
2017-03-28 15:42   ` [GIT PULL] mfd: exynos-lpass: Pinctrl dependency Krzysztof Kozlowski
2017-04-03 10:18     ` Lee Jones
2017-04-04  8:23       ` Krzysztof Kozlowski
2017-04-04  9:50         ` Lee Jones
2017-04-04  9:57           ` Krzysztof Kozlowski
2017-04-11 11:57             ` Lee Jones
2017-04-11 11:59     ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170411120319.wzdl5spygk5ugmww@dell \
    --to=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox