From: daniel@ffwll.ch (Daniel Vetter)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 04/10] drm/stm: Add STM32 LTDC driver
Date: Tue, 11 Apr 2017 22:51:32 +0200 [thread overview]
Message-ID: <20170411205132.sze2wfnnim4halqb@phenom.ffwll.local> (raw)
In-Reply-To: <87wpaqeks2.fsf@eliezer.anholt.net>
On Tue, Apr 11, 2017 at 01:45:01PM -0700, Eric Anholt wrote:
> Yannick Fertre <yannick.fertre@st.com> writes:
> > +static void ltdc_crtc_disable(struct drm_crtc *crtc)
> > +{
> > + struct ltdc_device *ldev = crtc_to_ltdc(crtc);
> > + struct drm_pending_vblank_event *event = crtc->state->event;
> > +
> > + DRM_DEBUG_DRIVER("\n");
> > +
> > + if (!crtc->enabled) {
> > + DRM_DEBUG_DRIVER("already disabled\n");
> > + return;
> > + }
>
> I think this crtc->enabled is a given for the disable() being called.
Yup, one design principle of atomic (compared to the legacy modeset
helpers) is to correctly keep track of hw state and not call a hook when
not needed. If you don't trust them, conver them to WARN_ON, but otherwise
best to remove.
But like Eric said, totally fine in a follow-up patch.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
next prev parent reply other threads:[~2017-04-11 20:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-28 9:44 [PATCH v5 00/10] STM32 LCD-TFT display controller Yannick Fertre
2017-03-28 9:44 ` [PATCH v5 01/10] drm/cma: Update DEFINE_DRM_GEM_CMA_FOPS to add get_unmapped_area Yannick Fertre
2017-03-28 9:44 ` [PATCH v5 02/10] drm/fb-cma-helper: Add drm_fb_cma_get_gem_addr() Yannick Fertre
2017-03-28 9:44 ` [PATCH v5 03/10] dt-bindings: display: Add STM32 LTDC driver Yannick Fertre
2017-03-28 9:44 ` [PATCH v5 04/10] drm/stm: " Yannick Fertre
2017-04-11 20:45 ` Eric Anholt
2017-04-11 20:51 ` Daniel Vetter [this message]
2017-04-12 18:58 ` Benjamin Gaignard
2017-03-28 9:44 ` [PATCH v5 05/10] dt-bindings: Add Ampire AM-480272H3TMQW-T01H panel Yannick Fertre
2017-04-06 21:27 ` Thierry Reding
2017-03-28 9:44 ` [PATCH v5 06/10] drm/panel: simple: Add support for Ampire AM-480272H3TMQW-T01H Yannick Fertre
2017-04-06 21:27 ` Thierry Reding
2017-03-28 9:44 ` [PATCH v5 07/10] ARM: dts: stm32: Add ltdc support on stm32f429 MCU Yannick Fertre
2017-03-28 9:44 ` [PATCH v5 08/10] ARM: dts: stm32: Enable ltdc & simple panel on stm32f429-Eval board Yannick Fertre
2017-03-28 9:44 ` [PATCH v5 09/10] ARM: configs: stm32: Add DRM support in STM32 defconfig Yannick Fertre
2017-03-28 9:44 ` [PATCH v5 10/10] ARM: configs: stm32: Add simple panel " Yannick Fertre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170411205132.sze2wfnnim4halqb@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox