From: jszhang@marvell.com (Jisheng Zhang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] mmc: sdhci: provide isr for card-detect interrupts
Date: Thu, 13 Apr 2017 17:17:59 +0800 [thread overview]
Message-ID: <20170413171759.1e98aa36@xhacker> (raw)
In-Reply-To: <772c085c-beba-cfe8-23ca-0c46a96145fe@intel.com>
On Tue, 11 Apr 2017 13:31:16 +0300 Adrian Hunter wrote:
> On 11/04/17 13:20, Jisheng Zhang wrote:
> > We found one issue on BG4CT platforms with GPIO for sdcar card detect
> > interrupt: remove sdcard when there's read write access to the sdcard,
> > sometimes the card remove event can't be handled for a long time, so
> > the system still think the sdcard is still plugged in. It turns out
> > that the sdhci_card_event() is missing in common slot gpio's card
> > detect isr.
>
> ->card_event() is called by mmc_rescan(). Why is that too late?
Indeed, maybe the "too late" here is not accurate. Compared with host's
CD interrupt handling, the GPIO CD interrupt handling differs in when to
call sdhci_card_event(): in previous case, it's called in ISR, in later
it's in workqueue.
Now, I agree it's not necessary to put into ISR. So let's ignore the
two patches.
Thanks for your review,
Jisheng
prev parent reply other threads:[~2017-04-13 9:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-11 10:20 [PATCH 0/2] provide isr for card-detect interrupts Jisheng Zhang
2017-04-11 10:20 ` [PATCH 1/2] mmc: slot-gpio: check cd_gpio before setting up cd_gpio_isr Jisheng Zhang
2017-04-11 10:20 ` [PATCH 2/2] mmc: sdhci: provide isr for card-detect interrupts Jisheng Zhang
2017-04-11 10:31 ` Adrian Hunter
2017-04-13 9:17 ` Jisheng Zhang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170413171759.1e98aa36@xhacker \
--to=jszhang@marvell.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).