From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: imx53-qsrb: Pulldown PMIC IRQ pin
Date: Fri, 14 Apr 2017 11:06:54 +0800 [thread overview]
Message-ID: <20170414030652.GC14915@dragon> (raw)
In-Reply-To: <1492020275-29654-1-git-send-email-fabio.estevam@nxp.com>
On Wed, Apr 12, 2017 at 03:04:35PM -0300, Fabio Estevam wrote:
> Currently the following errors are seeing:
>
> [ 14.015056] mc13xxx 0-0008: Failed to read IRQ status: -6
> [ 27.321093] mc13xxx 0-0008: Failed to read IRQ status: -6
> [ 27.411681] mc13xxx 0-0008: Failed to read IRQ status: -6
> [ 27.456281] mc13xxx 0-0008: Failed to read IRQ status: -6
> [ 30.527106] mc13xxx 0-0008: Failed to read IRQ status: -6
> [ 36.596900] mc13xxx 0-0008: Failed to read IRQ status: -6
>
> Also when reading the interrupts via 'cat /proc/interrupts' the
> PMIC GPIO interrupt counter does not stop increasing.
>
> The reason for the storm of interrupts is that the PUS field of
> register IOMUXC_SW_PAD_CTL_PAD_CSI0_DAT5 is currently configured as:
> 10 : 100k pullup
>
> and the PMIC interrupt is being registered as IRQ_TYPE_LEVEL_HIGH type,
> which is the correct type as per the MC34708 datasheet.
>
> Use the default power on value for the IOMUX, which sets PUS field as:
> 00: 360k pull down
>
> This prevents the spurious PMIC interrupts from happening.
>
> Commit e1ffceb078c6 ("ARM: imx53: qsrb: fix PMIC interrupt level")
> correctly described the irq type as IRQ_TYPE_LEVEL_HIGH, but
> missed to update the IOMUX of the PMIC GPIO to pull down.
>
> Fixes: e1ffceb078c6 ("ARM: imx53: qsrb: fix PMIC interrupt level")
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
Applied, thanks.
prev parent reply other threads:[~2017-04-14 3:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-12 18:04 [PATCH] ARM: dts: imx53-qsrb: Pulldown PMIC IRQ pin Fabio Estevam
2017-04-14 3:06 ` Shawn Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170414030652.GC14915@dragon \
--to=shawnguo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).