* [PATCH] ARM: dts: BCM5301X: Add CPU thermal sensor and zone
@ 2017-04-14 21:42 Rafał Miłecki
2017-04-17 14:54 ` Jon Mason
0 siblings, 1 reply; 4+ messages in thread
From: Rafał Miłecki @ 2017-04-14 21:42 UTC (permalink / raw)
To: linux-arm-kernel
From: Rafa? Mi?ecki <rafal@milecki.pl>
This uses CPU thermal sensor available on every Northstar chipset to
monitor temperature. We don't have any cooling or throttling so only a
critical trip was added.
Signed-off-by: Rafa? Mi?ecki <rafal@milecki.pl>
---
arch/arm/boot/dts/bcm5301x.dtsi | 26 ++++++++++++++++++++++++++
1 file changed, 26 insertions(+)
diff --git a/arch/arm/boot/dts/bcm5301x.dtsi b/arch/arm/boot/dts/bcm5301x.dtsi
index 6a2afe7880ae..bbf39deb89f3 100644
--- a/arch/arm/boot/dts/bcm5301x.dtsi
+++ b/arch/arm/boot/dts/bcm5301x.dtsi
@@ -356,6 +356,12 @@
"sata2";
};
+ thermal: thermal at 1800c2c0 {
+ compatible = "brcm,ns-thermal";
+ reg = <0x1800c2c0 0x10>;
+ #thermal-sensor-cells = <0>;
+ };
+
srab: srab at 18007000 {
compatible = "brcm,bcm5301x-srab";
reg = <0x18007000 0x1000>;
@@ -419,4 +425,24 @@
status = "disabled";
};
};
+
+ thermal-zones {
+ cpu_thermal: cpu-thermal {
+ polling-delay-passive = <0>;
+ polling-delay = <1000>;
+ coefficients = <(-556) 418000>;
+ thermal-sensors = <&thermal>;
+
+ trips {
+ cpu-crit {
+ temperature = <125000>;
+ hysteresis = <0>;
+ type = "critical";
+ };
+ };
+
+ cooling-maps {
+ };
+ };
+ };
};
--
2.11.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] ARM: dts: BCM5301X: Add CPU thermal sensor and zone
2017-04-14 21:42 [PATCH] ARM: dts: BCM5301X: Add CPU thermal sensor and zone Rafał Miłecki
@ 2017-04-17 14:54 ` Jon Mason
2017-04-17 16:14 ` Rafał Miłecki
0 siblings, 1 reply; 4+ messages in thread
From: Jon Mason @ 2017-04-17 14:54 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Apr 14, 2017 at 5:42 PM, Rafa? Mi?ecki <zajec5@gmail.com> wrote:
> From: Rafa? Mi?ecki <rafal@milecki.pl>
>
> This uses CPU thermal sensor available on every Northstar chipset to
> monitor temperature. We don't have any cooling or throttling so only a
> critical trip was added.
Haha! You beat me to it (as I had a similar patch queued).
This looks good to me.
Acked-by: Jon Mason <jon.mason@broadcom.com>
>
> Signed-off-by: Rafa? Mi?ecki <rafal@milecki.pl>
> ---
> arch/arm/boot/dts/bcm5301x.dtsi | 26 ++++++++++++++++++++++++++
> 1 file changed, 26 insertions(+)
>
> diff --git a/arch/arm/boot/dts/bcm5301x.dtsi b/arch/arm/boot/dts/bcm5301x.dtsi
> index 6a2afe7880ae..bbf39deb89f3 100644
> --- a/arch/arm/boot/dts/bcm5301x.dtsi
> +++ b/arch/arm/boot/dts/bcm5301x.dtsi
> @@ -356,6 +356,12 @@
> "sata2";
> };
>
> + thermal: thermal at 1800c2c0 {
> + compatible = "brcm,ns-thermal";
> + reg = <0x1800c2c0 0x10>;
> + #thermal-sensor-cells = <0>;
> + };
> +
> srab: srab at 18007000 {
> compatible = "brcm,bcm5301x-srab";
> reg = <0x18007000 0x1000>;
> @@ -419,4 +425,24 @@
> status = "disabled";
> };
> };
> +
> + thermal-zones {
> + cpu_thermal: cpu-thermal {
> + polling-delay-passive = <0>;
> + polling-delay = <1000>;
> + coefficients = <(-556) 418000>;
> + thermal-sensors = <&thermal>;
> +
> + trips {
> + cpu-crit {
> + temperature = <125000>;
> + hysteresis = <0>;
> + type = "critical";
> + };
> + };
> +
> + cooling-maps {
> + };
> + };
> + };
> };
> --
> 2.11.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] ARM: dts: BCM5301X: Add CPU thermal sensor and zone
2017-04-17 14:54 ` Jon Mason
@ 2017-04-17 16:14 ` Rafał Miłecki
2017-04-17 19:39 ` Jon Mason
0 siblings, 1 reply; 4+ messages in thread
From: Rafał Miłecki @ 2017-04-17 16:14 UTC (permalink / raw)
To: linux-arm-kernel
On 17 April 2017 at 16:54, Jon Mason <jon.mason@broadcom.com> wrote:
> On Fri, Apr 14, 2017 at 5:42 PM, Rafa? Mi?ecki <zajec5@gmail.com> wrote:
>> From: Rafa? Mi?ecki <rafal@milecki.pl>
>>
>> This uses CPU thermal sensor available on every Northstar chipset to
>> monitor temperature. We don't have any cooling or throttling so only a
>> critical trip was added.
>
> Haha! You beat me to it (as I had a similar patch queued).
>
> This looks good to me.
>
> Acked-by: Jon Mason <jon.mason@broadcom.com>
:) Thanks
I'd appreciate adding thermal to NSP DT. I don't have any NSP unit to
try it on my own.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] ARM: dts: BCM5301X: Add CPU thermal sensor and zone
2017-04-17 16:14 ` Rafał Miłecki
@ 2017-04-17 19:39 ` Jon Mason
0 siblings, 0 replies; 4+ messages in thread
From: Jon Mason @ 2017-04-17 19:39 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Apr 17, 2017 at 12:14 PM, Rafa? Mi?ecki <zajec5@gmail.com> wrote:
> On 17 April 2017 at 16:54, Jon Mason <jon.mason@broadcom.com> wrote:
>> On Fri, Apr 14, 2017 at 5:42 PM, Rafa? Mi?ecki <zajec5@gmail.com> wrote:
>>> From: Rafa? Mi?ecki <rafal@milecki.pl>
>>>
>>> This uses CPU thermal sensor available on every Northstar chipset to
>>> monitor temperature. We don't have any cooling or throttling so only a
>>> critical trip was added.
>>
>> Haha! You beat me to it (as I had a similar patch queued).
>>
>> This looks good to me.
>>
>> Acked-by: Jon Mason <jon.mason@broadcom.com>
>
> :) Thanks
>
> I'd appreciate adding thermal to NSP DT. I don't have any NSP unit to
> try it on my own.
I'm doing so right now. I have it working, I just need to clean up the patches.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-04-17 19:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-14 21:42 [PATCH] ARM: dts: BCM5301X: Add CPU thermal sensor and zone Rafał Miłecki
2017-04-17 14:54 ` Jon Mason
2017-04-17 16:14 ` Rafał Miłecki
2017-04-17 19:39 ` Jon Mason
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).