From: jthumshirn@suse.de (Johannes Thumshirn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: Fix rd_size declaration
Date: Tue, 18 Apr 2017 16:10:50 +0200 [thread overview]
Message-ID: <20170418141050.GG6056@linux-x5ow.site> (raw)
In-Reply-To: <1492524472.2628.3.camel@sandisk.com>
On Tue, Apr 18, 2017 at 02:07:53PM +0000, Bart Van Assche wrote:
> Hello Johannes,
>
> Thanks for the review. But are you aware that with the current content an
> include guard is overkill because it is safe to evaluate the "extern unsigned
> long rd_size" declaration multiple times?
Yes I am. But once someone does changes to this header and forgets the include
guard as well it may cause errors.
I am aware that this is rather cosmetic than needed, that's why I declared it
as a nit.
Byte,
Johannes
--
Johannes Thumshirn Storage
jthumshirn at suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg
GF: Felix Imend?rffer, Jane Smithard, Graham Norton
HRB 21284 (AG N?rnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
next prev parent reply other threads:[~2017-04-18 14:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-17 23:10 [PATCH] ARM: Fix rd_size declaration Bart Van Assche
2017-04-18 7:35 ` Johannes Thumshirn
2017-04-18 14:07 ` Bart Van Assche
2017-04-18 14:10 ` Johannes Thumshirn [this message]
2017-04-26 20:51 ` Bart Van Assche
2017-05-03 19:25 ` Russell King - ARM Linux
2017-05-03 19:38 ` Bart Van Assche
-- strict thread matches above, loose matches on Subject: below --
2017-05-03 19:46 Bart Van Assche
2017-05-03 19:48 ` Bart Van Assche
2017-06-21 20:26 ` Bart Van Assche
2017-06-26 9:38 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170418141050.GG6056@linux-x5ow.site \
--to=jthumshirn@suse.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).