From mboxrd@z Thu Jan 1 00:00:00 1970 From: maxime.ripard@free-electrons.com (Maxime Ripard) Date: Thu, 20 Apr 2017 07:58:02 +0200 Subject: [linux-sunxi] Re: [PATCH v3 02/12] arm64: allwinner: a64: add NMI controller on A64 In-Reply-To: References: <20170417115747.7300-1-icenowy@aosc.io> <20170417115747.7300-3-icenowy@aosc.io> <20170418070016.qsng3qtk76bqxyc5@lukather> Message-ID: <20170420055802.btibui5pspan4qal@lukather> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Apr 18, 2017 at 06:56:43PM +0800, Icenowy Zheng wrote: > > > ? 2017?4?18? GMT+08:00 ??3:00:16, Maxime Ripard ??: > >On Mon, Apr 17, 2017 at 07:57:37PM +0800, Icenowy Zheng wrote: > >> Allwinner A64 SoC features a NMI controller, which is usually > >connected > >> to the AXP PMIC. > >> > >> Add support for it. > >> > >> Signed-off-by: Icenowy Zheng > >> Acked-by: Chen-Yu Tsai > >> --- > >> Changes in v2: > >> - Added Chen-Yu's ACK. > >> > >> arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 8 ++++++++ > >> 1 file changed, 8 insertions(+) > >> > >> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > >b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > >> index 05ec9fc5e81f..53c18ca372ea 100644 > >> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > >> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > >> @@ -403,6 +403,14 @@ > >> ; > >> }; > >> > >> + nmi_intc: interrupt-controller at 01f00c0c { > >> + compatible = "allwinner,sun6i-a31-sc-nmi"; > >> + interrupt-controller; > >> + #interrupt-cells = <2>; > >> + reg = <0x01f00c0c 0x38>; > > > >The base address is not correct, and there's uncertainty on whether > >this is this particular controller or not. Did you even test this? > > Tested by axp20x-pek. Still, the base address is wrong, which is yet another hint that this is not the same interrupt controller, and just works by accident. Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 801 bytes Desc: not available URL: