From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: omap2+: make omap4_get_cpu1_ns_pa_addr declaration usable
Date: Fri, 21 Apr 2017 15:21:59 -0700 [thread overview]
Message-ID: <20170421222159.GA3780@atomide.com> (raw)
In-Reply-To: <20170421215556.2244576-1-arnd@arndb.de>
* Arnd Bergmann <arnd@arndb.de> [170421 14:59]:
> When CONFIG_PM is disabled, we get a build error:
>
> arch/arm/mach-omap2/omap-smp.c: In function 'omap4_smp_maybe_reset_cpu1':
> arch/arm/mach-omap2/omap-smp.c:309:20: error: implicit declaration of function 'omap4_get_cpu1_ns_pa_addr'; did you mean 'omap4_get_scu_base'? [-Werror=implicit-function-declaration]
>
> We need to fix this in multiple files, to ensure the declaration is visible,
> to actually build the function without CONFIG_PM, and to only call it
> when OMAP4 and/or OMAP5 are enabled.
>
> Fixes: 351b7c490700 ("ARM: omap2+: Revert omap-smp.c changes resetting CPU1 during boot")
Oops, sorry about that. Looks like I never hit that with my
randconfig builds earlier probably as we have at least CPU_IDLE and
ARCH_OMAP2PLUS_TYPICAL select PM. Thanks for fixing it:
Acked-by: Tony Lindgren <tony@atomide.com>
prev parent reply other threads:[~2017-04-21 22:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-21 21:55 [PATCH] ARM: omap2+: make omap4_get_cpu1_ns_pa_addr declaration usable Arnd Bergmann
2017-04-21 22:21 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170421222159.GA3780@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox