From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] misc: sram-exec: Use aligned fncpy instead of memcpy
Date: Wed, 26 Apr 2017 07:49:43 -0700 [thread overview]
Message-ID: <20170426144943.GG3780@atomide.com> (raw)
In-Reply-To: <20170410145247.6023-1-d-gerlach@ti.com>
* Dave Gerlach <d-gerlach@ti.com> [170410 07:55]:
> Currently the sram-exec functionality, which allows allocation of
> executable memory and provides an API to move code to it, is only
> selected in configs for the ARM architecture. Based on commit
> 5756e9dd0de6 ("ARM: 6640/1: Thumb-2: Symbol manipulation macros for
> function body copying") simply copying a C function pointer address
> using memcpy without consideration of alignment and Thumb is unsafe on
> ARM platforms.
>
> The aforementioned patch introduces the fncpy macro which is a safe way
> to copy executable code on ARM platforms, so let's make use of that here
> rather than the unsafe plain memcpy that was previously used by
> sram_exec_copy. Now sram_exec_copy will move the code to "dst" and
> return an address that is guaranteed to be safely callable.
>
> In the future, architectures hoping to make use of the sram-exec
> functionality must define an fncpy macro just as ARM has done to
> guarantee or check for safe copying to executable memory before allowing
> the arch to select CONFIG_SRAM_EXEC.
Looks good to me:
Acked-by: Tony Lindgren <tony@atomide.com>
next prev parent reply other threads:[~2017-04-26 14:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-10 14:52 [PATCH v2] misc: sram-exec: Use aligned fncpy instead of memcpy Dave Gerlach
2017-04-26 14:49 ` Tony Lindgren [this message]
2017-05-03 18:55 ` Russell King - ARM Linux
2017-05-16 16:01 ` Tony Lindgren
2017-05-17 9:13 ` Greg Kroah-Hartman
2017-05-17 11:43 ` Russell King - ARM Linux
2017-05-17 13:47 ` Tony Lindgren
2017-05-17 14:23 ` Dave Gerlach
2017-05-04 12:36 ` Alexandre Belloni
2017-05-18 15:01 ` Greg Kroah-Hartman
2017-05-18 15:09 ` Dave Gerlach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170426144943.GG3780@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).