From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: Print DT machine model in setup_machine_fdt()
Date: Fri, 28 Apr 2017 15:57:30 +0100 [thread overview]
Message-ID: <20170428145730.GS13675@arm.com> (raw)
In-Reply-To: <1493296385-14140-1-git-send-email-geert+renesas@glider.be>
On Thu, Apr 27, 2017 at 02:33:05PM +0200, Geert Uytterhoeven wrote:
> On arm32, the machine model specified in the device tree is printed
> during boot-up, courtesy of of_flat_dt_match_machine().
>
> On arm64, of_flat_dt_match_machine() is not called, and the machine
> model information is not available from the kernel log.
>
> Print the machine model to make it easier to derive the machine model
> from an arbitrary kernel boot log.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> I have scripts to save kernel boot logs, and compare logs[*] for
> subsequent boots on the same machine. Having a way to extract the
> machine model from an arbitrary kernel boot log makes this easier.
>
> Yes, I'm also a big fan of CONFIG_LOCALVERSION_AUTO and
> CONFIG_LOCALVERSION.
>
> [*] and clock and PM domain lists...
> ---
> arch/arm64/kernel/setup.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/kernel/setup.c b/arch/arm64/kernel/setup.c
> index 28855ec1be95e113..2c822ef94f341417 100644
> --- a/arch/arm64/kernel/setup.c
> +++ b/arch/arm64/kernel/setup.c
> @@ -180,6 +180,7 @@ static void __init smp_build_mpidr_hash(void)
> static void __init setup_machine_fdt(phys_addr_t dt_phys)
> {
> void *dt_virt = fixmap_remap_fdt(dt_phys);
> + const char *name;
>
> if (!dt_virt || !early_init_dt_scan(dt_virt)) {
> pr_crit("\n"
> @@ -192,7 +193,9 @@ static void __init setup_machine_fdt(phys_addr_t dt_phys)
> cpu_relax();
> }
>
> - dump_stack_set_arch_desc("%s (DT)", of_flat_dt_get_machine_name());
> + name = of_flat_dt_get_machine_name();
> + pr_info("Machine model: %s\n", name);
> + dump_stack_set_arch_desc("%s (DT)", name);
> }
I think your use-case is slightly questionable (e.g. for ACPI, we print
something different, and this isn't generally considered to be ABI), but
the patch is harmless and if you find it useful then:
Acked-by: Will Deacon <will.deacon@arm.com>
Will
next prev parent reply other threads:[~2017-04-28 14:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-27 12:33 [PATCH] arm64: Print DT machine model in setup_machine_fdt() Geert Uytterhoeven
2017-04-28 14:57 ` Will Deacon [this message]
2017-04-28 16:16 ` Geert Uytterhoeven
2017-04-28 16:52 ` Will Deacon
2017-04-28 17:30 ` Sudeep Holla
2017-04-28 16:14 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170428145730.GS13675@arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).