linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: christoffer.dall@linaro.org (Christoffer Dall)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 16/22] KVM: arm64: vgic-its: Add infrastructure for table lookup
Date: Sun, 30 Apr 2017 13:13:38 -0700	[thread overview]
Message-ID: <20170430201338.GC1670@lvm> (raw)
In-Reply-To: <1492164934-988-17-git-send-email-eric.auger@redhat.com>

On Fri, Apr 14, 2017 at 12:15:28PM +0200, Eric Auger wrote:
> Add a generic lookup_table() helper whose role consists in
> scanning a contiguous table located in guest RAM and applying
> a callback on each entry. Entries can be handled as linked lists
> since the callback may return an offset to the next entry and
> also tell that an entry is the last one.
> 
> Helper functions also are added to compute the device/event ID
> offset to the next DTE/ITE.
> 
> compute_next_devid_offset, compute_next_eventid_offset and
> lookup_table will become static in subsequent patches
> 
> Signed-off-by: Eric Auger <eric.auger@redhat.com>
> 
> ---
> v4 -> v5:
> - use kvm_read_guest
> 
> v3 -> v4:
> - remove static to avoid compilation warning
> - correct size computation in looup_table()
> - defines now encode the number of bits used for devid and eventid offsets
> - use BIT() - 1 to encode the max offets
> ---
>  virt/kvm/arm/vgic/vgic-its.c | 93 ++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 93 insertions(+)
> 
> diff --git a/virt/kvm/arm/vgic/vgic-its.c b/virt/kvm/arm/vgic/vgic-its.c
> index 56c5123..c22b35d 100644
> --- a/virt/kvm/arm/vgic/vgic-its.c
> +++ b/virt/kvm/arm/vgic/vgic-its.c
> @@ -195,6 +195,8 @@ static struct its_ite *find_ite(struct vgic_its *its, u32 device_id,
>  
>  #define VITS_TYPER_IDBITS 16
>  #define VITS_TYPER_DEVBITS 16
> +#define VITS_DTE_MAX_DEVID_OFFSET	(BIT(14) - 1)
> +#define VITS_ITE_MAX_EVENTID_OFFSET	(BIT(16) - 1)
>  
>  /*
>   * Finds and returns a collection in the ITS collection table.
> @@ -1674,6 +1676,97 @@ int vgic_its_attr_regs_access(struct kvm_device *dev,
>  	return ret;
>  }
>  
> +u32 compute_next_devid_offset(struct list_head *h, struct its_device *dev)
> +{
> +	struct list_head *e = &dev->dev_list;
> +	struct its_device *next;
> +	u32 next_offset;
> +
> +	if (e->next == h)
> +		return 0;
> +	next = list_entry(e->next, struct its_device, dev_list);
> +	next_offset = next->device_id - dev->device_id;
> +
> +	return min_t(u32, next_offset, VITS_DTE_MAX_DEVID_OFFSET);
> +}
> +
> +u32 compute_next_eventid_offset(struct list_head *h, struct its_ite *ite)
> +{
> +	struct list_head *e = &ite->ite_list;
> +	struct its_ite *next;
> +	u32 next_offset;
> +
> +	if (e->next == h)
> +		return 0;
> +	next = list_entry(e->next, struct its_ite, ite_list);
> +	next_offset = next->event_id - ite->event_id;
> +
> +	return min_t(u32, next_offset, VITS_ITE_MAX_EVENTID_OFFSET);

nit: in both of these functions you can avoid the extra e variable and
maybe make this slightly more readable by using these two calls instead:

list_is_last(&ite->ite_list, h);
next = list_next_entry(ite, ite_list);

Thanks,
-Christoffer

  parent reply	other threads:[~2017-04-30 20:13 UTC|newest]

Thread overview: 132+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-14 10:15 [PATCH v5 00/22] vITS save/restore Eric Auger
2017-04-14 10:15 ` [PATCH v5 01/22] KVM: arm/arm64: Add ITS save/restore API documentation Eric Auger
2017-04-25 10:38   ` Peter Maydell
2017-04-26 12:31   ` Christoffer Dall
2017-04-26 15:48     ` Auger Eric
2017-04-27  8:57       ` Christoffer Dall
2017-04-27  9:33         ` Auger Eric
2017-04-27 11:02           ` Christoffer Dall
2017-04-27 12:51             ` Auger Eric
2017-04-27 14:45               ` Christoffer Dall
2017-04-27 15:29                 ` Auger Eric
2017-04-27 16:23                   ` Marc Zyngier
2017-04-27 17:14                     ` Auger Eric
2017-04-27 17:27                       ` Christoffer Dall
2017-04-27 16:38                   ` Christoffer Dall
2017-04-27 17:27                     ` Auger Eric
2017-04-27 17:54                       ` Christoffer Dall
2017-04-27 19:27                         ` Auger Eric
2017-05-04  7:00                 ` Auger Eric
2017-05-04  7:40                   ` Marc Zyngier
2017-05-04  7:54                     ` Auger Eric
2017-05-04  7:46                   ` Christoffer Dall
2017-04-14 10:15 ` [PATCH v5 02/22] KVM: arm/arm64: Add GICV3 pending table save " Eric Auger
2017-04-25 10:43   ` Peter Maydell
2017-04-26  8:26     ` Auger Eric
2017-04-26  8:44       ` Peter Maydell
2017-04-26  8:48         ` Dr. David Alan Gilbert
2017-04-26  9:57           ` Auger Eric
2017-04-26 13:00             ` Christoffer Dall
2017-04-26 13:01               ` Peter Maydell
2017-04-26 13:14                 ` Christoffer Dall
2017-04-26 13:26                   ` Peter Maydell
2017-04-26 14:47                     ` Auger Eric
2017-04-14 10:15 ` [PATCH v5 03/22] KVM: arm/arm64: vgic-its: rename itte into ite Eric Auger
2017-04-26 11:21   ` Prakash B
2017-04-27  9:05   ` Christoffer Dall
2017-04-27  9:20     ` Andre Przywara
2017-04-27  9:40       ` Auger Eric
2017-04-27 11:09         ` Christoffer Dall
2017-04-14 10:15 ` [PATCH v5 04/22] arm/arm64: vgic: turn vgic_find_mmio_region into public Eric Auger
2017-04-26 11:22   ` Prakash B
2017-04-27  9:07   ` Christoffer Dall
2017-04-14 10:15 ` [PATCH v5 05/22] KVM: arm64: vgic-its: KVM_DEV_ARM_VGIC_GRP_ITS_REGS group Eric Auger
2017-04-26 11:23   ` Prakash B
2017-04-27  9:12   ` Christoffer Dall
2017-04-14 10:15 ` [PATCH v5 06/22] KVM: arm/arm64: vgic: expose (un)lock_all_vcpus Eric Auger
2017-04-26 11:23   ` Prakash B
2017-04-27  9:18   ` Christoffer Dall
2017-04-14 10:15 ` [PATCH v5 07/22] KVM: arm64: vgic-its: Implement vgic_its_has_attr_regs and attr_regs_access Eric Auger
2017-04-26 11:24   ` Prakash B
2017-04-27 11:00   ` Christoffer Dall
2017-04-27 12:22     ` Auger Eric
2017-04-14 10:15 ` [PATCH v5 08/22] KVM: arm64: vgic-its: Implement vgic_mmio_uaccess_write_its_creadr Eric Auger
2017-04-26 11:24   ` Prakash B
2017-04-27 11:27   ` Christoffer Dall
2017-04-27 12:53     ` Auger Eric
2017-04-14 10:15 ` [PATCH v5 09/22] KVM: arm64: vgic-its: Introduce migration ABI infrastructure Eric Auger
2017-04-26 11:27   ` Prakash B
2017-04-27 13:14   ` Christoffer Dall
2017-04-14 10:15 ` [PATCH v5 10/22] KVM: arm64: vgic-its: Implement vgic_mmio_uaccess_write_its_iidr Eric Auger
2017-04-26 11:27   ` Prakash B
2017-04-27 14:57   ` Christoffer Dall
2017-04-14 10:15 ` [PATCH v5 11/22] KVM: arm64: vgic-its: Interpret MAPD Size field and check related errors Eric Auger
2017-04-26 11:28   ` Prakash B
2017-04-27 16:25   ` Christoffer Dall
2017-04-27 17:15     ` Auger Eric
2017-04-27 17:28       ` Christoffer Dall
2017-04-14 10:15 ` [PATCH v5 12/22] KVM: arm64: vgic-its: Interpret MAPD ITT_addr field Eric Auger
2017-04-26 11:29   ` Prakash B
2017-04-27 16:43   ` Christoffer Dall
2017-04-27 17:44     ` Auger Eric
2017-04-27 18:09       ` Christoffer Dall
2017-04-27 19:18         ` Auger Eric
2017-04-14 10:15 ` [PATCH v5 13/22] KVM: arm64: vgic-its: Check the device id matches TYPER DEVBITS range Eric Auger
2017-04-26 11:29   ` Prakash B
2017-04-27 16:48   ` Christoffer Dall
2017-04-27 17:24     ` Auger Eric
2017-04-14 10:15 ` [PATCH v5 14/22] KVM: arm64: vgic-its: KVM_DEV_ARM_ITS_SAVE/RESTORE_TABLES Eric Auger
2017-04-26 11:31   ` Prakash B
2017-04-27 17:24   ` Christoffer Dall
2017-04-14 10:15 ` [PATCH v5 15/22] KVM: arm64: vgic-its: vgic_its_alloc_ite/device Eric Auger
2017-04-26 11:31   ` Prakash B
2017-04-27 17:31   ` Christoffer Dall
2017-04-14 10:15 ` [PATCH v5 16/22] KVM: arm64: vgic-its: Add infrastructure for table lookup Eric Auger
2017-04-26 11:32   ` Prakash B
2017-04-27 18:06   ` Christoffer Dall
2017-04-27 19:24     ` Auger Eric
2017-04-28  9:47       ` Christoffer Dall
2017-04-30 19:33   ` Christoffer Dall
2017-05-03 13:40     ` Auger Eric
2017-05-03 14:38       ` Christoffer Dall
2017-04-30 19:35   ` Christoffer Dall
2017-05-03  6:53     ` Auger Eric
2017-05-03  8:01       ` Christoffer Dall
2017-05-03 10:22         ` Auger Eric
2017-04-30 20:13   ` Christoffer Dall [this message]
2017-04-14 10:15 ` [PATCH v5 17/22] KVM: arm64: vgic-its: Collection table save/restore Eric Auger
2017-04-26 11:33   ` Prakash B
2017-04-28 10:44   ` Christoffer Dall
2017-04-28 11:05     ` Auger Eric
2017-04-28 17:42       ` Christoffer Dall
2017-04-14 10:15 ` [PATCH v5 18/22] KVM: arm64: vgic-its: vgic_its_check_id returns the entry's GPA Eric Auger
2017-04-26 11:33   ` Prakash B
2017-05-02  8:29   ` Christoffer Dall
2017-04-14 10:15 ` [PATCH v5 19/22] KVM: arm64: vgic-its: ITT save and restore Eric Auger
2017-04-26 11:34   ` Prakash B
2017-04-30 20:14   ` Christoffer Dall
2017-05-03 16:08     ` Auger Eric
2017-05-03 16:37       ` Christoffer Dall
2017-05-03 21:55         ` Auger Eric
2017-05-04  7:31           ` Christoffer Dall
2017-05-04  7:40             ` Auger Eric
2017-05-04  8:23               ` Christoffer Dall
2017-05-04  8:44                 ` Auger Eric
2017-04-14 10:15 ` [PATCH v5 20/22] KVM: arm64: vgic-its: Device table save/restore Eric Auger
2017-04-26 11:34   ` Prakash B
2017-04-30 20:55   ` Christoffer Dall
2017-05-03 14:07     ` Auger Eric
2017-05-03 15:29       ` Christoffer Dall
2017-05-03 21:38         ` Auger Eric
2017-04-14 10:15 ` [PATCH v5 21/22] KVM: arm64: vgic-its: Fix pending table sync Eric Auger
2017-04-26 11:35   ` Prakash B
2017-04-30 21:10   ` Christoffer Dall
2017-05-03 22:20     ` Auger Eric
2017-05-04  7:32       ` Christoffer Dall
2017-04-14 10:15 ` [PATCH v5 22/22] KVM: arm64: vgic-v3: KVM_DEV_ARM_VGIC_SAVE_PENDING_TABLES Eric Auger
2017-04-26 11:35   ` Prakash B
2017-04-30 21:32   ` Christoffer Dall
2017-05-03 22:22     ` Auger Eric
2017-04-26 11:38 ` [PATCH v5 00/22] vITS save/restore Prakash B
2017-04-26 13:02   ` Christoffer Dall
2017-04-27  6:55   ` Auger Eric

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170430201338.GC1670@lvm \
    --to=christoffer.dall@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).