linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: imx6sx-sdb: Remove cpufreq OPP override
Date: Wed, 3 May 2017 22:41:01 +0800	[thread overview]
Message-ID: <20170503144059.GL18578@dragon> (raw)
In-Reply-To: <0f84e2ee-1ea1-acf8-8368-3fc848d33e23@denx.de>

On Wed, May 03, 2017 at 04:32:06PM +0200, Marek Vasut wrote:
> On 05/03/2017 04:26 PM, Marek Vasut wrote:
> > On 05/03/2017 03:57 PM, Shawn Guo wrote:
> >> On Tue, Apr 25, 2017 at 07:28:06PM +0200, Marek Vasut wrote:
> >>> On 04/25/2017 07:23 PM, Leonard Crestez wrote:
> >>>> Anyway, that version also sets the supply for reg_arm and reg_soc. It
> >>>> is not necessary for fixing the crash I'm seeing but is good because it
> >>>> will result in the minimum voltage on VDD_ARM_SOC_IN rather than a fix
> >>>> 1375mv. I tested Marek's patch and it works fine on my rev B board
> >>>> (which otherwise fails to boot upstream).
> >>>
> >>> Oh that's nice , thanks ! I don't have SDB and I hacked it up after a
> >>> brief discussion with Fabio without even compile-testing it, thus RFC.
> >>> Glad to hear it works and thanks for testing it ! Can you add a formal
> >>> Tested-by please ?
> >>
> >> Hi Marek,
> > 
> > Hi Shawn,
> > 
> >> Thanks for your patch.  But I prefer Leonard's version because: 1) it
> >> has a better commit log; 2) it sticks to one-patch-does-one-thing
> >> policy.
> > 
> > Well I'd prefer this patch because
> > 1) It has T-B
> 
> Correction, two TBs [1]
> 
> [1] https://patchwork.kernel.org/patch/9698749/

That doesn't mean Leonard's patch hasn't been tested by anyone.

> > 2) It actually fixes a problem with the voltage rails such that the DVFS
> >    works without leaving the system in unstable or dead state. You do
> >    need the second part of my patch if you drop the OPP hackery, without
> >    it the power framework cannot correctly configure the core voltages,
> >    so the patch from Leonard makes things worse.

If that's true, I will change my mind.

Shawn

  reply	other threads:[~2017-05-03 14:41 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-25 16:57 [PATCH] ARM: dts: imx6sx-sdb: Remove cpufreq OPP override Leonard Crestez
2017-04-25 17:02 ` Fabio Estevam
2017-04-25 17:02   ` Fabio Estevam
2017-04-25 17:23     ` Leonard Crestez
2017-04-25 17:26       ` Fabio Estevam
2017-04-25 17:28       ` Marek Vasut
2017-05-03 13:57         ` Shawn Guo
2017-05-03 14:26           ` Marek Vasut
2017-05-03 14:32             ` Marek Vasut
2017-05-03 14:41               ` Shawn Guo [this message]
2017-05-03 14:51                 ` Marek Vasut
2017-05-03 14:58             ` Leonard Crestez
2017-05-03 15:59               ` Marek Vasut
2017-05-03 17:58                 ` Leonard Crestez
2017-05-03 19:33                   ` Marek Vasut
2017-05-04  9:42                     ` Leonard Crestez
2017-05-04 10:06                       ` Marek Vasut
2017-05-04 12:44                         ` Shawn Guo
2017-05-04 13:08                           ` Marek Vasut
2017-05-04 13:41                             ` Shawn Guo
2017-05-04 14:34                               ` Marek Vasut
2017-05-05  1:18                                 ` Shawn Guo
2017-05-05 10:11                                   ` Leonard Crestez
2017-04-27  1:17 ` Peter Chen
2017-05-04 11:43   ` Shawn Guo
2017-05-04 11:46     ` Fabio Estevam
2017-05-04 12:50 ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170503144059.GL18578@dragon \
    --to=shawnguo@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).