From: linux@armlinux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: Fix __show_regs output timestamps
Date: Wed, 3 May 2017 20:23:11 +0100 [thread overview]
Message-ID: <20170503192310.GD22219@n2100.armlinux.org.uk> (raw)
In-Reply-To: <61817479ac8c4c6c8be702d2e2136fddac1b1821.1493228290.git.joe@perches.com>
On Wed, Apr 26, 2017 at 10:39:49AM -0700, Joe Perches wrote:
> Multiple line formats are not preferred as the second and
> subsequent lines may not have timestamps.
>
> Lacking timestamps makes reading the output a bit difficult.
> This also makes arm/arm64 output more similar.
>
> Previous:
>
> [ 1514.093231] pc : [<bf79c304>] lr : [<bf79ced8>] psr: a00f0013
> sp : ecdd7e20 ip : 00000000 fp : ffffffff
>
> New:
>
> [ 1514.093231] pc : [<bf79c304>] lr : [<bf79ced8>] psr: a00f0013
> [ 1514.105316] sp : ecdd7e20 ip : 00000000 fp : ffffffff
>
> Signed-off-by: Joe Perches <joe@perches.com>
Hi Joe,
Could you put this in my patch system please, I'm unlikely to remember to
apply it otherwise if not already there (massive email backlog.)
Thanks.
> ---
> arch/arm/kernel/process.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/kernel/process.c b/arch/arm/kernel/process.c
> index 939e8b58c59d..151cece4a293 100644
> --- a/arch/arm/kernel/process.c
> +++ b/arch/arm/kernel/process.c
> @@ -123,10 +123,10 @@ void __show_regs(struct pt_regs *regs)
>
> print_symbol("PC is at %s\n", instruction_pointer(regs));
> print_symbol("LR is at %s\n", regs->ARM_lr);
> - printk("pc : [<%08lx>] lr : [<%08lx>] psr: %08lx\n"
> - "sp : %08lx ip : %08lx fp : %08lx\n",
> - regs->ARM_pc, regs->ARM_lr, regs->ARM_cpsr,
> - regs->ARM_sp, regs->ARM_ip, regs->ARM_fp);
> + printk("pc : [<%08lx>] lr : [<%08lx>] psr: %08lx\n",
> + regs->ARM_pc, regs->ARM_lr, regs->ARM_cpsr);
> + printk("sp : %08lx ip : %08lx fp : %08lx\n",
> + regs->ARM_sp, regs->ARM_ip, regs->ARM_fp);
> printk("r10: %08lx r9 : %08lx r8 : %08lx\n",
> regs->ARM_r10, regs->ARM_r9,
> regs->ARM_r8);
> --
> 2.10.0.rc2.1.g053435c
>
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2017-05-03 19:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-26 17:39 [PATCH] ARM: Fix __show_regs output timestamps Joe Perches
2017-04-26 20:18 ` Andreas Kemnade
2017-05-03 19:23 ` Russell King - ARM Linux [this message]
2017-05-03 19:40 ` Joe Perches
2017-05-03 19:44 ` Joe Perches
2017-05-03 21:30 ` Russell King - ARM Linux
2017-05-04 0:24 ` Joe Perches
2017-05-04 8:27 ` Vladimir Murzin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170503192310.GD22219@n2100.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).