[PATCH v2 03/10] pinctrl: sunxi: add A20 support to A10 driver

Maxime Ripard
2017-05-04T14:41:52Z

On Thu, May 04, 2017 at 10:03:26PM +0800, Icenowy Zheng wrote:
>
>
> ? 2017?5?4? GMT+08:00 ??10:02:20, Maxime Ripard <maxime.ripard@free-electrons.com> ??:
> >On Thu, May 04, 2017 at 09:49:59PM +0800, Icenowy Zheng wrote:
> >> static const struct of_device_id sun4i_a10_pinctrl_match[] = {
> >> - { .compatible = "allwinner,sun4i-a10-pinctrl", },
> >> + {
> >> + .compatible = "allwinner,sun4i-a10-pinctrl",
> >> + .data = (void *)PINCTRL_SUN4I_A10
> >> + },
> >> + {
> >> + .compatible = "allwinner,sun7i-a20-pinctrl",
> >> + .data = (void *)PINCTRL_SUN7I_A20
> >> + },
> >> {}
> >> };
> >
> >This means you're going to have two drivers probing for the same
> >device: this driver, and the old one. This is not ok, and probably
> >introduces some corner cases.
>
> The A20 driver is dropped in the next commit.

Yes, and that is an issue for bisectability. Anyone that will checkout
between those two commits will have a broken kernel, and that is not
ok. Any commit should be in a working state.

Maxime

--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170504/c11aab5e/attachment.sig>