* [PATCH] ARM: dts: imx: add DH2228FV DAC to Gateworks Ventana boards with SPI
@ 2017-05-03 15:04 Tim Harvey
2017-05-05 1:56 ` Shawn Guo
0 siblings, 1 reply; 4+ messages in thread
From: Tim Harvey @ 2017-05-03 15:04 UTC (permalink / raw)
To: linux-arm-kernel
Signed-off-by: Tim Harvey <tharvey@gateworks.com>
---
arch/arm/boot/dts/imx6qdl-gw52xx.dtsi | 6 ++++++
arch/arm/boot/dts/imx6qdl-gw54xx.dtsi | 6 ++++++
arch/arm/boot/dts/imx6qdl-gw560x.dtsi | 6 ++++++
3 files changed, 18 insertions(+)
diff --git a/arch/arm/boot/dts/imx6qdl-gw52xx.dtsi b/arch/arm/boot/dts/imx6qdl-gw52xx.dtsi
index 91991d6..b5c1a8f 100644
--- a/arch/arm/boot/dts/imx6qdl-gw52xx.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-gw52xx.dtsi
@@ -143,6 +143,12 @@
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_ecspi3>;
status = "okay";
+
+ spidev0: spidev at 0 {
+ compatible = "rohm,dh2228fv";
+ reg = <0>;
+ spi-max-frequency = <60000000>;
+ };
};
&fec {
diff --git a/arch/arm/boot/dts/imx6qdl-gw54xx.dtsi b/arch/arm/boot/dts/imx6qdl-gw54xx.dtsi
index 968fda9..9d26511 100644
--- a/arch/arm/boot/dts/imx6qdl-gw54xx.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-gw54xx.dtsi
@@ -154,6 +154,12 @@
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_ecspi2>;
status = "okay";
+
+ spidev0: spidev at 0 {
+ compatible = "rohm,dh2228fv";
+ reg = <0>;
+ spi-max-frequency = <60000000>;
+ };
};
&fec {
diff --git a/arch/arm/boot/dts/imx6qdl-gw560x.dtsi b/arch/arm/boot/dts/imx6qdl-gw560x.dtsi
index d894dde..bfb63e9 100644
--- a/arch/arm/boot/dts/imx6qdl-gw560x.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-gw560x.dtsi
@@ -208,6 +208,12 @@
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_ecspi3>;
status = "okay";
+
+ spidev0: spidev at 0 {
+ compatible = "rohm,dh2228fv";
+ reg = <0>;
+ spi-max-frequency = <60000000>;
+ };
};
&can1 {
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] ARM: dts: imx: add DH2228FV DAC to Gateworks Ventana boards with SPI
2017-05-03 15:04 [PATCH] ARM: dts: imx: add DH2228FV DAC to Gateworks Ventana boards with SPI Tim Harvey
@ 2017-05-05 1:56 ` Shawn Guo
2017-05-05 4:29 ` Tim Harvey
0 siblings, 1 reply; 4+ messages in thread
From: Shawn Guo @ 2017-05-05 1:56 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, May 03, 2017 at 08:04:54AM -0700, Tim Harvey wrote:
> Signed-off-by: Tim Harvey <tharvey@gateworks.com>
> ---
> arch/arm/boot/dts/imx6qdl-gw52xx.dtsi | 6 ++++++
> arch/arm/boot/dts/imx6qdl-gw54xx.dtsi | 6 ++++++
> arch/arm/boot/dts/imx6qdl-gw560x.dtsi | 6 ++++++
> 3 files changed, 18 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx6qdl-gw52xx.dtsi b/arch/arm/boot/dts/imx6qdl-gw52xx.dtsi
> index 91991d6..b5c1a8f 100644
> --- a/arch/arm/boot/dts/imx6qdl-gw52xx.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-gw52xx.dtsi
> @@ -143,6 +143,12 @@
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_ecspi3>;
> status = "okay";
> +
> + spidev0: spidev at 0 {
> + compatible = "rohm,dh2228fv";
I do not see this is a documented compatible.
Shawn
> + reg = <0>;
> + spi-max-frequency = <60000000>;
> + };
> };
>
> &fec {
> diff --git a/arch/arm/boot/dts/imx6qdl-gw54xx.dtsi b/arch/arm/boot/dts/imx6qdl-gw54xx.dtsi
> index 968fda9..9d26511 100644
> --- a/arch/arm/boot/dts/imx6qdl-gw54xx.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-gw54xx.dtsi
> @@ -154,6 +154,12 @@
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_ecspi2>;
> status = "okay";
> +
> + spidev0: spidev at 0 {
> + compatible = "rohm,dh2228fv";
> + reg = <0>;
> + spi-max-frequency = <60000000>;
> + };
> };
>
> &fec {
> diff --git a/arch/arm/boot/dts/imx6qdl-gw560x.dtsi b/arch/arm/boot/dts/imx6qdl-gw560x.dtsi
> index d894dde..bfb63e9 100644
> --- a/arch/arm/boot/dts/imx6qdl-gw560x.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-gw560x.dtsi
> @@ -208,6 +208,12 @@
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_ecspi3>;
> status = "okay";
> +
> + spidev0: spidev at 0 {
> + compatible = "rohm,dh2228fv";
> + reg = <0>;
> + spi-max-frequency = <60000000>;
> + };
> };
>
> &can1 {
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] ARM: dts: imx: add DH2228FV DAC to Gateworks Ventana boards with SPI
2017-05-05 1:56 ` Shawn Guo
@ 2017-05-05 4:29 ` Tim Harvey
2017-05-10 1:04 ` Shawn Guo
0 siblings, 1 reply; 4+ messages in thread
From: Tim Harvey @ 2017-05-05 4:29 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, May 4, 2017 at 6:56 PM, Shawn Guo <shawnguo@kernel.org> wrote:
> On Wed, May 03, 2017 at 08:04:54AM -0700, Tim Harvey wrote:
>> Signed-off-by: Tim Harvey <tharvey@gateworks.com>
>> ---
>> arch/arm/boot/dts/imx6qdl-gw52xx.dtsi | 6 ++++++
>> arch/arm/boot/dts/imx6qdl-gw54xx.dtsi | 6 ++++++
>> arch/arm/boot/dts/imx6qdl-gw560x.dtsi | 6 ++++++
>> 3 files changed, 18 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/imx6qdl-gw52xx.dtsi b/arch/arm/boot/dts/imx6qdl-gw52xx.dtsi
>> index 91991d6..b5c1a8f 100644
>> --- a/arch/arm/boot/dts/imx6qdl-gw52xx.dtsi
>> +++ b/arch/arm/boot/dts/imx6qdl-gw52xx.dtsi
>> @@ -143,6 +143,12 @@
>> pinctrl-names = "default";
>> pinctrl-0 = <&pinctrl_ecspi3>;
>> status = "okay";
>> +
>> + spidev0: spidev at 0 {
>> + compatible = "rohm,dh2228fv";
>
> I do not see this is a documented compatible.
>
> Shawn
>
Shawn,
No, it doesn't seem to be documented in
Documentation/devicetree/bindings, but it is in the spidev driver:
https://lxr.missinglinkelectronics.com/linux/drivers/spi/spidev.c#L697
Regards,
Tim
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] ARM: dts: imx: add DH2228FV DAC to Gateworks Ventana boards with SPI
2017-05-05 4:29 ` Tim Harvey
@ 2017-05-10 1:04 ` Shawn Guo
0 siblings, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2017-05-10 1:04 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, May 04, 2017 at 09:29:27PM -0700, Tim Harvey wrote:
> On Thu, May 4, 2017 at 6:56 PM, Shawn Guo <shawnguo@kernel.org> wrote:
> > On Wed, May 03, 2017 at 08:04:54AM -0700, Tim Harvey wrote:
> >> Signed-off-by: Tim Harvey <tharvey@gateworks.com>
> >> ---
> >> arch/arm/boot/dts/imx6qdl-gw52xx.dtsi | 6 ++++++
> >> arch/arm/boot/dts/imx6qdl-gw54xx.dtsi | 6 ++++++
> >> arch/arm/boot/dts/imx6qdl-gw560x.dtsi | 6 ++++++
> >> 3 files changed, 18 insertions(+)
> >>
> >> diff --git a/arch/arm/boot/dts/imx6qdl-gw52xx.dtsi b/arch/arm/boot/dts/imx6qdl-gw52xx.dtsi
> >> index 91991d6..b5c1a8f 100644
> >> --- a/arch/arm/boot/dts/imx6qdl-gw52xx.dtsi
> >> +++ b/arch/arm/boot/dts/imx6qdl-gw52xx.dtsi
> >> @@ -143,6 +143,12 @@
> >> pinctrl-names = "default";
> >> pinctrl-0 = <&pinctrl_ecspi3>;
> >> status = "okay";
> >> +
> >> + spidev0: spidev at 0 {
> >> + compatible = "rohm,dh2228fv";
> >
> > I do not see this is a documented compatible.
> >
> > Shawn
> >
>
> Shawn,
>
> No, it doesn't seem to be documented in
> Documentation/devicetree/bindings, but it is in the spidev driver:
> https://lxr.missinglinkelectronics.com/linux/drivers/spi/spidev.c#L697
Can you please add a patch documenting the compatible?
Shawn
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-05-10 1:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-03 15:04 [PATCH] ARM: dts: imx: add DH2228FV DAC to Gateworks Ventana boards with SPI Tim Harvey
2017-05-05 1:56 ` Shawn Guo
2017-05-05 4:29 ` Tim Harvey
2017-05-10 1:04 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).