From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: dts: ls1088a: update the sata node
Date: Thu, 11 May 2017 15:35:15 +0800 [thread overview]
Message-ID: <20170511073514.GE5833@dragon> (raw)
In-Reply-To: <1494213209-39673-1-git-send-email-andy.tang@nxp.com>
On Mon, May 08, 2017 at 11:13:29AM +0800, Yuantian Tang wrote:
> 1. Sata ecc should be disabled due to a erratum.
> Provide the ecc register address for driver to use.
This is a bit confusing. Are you saying that the ECC register address
is provided in DT for SATA driver to disable ECC function?
> 2. Enable dma coherence operation
>
> Signed-off-by: Tang Yuantian <andy.tang@nxp.com>
> ---
> arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> index 2946fd7..90edd76 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> @@ -265,10 +265,13 @@
>
> sata: sata at 3200000 {
> compatible = "fsl,ls1088a-ahci", "fsl,ls1043a-ahci";
> - reg = <0x0 0x3200000 0x0 0x10000>;
> + reg = <0x0 0x3200000 0x0 0x10000>,
> + <0x0 0x20140520 0x0 0x4>;
> + reg-names = "ahci", "sata-ecc";
> interrupts = <0 133 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&clockgen 4 3>;
> status = "disabled";
> + dma-coherent;
Please add it above 'status' line, which we generally keep at the bottom
of property list.
Shawn
> };
> };
>
> --
> 2.1.0.27.g96db324
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2017-05-11 7:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-08 3:13 [PATCH] arm64: dts: ls1088a: update the sata node Yuantian Tang
2017-05-11 7:35 ` Shawn Guo [this message]
2017-05-11 7:57 ` Andy Tang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170511073514.GE5833@dragon \
--to=shawnguo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox