From: tj@kernel.org (Tejun Heo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] pinctrl: use non-devm kmalloc versions for free functions
Date: Thu, 11 May 2017 10:45:26 -0400 [thread overview]
Message-ID: <20170511144526.GA30473@htj.duckdns.org> (raw)
In-Reply-To: <f529e2d1-68e0-2760-3fd0-c7b0e94dd003@arm.com>
Hello,
On Thu, May 11, 2017 at 03:20:58PM +0100, Andre Przywara wrote:
> > Tejun, do I read your comments on the patch as an ACK?
>
> Tejun and I were wondering why we need this "create an array with the
> indices" in the first place. If we can just call radix_tree_delete()
> directly from the radix_tree_for_each_slot() loop, we can have a much
> better fix (omitting the memory allocation at all)
Yeah, it doesn't make sense to allocate to destroy a radix tree. It'd
be much better to cleanup the code so that it doesn't need allocation
in the first place.
Thanks.
--
tejun
next prev parent reply other threads:[~2017-05-11 14:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-03 23:57 [PATCH] pinctrl: use non-devm kmalloc versions for free functions Andre Przywara
2017-05-04 12:03 ` Maxime Ripard
2017-05-04 16:00 ` Tejun Heo
2017-05-05 0:41 ` André Przywara
2017-05-05 19:55 ` Maxime Ripard
2017-05-05 21:49 ` Tejun Heo
2017-05-11 14:01 ` Linus Walleij
2017-05-11 14:02 ` [linux-sunxi] " Icenowy Zheng
2017-05-11 14:20 ` Andre Przywara
2017-05-11 14:45 ` Tejun Heo [this message]
2017-05-12 9:25 ` Linus Walleij
2017-05-12 15:35 ` Tony Lindgren
2017-05-12 17:14 ` Tony Lindgren
2017-05-13 0:24 ` André Przywara
2017-05-22 15:37 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170511144526.GA30473@htj.duckdns.org \
--to=tj@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).