From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 04/11] arm64: dts: Initial DTS files for Broadcom Stingray SOC
Date: Mon, 15 May 2017 14:13:35 +0100 [thread overview]
Message-ID: <20170515131334.GE17776@leverpostej> (raw)
In-Reply-To: <1494849741-21294-5-git-send-email-anup.patel@broadcom.com>
Hi,
On Mon, May 15, 2017 at 05:32:14PM +0530, Anup Patel wrote:
> +/ {
> + chosen { /* Default kernel args */
> + bootargs = "root=/dev/ram rw rootwait \
> + earlycon=uart8250,mmio32,0x68a10000 \
> + pci=pcie_bus_safe cma=64M";
Why do we need all of these?
> + linux,stdout-path = "serial0:115200n8";
Please drop the 'linux,' prefix here.
[...]
> + memory: memory at 80000000 {
> + device_type = "memory";
> + reg = <0x00000000 0x80000000 0 0x40000000>;
> + };
> +
> + psci {
> + compatible = "arm,psci-0.2";
> + method = "smc";
> + };
> +
> + pmu {
> + compatible = "arm,armv8-pmuv3";
> + interrupts = <GIC_PPI 7 IRQ_TYPE_LEVEL_HIGH>;
> + };
> +
> + timer {
> + compatible = "arm,armv8-timer";
> + interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(8) |
> + IRQ_TYPE_LEVEL_LOW)>,
> + <GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(8) |
> + IRQ_TYPE_LEVEL_LOW)>,
> + <GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(8) |
> + IRQ_TYPE_LEVEL_LOW)>,
> + <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(8) |
> + IRQ_TYPE_LEVEL_LOW)>;
GICv3 PPIs don't have a mask. See
Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.txt
Please remove the GIC_CPU_MASK_*() uses here and in this dts. They
shouldn't be there.
Thanks,
Mark.
next prev parent reply other threads:[~2017-05-15 13:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-15 12:02 [PATCH v2 00/11] Broadcom Stingray SOC Initial Support Anup Patel
2017-05-15 12:02 ` [PATCH v2 01/11] dt-bindings: bcm: Add Broadcom Stingray bindings document Anup Patel
2017-05-15 12:02 ` [PATCH v2 02/11] dt-bindings: clk: Extend binding doc for Stingray SOC Anup Patel
2017-05-15 12:02 ` [PATCH v2 03/11] clk: bcm: Add clocks " Anup Patel
2017-05-15 12:02 ` [PATCH v2 04/11] arm64: dts: Initial DTS files for Broadcom " Anup Patel
2017-05-15 13:13 ` Mark Rutland [this message]
2017-05-15 16:04 ` Scott Branden
2017-05-16 10:47 ` Anup Patel
2017-05-15 12:02 ` [PATCH v2 05/11] arm64: dts: Add clock DT nodes for " Anup Patel
2017-05-15 12:02 ` [PATCH v2 06/11] arm64: dts: Add NAND " Anup Patel
2017-05-15 12:02 ` [PATCH v2 07/11] arm64: dts: Add pinctrl " Anup Patel
2017-05-15 12:02 ` [PATCH v2 08/11] arm64: dts: Add GPIO " Anup Patel
2017-05-15 12:02 ` [PATCH v2 09/11] arm64: dts: Add I2C DT nodes for Stingray SoC Anup Patel
2017-05-15 12:02 ` [PATCH v2 10/11] arm64: dts: Add PL022, PL330 and SP805 DT nodes for Stingray Anup Patel
2017-05-15 12:02 ` [PATCH v2 11/11] arm64: dts: Add PWM and SDHCI DT nodes for Stingray SOC Anup Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170515131334.GE17776@leverpostej \
--to=mark.rutland@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox