* [patch V2 02/17] arm: Adjust system_state check [not found] <20170516184231.564888231@linutronix.de> @ 2017-05-16 18:42 ` Thomas Gleixner 2017-05-16 18:42 ` [patch V2 03/17] arm64: " Thomas Gleixner 1 sibling, 0 replies; 4+ messages in thread From: Thomas Gleixner @ 2017-05-16 18:42 UTC (permalink / raw) To: linux-arm-kernel To enable smp_processor_id() and might_sleep() debug checks earlier, it's required to add system states between SYSTEM_BOOTING and SYSTEM_RUNNING. Adjust the system_state check in ipi_cpu_stop() to handle the extra states. Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Cc: Russell King <linux@armlinux.org.uk> Cc: linux-arm-kernel at lists.infradead.org --- arch/arm/kernel/smp.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/arch/arm/kernel/smp.c +++ b/arch/arm/kernel/smp.c @@ -555,8 +555,7 @@ static DEFINE_RAW_SPINLOCK(stop_lock); */ static void ipi_cpu_stop(unsigned int cpu) { - if (system_state == SYSTEM_BOOTING || - system_state == SYSTEM_RUNNING) { + if (system_state <= SYSTEM_RUNNING) { raw_spin_lock(&stop_lock); pr_crit("CPU%u: stopping\n", cpu); dump_stack(); ^ permalink raw reply [flat|nested] 4+ messages in thread
* [patch V2 03/17] arm64: Adjust system_state check [not found] <20170516184231.564888231@linutronix.de> 2017-05-16 18:42 ` [patch V2 02/17] arm: Adjust system_state check Thomas Gleixner @ 2017-05-16 18:42 ` Thomas Gleixner 2017-05-17 10:09 ` Mark Rutland 2017-05-17 14:23 ` Catalin Marinas 1 sibling, 2 replies; 4+ messages in thread From: Thomas Gleixner @ 2017-05-16 18:42 UTC (permalink / raw) To: linux-arm-kernel To enable smp_processor_id() and might_sleep() debug checks earlier, it's required to add system states between SYSTEM_BOOTING and SYSTEM_RUNNING. Adjust the system_state check in smp_send_stop() to handle the extra states. Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Cc: Catalin Marinas <catalin.marinas@arm.com> Cc: Will Deacon <will.deacon@arm.com> Cc: Mark Rutland <mark.rutland@arm.com> Cc: linux-arm-kernel at lists.infradead.org --- arch/arm64/kernel/smp.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/arch/arm64/kernel/smp.c +++ b/arch/arm64/kernel/smp.c @@ -961,8 +961,7 @@ void smp_send_stop(void) cpumask_copy(&mask, cpu_online_mask); cpumask_clear_cpu(smp_processor_id(), &mask); - if (system_state == SYSTEM_BOOTING || - system_state == SYSTEM_RUNNING) + if (system_state <= SYSTEM_RUNNING) pr_crit("SMP: stopping secondary CPUs\n"); smp_cross_call(&mask, IPI_CPU_STOP); } ^ permalink raw reply [flat|nested] 4+ messages in thread
* [patch V2 03/17] arm64: Adjust system_state check 2017-05-16 18:42 ` [patch V2 03/17] arm64: " Thomas Gleixner @ 2017-05-17 10:09 ` Mark Rutland 2017-05-17 14:23 ` Catalin Marinas 1 sibling, 0 replies; 4+ messages in thread From: Mark Rutland @ 2017-05-17 10:09 UTC (permalink / raw) To: linux-arm-kernel On Tue, May 16, 2017 at 08:42:34PM +0200, Thomas Gleixner wrote: > To enable smp_processor_id() and might_sleep() debug checks earlier, it's > required to add system states between SYSTEM_BOOTING and SYSTEM_RUNNING. > > Adjust the system_state check in smp_send_stop() to handle the extra states. > > Signed-off-by: Thomas Gleixner <tglx@linutronix.de> > Cc: Catalin Marinas <catalin.marinas@arm.com> > Cc: Will Deacon <will.deacon@arm.com> > Cc: Mark Rutland <mark.rutland@arm.com> > Cc: linux-arm-kernel at lists.infradead.org > --- > arch/arm64/kernel/smp.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) FWIW: Acked-by: Mark Rutland <mark.rutland@arm.com> Mark. > > --- a/arch/arm64/kernel/smp.c > +++ b/arch/arm64/kernel/smp.c > @@ -961,8 +961,7 @@ void smp_send_stop(void) > cpumask_copy(&mask, cpu_online_mask); > cpumask_clear_cpu(smp_processor_id(), &mask); > > - if (system_state == SYSTEM_BOOTING || > - system_state == SYSTEM_RUNNING) > + if (system_state <= SYSTEM_RUNNING) > pr_crit("SMP: stopping secondary CPUs\n"); > smp_cross_call(&mask, IPI_CPU_STOP); > } > > ^ permalink raw reply [flat|nested] 4+ messages in thread
* [patch V2 03/17] arm64: Adjust system_state check 2017-05-16 18:42 ` [patch V2 03/17] arm64: " Thomas Gleixner 2017-05-17 10:09 ` Mark Rutland @ 2017-05-17 14:23 ` Catalin Marinas 1 sibling, 0 replies; 4+ messages in thread From: Catalin Marinas @ 2017-05-17 14:23 UTC (permalink / raw) To: linux-arm-kernel On Tue, May 16, 2017 at 08:42:34PM +0200, Thomas Gleixner wrote: > To enable smp_processor_id() and might_sleep() debug checks earlier, it's > required to add system states between SYSTEM_BOOTING and SYSTEM_RUNNING. > > Adjust the system_state check in smp_send_stop() to handle the extra states. > > Signed-off-by: Thomas Gleixner <tglx@linutronix.de> > Cc: Catalin Marinas <catalin.marinas@arm.com> > Cc: Will Deacon <will.deacon@arm.com> > Cc: Mark Rutland <mark.rutland@arm.com> > Cc: linux-arm-kernel at lists.infradead.org Acked-by: Catalin Marinas <catalin.marinas@arm.com> ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-05-17 14:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20170516184231.564888231@linutronix.de>
2017-05-16 18:42 ` [patch V2 02/17] arm: Adjust system_state check Thomas Gleixner
2017-05-16 18:42 ` [patch V2 03/17] arm64: " Thomas Gleixner
2017-05-17 10:09 ` Mark Rutland
2017-05-17 14:23 ` Catalin Marinas
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).