From mboxrd@z Thu Jan 1 00:00:00 1970 From: dongas86@gmail.com (Dong Aisheng) Date: Wed, 17 May 2017 11:39:27 +0800 Subject: [V2, 2/6] tty: serial: lpuart: add little endian 32 bit register support In-Reply-To: References: <1494834539-17523-3-git-send-email-aisheng.dong@nxp.com> Message-ID: <20170517033927.GC9913@b29396-OptiPlex-7040> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, May 16, 2017 at 02:15:08PM +0300, Nikita Yushchenko wrote: > > static u32 lpuart32_read(void __iomem *addr) > > { > > - return ioread32be(addr); > > + return lpuart_is_be ? ioread32be(addr) : readl(addr); > > } > > > > static void lpuart32_write(u32 val, void __iomem *addr) > > { > > - iowrite32be(val, addr); > > + if (lpuart_is_be) > > + iowrite32be(val, addr); > > + else > > + writel(val, addr); > > } > > What if this is ever executed on big endian system? > Sorry, not catching the point... What issues will meet? Regards Dong Aisheng