public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: clabbe.montjoie@gmail.com (Corentin Labbe)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/9] crypto: brcm - Use IPAD/OPAD constant
Date: Fri, 19 May 2017 08:53:24 +0200	[thread overview]
Message-ID: <20170519065331.27670-3-clabbe.montjoie@gmail.com> (raw)
In-Reply-To: <20170519065331.27670-1-clabbe.montjoie@gmail.com>

This patch simply replace all occurrence of HMAC IPAD/OPAD value by their
define.

Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
---
 drivers/crypto/bcm/cipher.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/crypto/bcm/cipher.c b/drivers/crypto/bcm/cipher.c
index cc0d5b98006e..61393dc70b0b 100644
--- a/drivers/crypto/bcm/cipher.c
+++ b/drivers/crypto/bcm/cipher.c
@@ -36,6 +36,7 @@
 #include <crypto/internal/aead.h>
 #include <crypto/aes.h>
 #include <crypto/des.h>
+#include <crypto/hmac.h>
 #include <crypto/sha.h>
 #include <crypto/md5.h>
 #include <crypto/authenc.h>
@@ -2510,8 +2511,8 @@ static int ahash_hmac_setkey(struct crypto_ahash *ahash, const u8 *key,
 		memcpy(ctx->opad, ctx->ipad, blocksize);
 
 		for (index = 0; index < blocksize; index++) {
-			ctx->ipad[index] ^= 0x36;
-			ctx->opad[index] ^= 0x5c;
+			ctx->ipad[index] ^= HMAC_IPAD_VALUE;
+			ctx->opad[index] ^= HMAC_OPAD_VALUE;
 		}
 
 		flow_dump("  ipad: ", ctx->ipad, blocksize);
-- 
2.13.0

  parent reply	other threads:[~2017-05-19  6:53 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-19  6:53 [PATCH v2 0/9] crypto: add HMAC IPAD/OPAD constant Corentin Labbe
2017-05-19  6:53 ` [PATCH v2 1/9] crypto: add hmac " Corentin Labbe
2017-05-19  6:53 ` Corentin Labbe [this message]
2017-05-19  6:53 ` [PATCH v2 3/9] crypto: ixp4xx - Use " Corentin Labbe
2017-05-19  6:53 ` [PATCH v2 4/9] crypto: marvell " Corentin Labbe
2017-05-19  9:17   ` Boris Brezillon
2017-05-19  6:53 ` [PATCH v2 5/9] crypto: mv_cesa " Corentin Labbe
2017-05-19  6:53 ` [PATCH v2 6/9] crypto: omap-sham " Corentin Labbe
2017-05-19  6:53 ` [PATCH v2 7/9] crypto: qat " Corentin Labbe
2017-05-19  6:53 ` [PATCH v2 8/9] crypto: mediatek " Corentin Labbe
2017-05-19  9:11   ` Matthias Brugger
2017-05-19  6:53 ` [PATCH v2 9/9] crypto: ccp " Corentin Labbe
2017-05-19 20:32   ` Gary R Hook
2017-05-23  5:03 ` [PATCH v2 0/9] crypto: add HMAC " Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170519065331.27670-3-clabbe.montjoie@gmail.com \
    --to=clabbe.montjoie@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox