linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: riel@redhat.com (riel at redhat.com)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/5] arm64: ascii armor the arm64 boot init stack canary
Date: Fri, 19 May 2017 17:26:35 -0400	[thread overview]
Message-ID: <20170519212636.30440-5-riel@redhat.com> (raw)
In-Reply-To: <20170519212636.30440-1-riel@redhat.com>

From: Rik van Riel <riel@redhat.com>

Use the ascii-armor canary to prevent unterminated C string overflows
from being able to successfully overwrite the canary, even if they
somehow obtain the canary value.

Inspired by execshield ascii-armor and PaX/grsecurity.

Signed-off-by: Rik van Riel <riel@redhat.com>
---
 arch/arm64/include/asm/stackprotector.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/include/asm/stackprotector.h b/arch/arm64/include/asm/stackprotector.h
index fe5e287dc56b..b86a0865ddf1 100644
--- a/arch/arm64/include/asm/stackprotector.h
+++ b/arch/arm64/include/asm/stackprotector.h
@@ -30,6 +30,7 @@ static __always_inline void boot_init_stack_canary(void)
 	/* Try to get a semi random initial value. */
 	get_random_bytes(&canary, sizeof(canary));
 	canary ^= LINUX_VERSION_CODE;
+	canary &= CANARY_MASK;
 
 	current->stack_canary = canary;
 	__stack_chk_guard = current->stack_canary;
-- 
2.9.3

  parent reply	other threads:[~2017-05-19 21:26 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-19 21:26 stackprotector: ascii armor the stack canary riel at redhat.com
2017-05-19 21:26 ` [PATCH 1/5] random, stackprotect: introduce get_random_canary function riel at redhat.com
2017-05-24  8:30   ` [PATCH 1/5] random,stackprotect: " Ingo Molnar
2017-05-19 21:26 ` [PATCH 2/5] fork, random: use get_random_canary to set tsk->stack_canary riel at redhat.com
2017-05-19 21:26 ` [PATCH 3/5] x86: ascii armor the x86_64 boot init stack canary riel at redhat.com
2017-05-19 21:26 ` riel at redhat.com [this message]
2017-05-19 21:26 ` [PATCH 5/5] sh64: ascii armor the sh64 " riel at redhat.com
2017-05-19 21:32 ` stackprotector: ascii armor the " Kees Cook
2017-05-24 11:57   ` Geert Uytterhoeven
2017-05-19 23:57 ` Daniel Micay
  -- strict thread matches above, loose matches on Subject: below --
2017-05-24 15:57 [PATCH v2 0/5] " riel at redhat.com
2017-05-24 15:57 ` [PATCH 4/5] arm64: ascii armor the arm64 boot init " riel at redhat.com
2017-05-24 16:16   ` Kees Cook

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170519212636.30440-5-riel@redhat.com \
    --to=riel@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).