linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: punit.agrawal@arm.com (Punit Agrawal)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 08/11] arm64: hugetlb: Override huge_pte_clear() to support contiguous hugepages
Date: Mon, 22 May 2017 15:39:55 +0100	[thread overview]
Message-ID: <20170522143958.12867-10-punit.agrawal@arm.com> (raw)
In-Reply-To: <20170522143958.12867-1-punit.agrawal@arm.com>

The default huge_pte_clear() implementation does not clear contiguous
page table entries when it encounters contiguous hugepages that are
supported on arm64.

Fix this by overriding the default implementation to clear all the
entries associated with contiguous hugepages.

Signed-off-by: Punit Agrawal <punit.agrawal@arm.com>
Cc: David Woods <dwoods@mellanox.com>
---
 arch/arm64/mm/hugetlbpage.c | 36 ++++++++++++++++++++++++++++++++++++
 1 file changed, 36 insertions(+)

diff --git a/arch/arm64/mm/hugetlbpage.c b/arch/arm64/mm/hugetlbpage.c
index e9061704aec3..240b2fd53266 100644
--- a/arch/arm64/mm/hugetlbpage.c
+++ b/arch/arm64/mm/hugetlbpage.c
@@ -68,6 +68,30 @@ static int find_num_contig(struct mm_struct *mm, unsigned long addr,
 	return CONT_PTES;
 }
 
+static inline int num_contig_ptes(unsigned long size, size_t *pgsize)
+{
+	int contig_ptes = 0;
+
+	*pgsize = size;
+
+	switch (size) {
+	case PUD_SIZE:
+	case PMD_SIZE:
+		contig_ptes = 1;
+		break;
+	case CONT_PMD_SIZE:
+		*pgsize = PMD_SIZE;
+		contig_ptes = CONT_PMDS;
+		break;
+	case CONT_PTE_SIZE:
+		*pgsize = PAGE_SIZE;
+		contig_ptes = CONT_PTES;
+		break;
+	}
+
+	return contig_ptes;
+}
+
 /*
  * Changing some bits of contiguous entries requires us to follow a
  * Break-Before-Make approach, breaking the whole contiguous set
@@ -245,6 +269,18 @@ pte_t arch_make_huge_pte(pte_t entry, struct vm_area_struct *vma,
 	return entry;
 }
 
+void huge_pte_clear(struct mm_struct *mm, unsigned long addr,
+		    pte_t *ptep, unsigned long sz)
+{
+	int i, ncontig;
+	size_t pgsize;
+
+	ncontig = num_contig_ptes(sz, &pgsize);
+
+	for (i = 0; i < ncontig; i++, addr += pgsize, ptep++)
+		pte_clear(mm, addr, ptep);
+}
+
 pte_t huge_ptep_get_and_clear(struct mm_struct *mm,
 			      unsigned long addr, pte_t *ptep)
 {
-- 
2.11.0

  parent reply	other threads:[~2017-05-22 14:39 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-22 14:39 [PATCH v3 00/11] arm64: Enable contiguous pte hugepage support Punit Agrawal
2017-05-22 14:39 ` Punit Agrawal
2017-05-22 14:39 ` [PATCH v3 01/11] arm64: hugetlb: set_huge_pte_at Add WARN_ON on !pte_present Punit Agrawal
2017-05-22 14:39 ` [PATCH v3 02/11] arm64: hugetlb: Refactor find_num_contig Punit Agrawal
2017-05-22 14:39 ` [PATCH v3 03/11] arm64: hugetlb: Introduce pte_pgprot helper Punit Agrawal
2017-05-22 14:39 ` [PATCH v3 04/11] arm64: hugetlb: Remove spurious calls to huge_ptep_offset Punit Agrawal
2017-05-22 14:39 ` [PATCH v3 05/11] arm64: hugetlb: Spring clean huge pte accessors Punit Agrawal
2017-05-22 14:39 ` [PATCH v3 06/11] arm64: hugetlb: Add break-before-make logic for contiguous entries Punit Agrawal
2017-05-22 14:39 ` [PATCH v3 07/11] arm64: hugetlbpages: Handle swap entries in huge_pte_offset() for contiguous hugepages Punit Agrawal
2017-05-22 14:39 ` Punit Agrawal [this message]
2017-05-22 16:45   ` [PATCH v3.1 8/11] arm64: hugetlb: Override huge_pte_clear() to support " Punit Agrawal
2017-05-22 14:39 ` [PATCH v3 09/11] arm64: hugetlb: Override set_huge_swap_pte_at() " Punit Agrawal
2017-05-22 16:48   ` [PATCH v3.1 9/11] " Punit Agrawal
2017-05-22 14:39 ` [PATCH v3 10/11] arm64: Re-enable support for " Punit Agrawal
2017-05-22 14:39 ` [PATCH v3 11/11] arm64: hugetlb: Cleanup setup_hugepagesz Punit Agrawal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170522143958.12867-10-punit.agrawal@arm.com \
    --to=punit.agrawal@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).